From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Eric Chanudet <echanude@redhat.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P
Date: Sat, 11 Feb 2023 12:39:09 +0100 [thread overview]
Message-ID: <2746d301-3f8b-e61c-b2c8-088d25f94d47@linaro.org> (raw)
In-Reply-To: <20230210145245.jyqir6odnkyr5zdl@echanude>
On 10/02/2023 15:52, Eric Chanudet wrote:
> On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote:
>> On 09/02/2023 18:55, Eric Chanudet wrote:
>>> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>>
>>>> Add the SoC ID entry for SA8775P.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>> include/dt-bindings/arm/qcom,ids.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Reviewed-by: Eric Chanudet <echanude@redhat.com>
>>> Tested-by: Eric Chanudet <echanude@redhat.com>
>>
>> How can you test a header? What type of testing Redhat does on the headers?
>
> IIUC that ID is compared against the one read from SMEM by the socinfo
> driver. I meant to confirm it matched the number the board I have
> returned. My apologies in advance if that was inappropriate.
OK... I would say it is a review then, but can be also this way.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-11 11:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 9:57 [PATCH v2 0/3] arm: qcom: sa8775p: add socinfo support Bartosz Golaszewski
2023-02-09 9:57 ` [PATCH v2 1/3] soc: qcom: smem: update max processor count Bartosz Golaszewski
2023-02-09 17:54 ` Eric Chanudet
2023-02-09 9:57 ` [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P Bartosz Golaszewski
2023-02-09 17:55 ` Eric Chanudet
2023-02-10 8:58 ` Krzysztof Kozlowski
2023-02-10 14:52 ` Eric Chanudet
2023-02-11 11:39 ` Krzysztof Kozlowski [this message]
2023-02-09 9:57 ` [PATCH v2 3/3] soc: qcom: socinfo: add support " Bartosz Golaszewski
2023-02-09 11:17 ` Krzysztof Kozlowski
2023-02-09 17:55 ` Eric Chanudet
2023-03-06 13:27 ` [PATCH v2 0/3] arm: qcom: sa8775p: add socinfo support Bartosz Golaszewski
2023-03-15 23:34 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2746d301-3f8b-e61c-b2c8-088d25f94d47@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox