Re: [PATCH 4/7] drm/msm/A6xx: Implement preemption for A7XX targets

[Antonino Maniscalco <antomani103@gmail.com>]

On 8/22/24 9:23 PM, Akhil P Oommen wrote:
> On Wed, Aug 21, 2024 at 04:34:15PM +0200, Antonino Maniscalco wrote:
>> On 8/19/24 10:08 PM, Akhil P Oommen wrote:
>>> On Thu, Aug 15, 2024 at 08:26:14PM +0200, Antonino Maniscalco wrote:
>>>> This patch implements preemption feature for A6xx targets, this allows
>>>> the GPU to switch to a higher priority ringbuffer if one is ready. A6XX
>>>> hardware as such supports multiple levels of preemption granularities,
>>>> ranging from coarse grained(ringbuffer level) to a more fine grained
>>>> such as draw-call level or a bin boundary level preemption. This patch
>>>> enables the basic preemption level, with more fine grained preemption
>>>> support to follow.
>>>>
>>>> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
>>>> Signed-off-by: Antonino Maniscalco <antomani103@gmail.com>
>>>> ---
>>>
>>> No postamble packets which resets perfcounters? It is necessary. Also, I
>>> think we should disable preemption during profiling like we disable slumber.
>>>
>>> -Akhil.
>>>
>>
>> You mention that we disable slumber during profiling however I wasn't able
>> to find code doing that. Can you please clarify which code you are referring
>> to or a mechanism through which the kernel can know when we are profiling?
>>
> 
> Please check msm_file_private_set_sysprof().
> 
> -Akhil
> 
>> Best regards,
>> -- 
>> Antonino Maniscalco <antomani103@gmail.com>
>>

I see, thank you. So as Connor said in the other message we want to 
distinguish the case of system profiling where we do want preemption and 
application level profiling where we do not want it. So sysprof is not 
the condition we want to check for to disable preemption, correct?

Best regards,
-- 
Antonino Maniscalco <antomani103@gmail.com>