From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BBE720311; Thu, 26 Dec 2024 02:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735180217; cv=none; b=XIbTf5HgtUP4/u5tz8WjaJCdv3PmPbE9gPCMVCm9lx7pXUYjr22ksBdNgkFM2xpf3OptOviY892UdmmiChP25uvJBZkgoCACiiB8Aqyi/RjodueiMITwoP7qrpIWquGDVKJzHtq4RFRDDSOagNE2oGQaGOk5seEnSbvo/jqrrTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735180217; c=relaxed/simple; bh=9R+VzPUW4pix0A6eax6yJu1hLeO74L6c/rXQjmQ0XLM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=WyOZlgGJ5ZPHH55cfe5o/Q5yMe9HF1qSKahx+wF3ja8TxzgKbHa6Q1pDgMas8rEZIo+JeljZHplUsZQIzj5m3GEQpxYnqkfsy8Xag3RaRdk51o26ftN+5uBPWl2Ln2Tz5MQatHAjYBtOP20sAXCKs+DtKHBQvqOVjOlrE/Lgsf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=HXSbTKb0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="HXSbTKb0" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BQ139tf008317; Thu, 26 Dec 2024 02:29:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= od/XFx58U98oR4tAvKQJ+3p2owZykZqJH532d7fHnEw=; b=HXSbTKb03N2O1w6q Z+2g02aS/hdpMUiuB0D1D88cC+FTgZgL+TB9qYM2i2KRVKiSEqcIacxdO9pPlM4k KvQa2BO6x3BgkPsF1BGZfd39jh0VqJuOUQ5hBQpb21Cs5nt5XQTwtEEA4d5zSh1U NXQ7TaexlRreyF7CMqcuXB936lOAZ9CdHBKto/56P5d4gwj+VT9NWyif9InyxcH1 9E6XiDdbL9vuMRE3/HadzlR63hNY7EUTK59A2TvDlopm+05cupLlrK8uwZpyQFKz ZmX08PiXkfRRXO7wJ8alYYqOoMMdn2x9xYOZWDAUDRuVbfRR4sITkwmTad2+NMF7 9Bvt2w== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43rhfksye2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Dec 2024 02:29:56 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BQ2TtDQ016070 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Dec 2024 02:29:55 GMT Received: from [10.253.74.39] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 25 Dec 2024 18:29:49 -0800 Message-ID: <278de6e8-de8f-458a-a4b9-92b3eb81fa77@quicinc.com> Date: Thu, 26 Dec 2024 10:29:45 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] net: stmmac: qcom-ethqos: Enable RX programmable swap on qcs615 To: Krzysztof Kozlowski , Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Jose Abreu , Maxime Coquelin CC: , , , , , References: <20241225-support_10m100m-v1-0-4b52ef48b488@quicinc.com> <20241225-support_10m100m-v1-2-4b52ef48b488@quicinc.com> <4b4ef1c1-a20b-4b65-ad37-b9aabe074ae1@kernel.org> Content-Language: en-US From: Yijie Yang In-Reply-To: <4b4ef1c1-a20b-4b65-ad37-b9aabe074ae1@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: AOBlQU9L5TuDKSokIOpvw-RMG2nQrM7M X-Proofpoint-ORIG-GUID: AOBlQU9L5TuDKSokIOpvw-RMG2nQrM7M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 mlxlogscore=955 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412260019 On 2024-12-25 19:37, Krzysztof Kozlowski wrote: > On 25/12/2024 11:04, Yijie Yang wrote: > >> static int qcom_ethqos_probe(struct platform_device *pdev) >> { >> - struct device_node *np = pdev->dev.of_node; >> + struct device_node *np = pdev->dev.of_node, *root; >> const struct ethqos_emac_driver_data *data; >> struct plat_stmmacenet_data *plat_dat; >> struct stmmac_resources stmmac_res; >> @@ -810,6 +805,15 @@ static int qcom_ethqos_probe(struct platform_device *pdev) >> ret = of_get_phy_mode(np, ðqos->phy_mode); >> if (ret) >> return dev_err_probe(dev, ret, "Failed to get phy mode\n"); >> + >> + root = of_find_node_by_path("/"); >> + if (root && of_device_is_compatible(root, "qcom,sa8540p-ride")) > > > Nope, your drivers are not supposed to poke root compatibles. Drop and > fix your driver to behave correctly for all existing devices. > Since this change introduces a new flag in the DTS, we must maintain ABI compatibility with the kernel. The new flag is specific to the board, so I need to ensure root nodes are matched to allow older boards to continue functioning as before. I'm happy to adopt that approach if there are any more elegant solutions. >> + ethqos->needs_rx_prog_swap = true; >> + else >> + ethqos->needs_rx_prog_swap = > Best regards, > Krzysztof -- Best Regards, Yijie