From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org, ilia.lin@kernel.org,
rafael@kernel.org, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org
Cc: ansuelsmth@gmail.com
Subject: Re: [PATCH v4 1/5] soc: qcom: socinfo: move SMEM item struct and defines to a header
Date: Fri, 26 May 2023 01:13:09 +0200 [thread overview]
Message-ID: <27f12349-1ee5-503b-3e38-e757db4331bc@linaro.org> (raw)
In-Reply-To: <20230525210214.78235-1-robimarko@gmail.com>
On 25.05.2023 23:02, Robert Marko wrote:
> Move SMEM item struct and related defines to a header in order to be able
> to reuse them in the SMEM driver instead of duplicating them.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/soc/qcom/socinfo.c | 67 +-----------------------------
> include/linux/soc/qcom/socinfo.h | 70 ++++++++++++++++++++++++++++++++
> 2 files changed, 71 insertions(+), 66 deletions(-)
> create mode 100644 include/linux/soc/qcom/socinfo.h
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index c2e4a57dd666..ee6bbf76d941 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -11,6 +11,7 @@
> #include <linux/random.h>
> #include <linux/slab.h>
> #include <linux/soc/qcom/smem.h>
> +#include <linux/soc/qcom/socinfo.h>
> #include <linux/string.h>
> #include <linux/stringify.h>
> #include <linux/sys_soc.h>
> @@ -32,15 +33,6 @@
> #define qcom_board_id(id) QCOM_ID_ ## id, __stringify(id)
> #define qcom_board_id_named(id, name) QCOM_ID_ ## id, (name)
>
> -#define SMEM_SOCINFO_BUILD_ID_LENGTH 32
> -#define SMEM_SOCINFO_CHIP_ID_LENGTH 32
> -
> -/*
> - * SMEM item id, used to acquire handles to respective
> - * SMEM region.
> - */
> -#define SMEM_HW_SW_BUILD_ID 137
> -
> #ifdef CONFIG_DEBUG_FS
> #define SMEM_IMAGE_VERSION_BLOCKS_COUNT 32
> #define SMEM_IMAGE_VERSION_SIZE 4096
> @@ -126,64 +118,7 @@ static const char *const pmic_models[] = {
> [58] = "PM8450",
> [65] = "PM8010",
> };
> -#endif /* CONFIG_DEBUG_FS */
> -
> -/* Socinfo SMEM item structure */
> -struct socinfo {
> - __le32 fmt;
> - __le32 id;
> - __le32 ver;
> - char build_id[SMEM_SOCINFO_BUILD_ID_LENGTH];
> - /* Version 2 */
> - __le32 raw_id;
> - __le32 raw_ver;
> - /* Version 3 */
> - __le32 hw_plat;
> - /* Version 4 */
> - __le32 plat_ver;
> - /* Version 5 */
> - __le32 accessory_chip;
> - /* Version 6 */
> - __le32 hw_plat_subtype;
> - /* Version 7 */
> - __le32 pmic_model;
> - __le32 pmic_die_rev;
> - /* Version 8 */
> - __le32 pmic_model_1;
> - __le32 pmic_die_rev_1;
> - __le32 pmic_model_2;
> - __le32 pmic_die_rev_2;
> - /* Version 9 */
> - __le32 foundry_id;
> - /* Version 10 */
> - __le32 serial_num;
> - /* Version 11 */
> - __le32 num_pmics;
> - __le32 pmic_array_offset;
> - /* Version 12 */
> - __le32 chip_family;
> - __le32 raw_device_family;
> - __le32 raw_device_num;
> - /* Version 13 */
> - __le32 nproduct_id;
> - char chip_id[SMEM_SOCINFO_CHIP_ID_LENGTH];
> - /* Version 14 */
> - __le32 num_clusters;
> - __le32 ncluster_array_offset;
> - __le32 num_defective_parts;
> - __le32 ndefective_parts_array_offset;
> - /* Version 15 */
> - __le32 nmodem_supported;
> - /* Version 16 */
> - __le32 feature_code;
> - __le32 pcode;
> - __le32 npartnamemap_offset;
> - __le32 nnum_partname_mapping;
> - /* Version 17 */
> - __le32 oem_variant;
> -};
>
> -#ifdef CONFIG_DEBUG_FS
> struct socinfo_params {
> u32 raw_device_family;
> u32 hw_plat_subtype;
> diff --git a/include/linux/soc/qcom/socinfo.h b/include/linux/soc/qcom/socinfo.h
> new file mode 100644
> index 000000000000..d1cbc49a2a2d
> --- /dev/null
> +++ b/include/linux/soc/qcom/socinfo.h
> @@ -0,0 +1,70 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifndef __QCOM_SOCINFO_H__
> +#define __QCOM_SOCINFO_H__
> +
> +/*
> + * SMEM item id, used to acquire handles to respective
> + * SMEM region.
> + */
> +#define SMEM_HW_SW_BUILD_ID 137
> +
> +#define SMEM_SOCINFO_BUILD_ID_LENGTH 32
> +#define SMEM_SOCINFO_CHIP_ID_LENGTH 32
> +
> +/* Socinfo SMEM item structure */
> +struct socinfo {
> + __le32 fmt;
> + __le32 id;
> + __le32 ver;
> + char build_id[SMEM_SOCINFO_BUILD_ID_LENGTH];
> + /* Version 2 */
> + __le32 raw_id;
> + __le32 raw_ver;
> + /* Version 3 */
> + __le32 hw_plat;
> + /* Version 4 */
> + __le32 plat_ver;
> + /* Version 5 */
> + __le32 accessory_chip;
> + /* Version 6 */
> + __le32 hw_plat_subtype;
> + /* Version 7 */
> + __le32 pmic_model;
> + __le32 pmic_die_rev;
> + /* Version 8 */
> + __le32 pmic_model_1;
> + __le32 pmic_die_rev_1;
> + __le32 pmic_model_2;
> + __le32 pmic_die_rev_2;
> + /* Version 9 */
> + __le32 foundry_id;
> + /* Version 10 */
> + __le32 serial_num;
> + /* Version 11 */
> + __le32 num_pmics;
> + __le32 pmic_array_offset;
> + /* Version 12 */
> + __le32 chip_family;
> + __le32 raw_device_family;
> + __le32 raw_device_num;
> + /* Version 13 */
> + __le32 nproduct_id;
> + char chip_id[SMEM_SOCINFO_CHIP_ID_LENGTH];
> + /* Version 14 */
> + __le32 num_clusters;
> + __le32 ncluster_array_offset;
> + __le32 num_defective_parts;
> + __le32 ndefective_parts_array_offset;
> + /* Version 15 */
> + __le32 nmodem_supported;
> + /* Version 16 */
> + __le32 feature_code;
> + __le32 pcode;
> + __le32 npartnamemap_offset;
> + __le32 nnum_partname_mapping;
> + /* Version 17 */
> + __le32 oem_variant;
> +};
> +
> +#endif
prev parent reply other threads:[~2023-05-25 23:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 21:02 [PATCH v4 1/5] soc: qcom: socinfo: move SMEM item struct and defines to a header Robert Marko
2023-05-25 21:02 ` [PATCH v4 2/5] soc: qcom: smem: Switch to EXPORT_SYMBOL_GPL() Robert Marko
2023-05-25 21:02 ` [PATCH v4 3/5] soc: qcom: smem: introduce qcom_smem_get_soc_id() Robert Marko
2023-05-25 23:18 ` Konrad Dybcio
2023-05-26 2:33 ` Bjorn Andersson
2023-05-26 8:42 ` Konrad Dybcio
2023-05-26 19:04 ` Bjorn Andersson
2023-05-25 21:02 ` [PATCH v4 4/5] cpufreq: qcom-nvmem: use SoC ID-s from bindings Robert Marko
2023-05-25 21:02 ` [PATCH v4 5/5] cpufreq: qcom-nvmem: use helper to get SMEM SoC ID Robert Marko
2023-05-25 23:18 ` Konrad Dybcio
2023-05-26 2:43 ` Bjorn Andersson
2023-05-26 8:44 ` Konrad Dybcio
2023-05-25 23:13 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f12349-1ee5-503b-3e38-e757db4331bc@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=ilia.lin@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robimarko@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).