From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from box.trvn.ru (box.trvn.ru [194.87.146.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351A63BBE1; Sat, 13 Jul 2024 10:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.87.146.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720867053; cv=none; b=dQV3IXL1dgK24L6PsRC05dnwtg9zILc9yEez/jtlOjF5/p12DKyHpyepyc4S7uX5R4kTC9tAuPvWTowtyxIQfDN+PwzlaNwkNQ9VctmgiLuL5zXrM2mLOR8zH1nT/RhEZT3PLHDeRTVXcha2KXXmAelWsm0czc/sfug+MOxztWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720867053; c=relaxed/simple; bh=GB3Q4DFxXfoq3sxgSt03EynidlVtGmPYh1l9OdtIImU=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=sNVNkCaEcT9gmETbBl78hEOwMf7Gt3xWVF0dV9NxpzZqlYgvAqrxurAy5bLOJHPBzkbnppUp0JIcZhgZ963+K6muqJ2Zr9eQ6bC/ESUfpVv8FQZBnsUDPsB5kc3eDn0dNkc5GWQ5ekS+idj0SVUPU4PkL3N/QI1yF8vKlLpOLcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=trvn.ru; spf=pass smtp.mailfrom=trvn.ru; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b=HxCYvSrH; arc=none smtp.client-ip=194.87.146.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=trvn.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trvn.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b="HxCYvSrH" Received: from authenticated-user (box.trvn.ru [194.87.146.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.trvn.ru (Postfix) with ESMTPSA id 62EAC426B9; Sat, 13 Jul 2024 15:37:26 +0500 (+05) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail; t=1720867047; bh=GB3Q4DFxXfoq3sxgSt03EynidlVtGmPYh1l9OdtIImU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HxCYvSrHZ2k5zXzt/VKysDCL3Oqv/vZgRekTtGO3BGy4EUU1bYt2DEra1EjkKM9mS /0b1nGMwNOSxpxrGGFboOkITLue1katrnFRdpIye4d0/WRxKBVToCiNtMJ/DvVhA47 MZgNGA83WqT1gzjXZ/wUagG503DaXm3N5pBAirS5u/hSacBKqk7Anvv2rAK9PbbhFa nkQUaKGNN1X0f/DxRLTHyvWlxe+/fGCmETbUYdqqE22LNdajIVlKS9xwPeAoxeDo9E HiXhau1hu/HPrla+c8bk1EB/WF0iVQ93kT3NCL1AMM3XZnD8BPwdLYFfzti/OpK2AR DSIBXjSV5y/nQ== Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 13 Jul 2024 15:37:25 +0500 From: Nikita Travkin To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?UTF-8?Q?Adam_S=C5=82abo=C5=84?= Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8939-wingtech-wt82918: Add Lenovo Vibe K5 devices In-Reply-To: References: <20240712-msm89xx-wingtech-init-v1-0-64f4aa1870bd@trvn.ru> <20240712-msm89xx-wingtech-init-v1-3-64f4aa1870bd@trvn.ru> Message-ID: <28e2dc758c8867693a183d758a9dad6a@trvn.ru> X-Sender: nikita@trvn.ru Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Krzysztof Kozlowski писал(а) 13.07.2024 15:02: > On 12/07/2024 18:04, Nikita Travkin wrote: >> From: Adam Słaboń >> >> This commit introduces multiple hardware variants of Lenovo Vibe K5. >> >> - A6020a40 (msm8929-wingtech-wt82918hd) >> - A6020a46/A6020l36 (msm8939-wingtech-wt82918) >> - A6020a40 S616 H39 (msm8939-wingtech-wt82918hd) >> >> These devices are added with support for many features, notably: >> >> - Basic features like USB, mmc/sd storage, wifi, buttons, leds; >> - Accelerometer; >> - Touchscreen; >> - Sound and modem. >> >> Note that "HD" variant of K5 is based on msm8929 which is a lower bin >> of msm8939 SoC. A simple dtsi is added for this soc along with the new >> devices. >> >> Unfortunately, despite the heavy similarities, the combination of minor >> differences between variants make them incompatible between each other. >> >> Signed-off-by: Adam Słaboń >> [Nikita: Minor cleanup, commit message] >> Signed-off-by: Nikita Travkin >> --- >> arch/arm64/boot/dts/qcom/Makefile | 3 + >> .../boot/dts/qcom/msm8929-wingtech-wt82918hd.dts | 17 ++ >> arch/arm64/boot/dts/qcom/msm8929.dtsi | 5 + >> .../boot/dts/qcom/msm8939-wingtech-wt82918.dts | 16 ++ >> .../boot/dts/qcom/msm8939-wingtech-wt82918.dtsi | 254 +++++++++++++++++++++ >> .../boot/dts/qcom/msm8939-wingtech-wt82918hd.dts | 16 ++ >> 6 files changed, 311 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index fd4c7c41ddc4..48ec781fa1d8 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -58,10 +58,13 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86518.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86528.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += msm8929-wingtech-wt82918hd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += msm8939-wingtech-wt82918.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += msm8939-wingtech-wt82918hd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb >> diff --git a/arch/arm64/boot/dts/qcom/msm8929-wingtech-wt82918hd.dts b/arch/arm64/boot/dts/qcom/msm8929-wingtech-wt82918hd.dts >> new file mode 100644 >> index 000000000000..f9a358e852f8 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/msm8929-wingtech-wt82918hd.dts >> @@ -0,0 +1,17 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> + >> +/dts-v1/; >> + >> +#include "msm8939-wingtech-wt82918.dtsi" >> +#include "msm8929.dtsi" >> + >> +/ { >> + model = "Lenovo Vibe K5 (HD) (Wingtech WT82918)"; >> + compatible = "wingtech,wt82918hd", "qcom,msm8929"; >> + chassis-type = "handset"; >> +}; >> + >> +&touchscreen { >> + touchscreen-size-x = <720>; >> + touchscreen-size-y = <1280>; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/msm8929.dtsi b/arch/arm64/boot/dts/qcom/msm8929.dtsi >> new file mode 100644 >> index 000000000000..c3d1d1ace2f6 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/msm8929.dtsi >> @@ -0,0 +1,5 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> + >> +&opp_table { >> + /delete-node/ opp-550000000; >> +}; > > That's a very odd SoC DTSI. > > SoCs DTSIs are not meant to be included as complementary, but rather as > full DTSI. > > IOW, this is very confusing code and will confuse everyone reading it. > I think Adam wanted to keep the common device dtsi based on msm8939.dtsi to simplify things a bit. I was also a bit unsure if I should change how it's done but decided to keep it as it was. I will rework the v2 so: - msm8929.dtsi includes msm8939.dtsi - devices .dts include needed soc.dtsi, then include the common.dtsi - common.dtsi doesn't include any soc.dtsi Thanks for the review! Nikita > > Best regards, > Krzysztof