From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6064C07E99 for ; Fri, 9 Jul 2021 23:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B59C861355 for ; Fri, 9 Jul 2021 23:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbhGIXtV (ORCPT ); Fri, 9 Jul 2021 19:49:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbhGIXtU (ORCPT ); Fri, 9 Jul 2021 19:49:20 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76AFEC0613DD for ; Fri, 9 Jul 2021 16:46:36 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id c28so25983045lfp.11 for ; Fri, 09 Jul 2021 16:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GR17m4TCo1bxAJbxwHuYhDUZxpveBueDWH1Tshnwhcw=; b=hmPlfythTE2CxjcaXjAVAWgrW2Gi2aikI45PIV7gfoj4G7M6oAEMPoirHnWK1fF1iE 0rfo4/3xZQIb9+cs+6ntmClUn1ek8wkuiQvWcbmvMXOnVJQkWWPFYX5P76tR6llo7yq2 R5YGjcVaF2tRv4h1oplG/+1/gGUhQ7atnCgKSIkpWsUigEGdImiRELOxKp3mWXcA+CTx 3/ENzIMdnPfl+QViXdMA2oDoe0noNm1w1KMTN2g3X9NqdUmwTUmoBe06wME9672G7aQ8 8oPCZxiqzPIXLR9lc334HvcNUET2CkZX0ymL8cC8ajAqq98TQBtrnJYTrOMYgecX1J4u JVLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GR17m4TCo1bxAJbxwHuYhDUZxpveBueDWH1Tshnwhcw=; b=Me3qhi3/UZCyqH01kFkzeWuay/YA3ZKeCJXr3LH3S+XukUgjOEUvnVW4rRjY8nrr+3 e7NlAnHCcV+BW8RwWsBW8OfZQh3xiB2WXRe2ioGGK9z8MTwU+ol8bUA4vcPyFRg90ZNQ 9rWO+Oko897AyyJOJfUAchTIg97h1vWy5FoEHtpLfFATsWunuLafPXHcxoG4/B2Zbjzs 8PiVM+drpB9CPZYQ6sr3GQh2ocqFIKiK+uZ+E+M1qeLDEzd8x3c4UbcVIeTLTdAD2uBi XjwxaZxpi1GCvrp5KrgwgkYpGrDQ4JcN4tHx5i4x22YFgI6Iui6fHeVZRov0DU7lQoEP dM8w== X-Gm-Message-State: AOAM530ow5pCYb0P3WeE7LZbHF65YUWdQS3zD1kZXWc/zhIsXs/NN8kw /NDM1ynloiBq3ocKyux4SQs+IVCRTfTH9w== X-Google-Smtp-Source: ABdhPJwLXKpJ5yziTMVpeRJ+aJVWJpnPi6aLSogHhO7o4SSJprFYE+zfyjZMegAk5EL+0c93bLJgqA== X-Received: by 2002:ac2:598b:: with SMTP id w11mr31398334lfn.534.1625874394692; Fri, 09 Jul 2021 16:46:34 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id 189sm748273ljf.117.2021.07.09.16.46.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 16:46:34 -0700 (PDT) Subject: Re: [Freedreno] [PATCH v1 5/7] drm/msm/dp: stop calling set_encoder_mode callback To: abhinavk@codeaurora.org Cc: Bjorn Andersson , Rob Clark , Sean Paul , Jonathan Marek , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , freedreno@lists.freedesktop.org References: <20210708122833.363451-1-dmitry.baryshkov@linaro.org> <20210708122833.363451-6-dmitry.baryshkov@linaro.org> <16be30732d3c2108f7a3ca640ed8285d@codeaurora.org> From: Dmitry Baryshkov Message-ID: <2920aa33-c5cf-717f-4e6e-dfd473a87820@linaro.org> Date: Sat, 10 Jul 2021 02:46:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <16be30732d3c2108f7a3ca640ed8285d@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/07/2021 01:16, abhinavk@codeaurora.org wrote: > On 2021-07-08 05:28, Dmitry Baryshkov wrote: >> None of the display drivers now implement set_encoder_mode callback. >> Stop calling it from the modeset init code. >> >> Signed-off-by: Dmitry Baryshkov > > The change looks fine, > Reviewed-by: Abhinav Kumar > > But has DP been re-verified with this change by Bjorn? > If not, I can verify this on my board and give my Tested-by Please test it on your setup. > >> --- >>  drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------ >>  1 file changed, 18 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c >> b/drivers/gpu/drm/msm/dp/dp_display.c >> index 051c1be1de7e..70b319a8fe83 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -102,8 +102,6 @@ struct dp_display_private { >>      struct dp_display_mode dp_mode; >>      struct msm_dp dp_display; >> >> -    bool encoder_mode_set; >> - >>      /* wait for audio signaling */ >>      struct completion audio_comp; >> >> @@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct >> msm_dp *dp_display) >>  } >> >> >> -static void dp_display_set_encoder_mode(struct dp_display_private *dp) >> -{ >> -    struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private; >> -    struct msm_kms *kms = priv->kms; >> - >> -    if (!dp->encoder_mode_set && dp->dp_display.encoder && >> -                kms->funcs->set_encoder_mode) { >> -        kms->funcs->set_encoder_mode(kms, >> -                dp->dp_display.encoder, false); >> - >> -        dp->encoder_mode_set = true; >> -    } >> -} >> - >>  static int dp_display_send_hpd_notification(struct dp_display_private >> *dp, >>                          bool hpd) >>  { >> @@ -369,8 +353,6 @@ static void dp_display_host_init(struct >> dp_display_private *dp, int reset) >>      if (dp->usbpd->orientation == ORIENTATION_CC2) >>          flip = true; >> >> -    dp_display_set_encoder_mode(dp); >> - >>      dp_power_init(dp->power, flip); >>      dp_ctrl_host_init(dp->ctrl, flip, reset); >>      dp_aux_init(dp->aux); -- With best wishes Dmitry