From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 4/8] usb: phy: move TCSR driver into new file Date: Fri, 20 May 2016 16:15:27 +0200 Message-ID: <2923003.R6AlEiEkj2@wuerfel> References: <1463606653-325131-1-git-send-email-arnd@arndb.de> <5468592.H0dRIBAxrx@wuerfel> <20160520124414.GK8206@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.17.13]:55009 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcETOPw (ORCPT ); Fri, 20 May 2016 10:15:52 -0400 In-Reply-To: <20160520124414.GK8206@sirena.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Brown Cc: Andy Gross , Felipe Balbi , David Brown , Peter Chen , Greg Kroah-Hartman , Alan Stern , Bjorn Andersson , Linux Kernel list , linux-arm-msm , linux-soc@vger.kernel.org, linux-usb@vger.kernel.org On Friday 20 May 2016 13:44:14 Mark Brown wrote: > On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote: > > On Thursday 19 May 2016 14:08:43 Andy Gross wrote: > > > > I'd rather do something like what we did for the GSBI. It needed to > > > change some phy related bits in the TCSR as well. We defined the TCSR > > > as a syscon, with binding documentation under mfd. If we add a syscon > > > entry and use it if it is present, we can deal with that pretty > > > easily. The offsets change for each soc, and this would also fix that > > > issue because we can change offset based on tcsr compat. > > > Works for me, but be aware that this will break the server chips, > > as ACPI has no support for regmap devices. > > Just to be clear there's nothing precluding the use of regmap on ACPI > devices, it's syscon it doesn't have anything for. > Yes, that's what I meant. Arnd