From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH] PCI: Add pci=safemode option Date: Wed, 30 May 2018 11:28:42 -0400 Message-ID: <2a5281cd-a0c7-1449-5b72-133660667fa6@codeaurora.org> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> <20180530145650.GA39853@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180530145650.GA39853@bhelgaas-glaptop.roam.corp.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Helgaas Cc: Christoph Hellwig , Gabriele Paoloni , "open list:DOCUMENTATION" , linux-pci@vger.kernel.org, Keith Busch , Kai-Heng Feng , Ingo Molnar , Christoffer Dall , Jonathan Corbet , timur@codeaurora.org, "Rafael J. Wysocki" , Dongdong Liu , David Rientjes , Thymo van Beers , "Paul E. McKenney" , Frederick Lawler , Konrad Rzeszutek Wilk , Marc Zyngier , linux-arm-msm@vger.kernel.orgFrederic List-Id: linux-arm-msm@vger.kernel.org On 5/30/2018 10:56 AM, Bjorn Helgaas wrote: > This *was* my idea, but I'm starting to think it was a bad idea. > > I don't want people to use pci= parameters as the normal way to get a > system to boot. That would be a huge support hassle (putting things > in release notes, diagnosing problems when people forget it, etc). > > But the parameters *are* useful for debugging. If we had a > "pci=safemode" and it avoided some problem, the next step would be to > narrow it down by using the more specific flags (pci=nomsi, pci=noari, > pci=no_ext_tags, etc). So I think 95% of the value is in the specific > flags, and a "pci=safemode" might add a little bit of value but at the > cost of a small but nagging maintenance concern and code clutter. OK. Let's try noXYZ feature. Can you enumerate the XYZ features that you want to see? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.