Re: [PATCH 57/89] i2c: qup: Convert to platform remove callback returning void

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 8.05.2023 22:52, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/i2c/busses/i2c-qup.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 2e153f2f71b6..6eef1dbd00de 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -1904,7 +1904,7 @@ static int qup_i2c_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int qup_i2c_remove(struct platform_device *pdev)
> +static void qup_i2c_remove(struct platform_device *pdev)
>  {
>  	struct qup_i2c_dev *qup = platform_get_drvdata(pdev);
>  
> @@ -1918,7 +1918,6 @@ static int qup_i2c_remove(struct platform_device *pdev)
>  	i2c_del_adapter(&qup->adap);
>  	pm_runtime_disable(qup->dev);
>  	pm_runtime_set_suspended(qup->dev);
> -	return 0;
>  }
>  
>  #ifdef CONFIG_PM
> @@ -1978,7 +1977,7 @@ MODULE_DEVICE_TABLE(of, qup_i2c_dt_match);
>  
>  static struct platform_driver qup_i2c_driver = {
>  	.probe  = qup_i2c_probe,
> -	.remove = qup_i2c_remove,
> +	.remove_new = qup_i2c_remove,
>  	.driver = {
>  		.name = "i2c_qup",
>  		.pm = &qup_i2c_qup_pm_ops,