From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2982324336D for ; Tue, 30 Dec 2025 19:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767124259; cv=none; b=DKie7KLt/WFBLBr5F8umxhjLZCVUSuP3QCMUF9g35+LMzYuRejngc14TkzmmV9ipLDBSaY75mvaZVgszJZJBUDsI2+qqv+2emR+dalM0QKSaTWfWXsu1nBEGej6sjJjXZEi9q//fw5tOD0oWOXNvxZ/c9fvWrOPujhnHJjbQgsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767124259; c=relaxed/simple; bh=jUIrpSR+w8EoqdT33I8iK8pTs/eKtBau6TE8v8X/fPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vEpTkviNJ048bPGwDNrAzBioYYfVajv0/AK6o9P0D42Q0GjqZfwX1ZhgCPOZmmxYbqA9WsJFQ7mQJCyASwp4XimaiQADSygY7PC5PFC1ym/3Cm7hVvY2gA3ep5y3nQKVZ69T+LvMoiRcpgF/NNGFk/XYykKUpzHmoZM0wUfJAU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Iz8qsdEJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H6knnGzd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Iz8qsdEJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H6knnGzd" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU9Wo3n2551069 for ; Tue, 30 Dec 2025 19:50:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jUIrpSR+w8EoqdT33I8iK8pTs/eKtBau6TE8v8X/fPo=; b=Iz8qsdEJ5ZyFuPYa GLBvDbCdjZ38UwFH+wqkJNeZvRH8RLlHkLRXQKubIOiK/prXCIP4wzAQkqeZYW8M otWmBG5PsC+ir/X8HOxqS6R1FvG7wyRUK1WkoTLF7KiVCcxROBPsxY+3A25nB5/Y A9U1abAIAemYk+JZy0uP2lT9HmluSXxilfXCTh0FKjMReEjbG28eItDqk79vbmI0 isdoaxbeOLtWwJBkplP2P89yCC1lbBeUIxK/taBpIiR+tYE/4nFMDPBRq9XWBQLa RJer55DTui6EIAS7aDgNrh+Lerj3nSMJB9dW3WFOy2DW8jp4EkvIL/cEJDhlVfZY EoPV+A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc0skjs55-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 19:50:55 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f1aba09639so30577451cf.0 for ; Tue, 30 Dec 2025 11:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767124255; x=1767729055; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jUIrpSR+w8EoqdT33I8iK8pTs/eKtBau6TE8v8X/fPo=; b=H6knnGzdK/yI1oZB+qeSwKRwaaUnD5+5x6jvT6vMeE/hh+f4Wt3Ltyp9lkiCZEhqNY p51IRwyZZrXcIy+enuBEcNIpwyek96zjy0Jvi95RJaxnvPbBmQiyN6PcK/PMebJZuAlb MR8P4NCzPp+GLmdtMDsBo3JLKQaIDjpIHBSoSd4xrfOJP+6ns7bJReKwo4wAVAyK9oT0 oUcAxP8tbeHMuWtQ76iMFDSgOy0caDytQREczAQA1POCR+P4nhdKH0SgQPpNSgqh5ahy 43YDq9TWt7/i6/XL4klMZ9Q6r4zXB2tXL7crIcrTbv6Et/7PXTNIue93iqXCMCj+gjxo uc+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767124255; x=1767729055; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jUIrpSR+w8EoqdT33I8iK8pTs/eKtBau6TE8v8X/fPo=; b=erEQYxlMOyqz446WRHpyVTzJ8ba5369FZhqjYvmg79MlRlAT9SOJpb3V0+WKbWlhaR o/XX9nwWfka/E0cw5M0xCXqOQNcWJe911+mOnTnN5eC4jOxT29jNahImmv1bA1xPlu6X BtecTgOzGMNOl8XRRsuZrxNiM4E6giZrDx/EUkwxVLE9i99LjdJuxjxx2ErXWg04xFcB 638qKBZ3Eq+719/ZIvFK+7+WGIEdFnUdGuB7+VL0BUx4+x2vnfoRfgTFqXB93rgZT7yz /rjNZ8AQoq2psHq5IplXpQJABxQUlXFRrvpkn57eHluPmtYC2kfDtf1paTag63Xv9m5P vgsw== X-Forwarded-Encrypted: i=1; AJvYcCVmK1TunxFw+EuHfmxN5h8XqW+PGRs7kwcMP+JEDffgnJBzB7lJY4c3daVO49mgMSw4cIq+hpHj9Q7Oe+zv@vger.kernel.org X-Gm-Message-State: AOJu0Yw4TOFpYfeT7HQaJZoRKRiGfQ9hA9r7zGoLI4CzyKDw2mkxITPb co13yPP5QVxur11zO4DY9x2Y+xYNMpEce7PzYiqmWJqNY6PBZQiDlzGms8SwMXCB2qTHJrME337 IkOomo+lqZ2fAX9GvboUursSn48sAN6ESiGMwzRGhbG0Uxk84cmxuEcVp8DdKcTkUnaQl X-Gm-Gg: AY/fxX5MKcXDslb41jbPwCapB9zKeC1M+QPgt130NDg0awq0EmZzVWe7S1vBujqMlkV 0B0bPTAViFliAL/DKtLlvbIPIuTJO+mk9Gep/T3r0QwC/52+FZrNn5hie0ymmDWiJLa4wZXeiw+ O6nGm/rUqbyQkrohInu6SjmGptyHgtuT3IlfQbXRP2jjcrkFFlOB8/0NNCAlefpmnHhQoQVC+by op08XqorrIDRX/EZehEfwrlSD6rsdHrRsY8EBD3rAd+w/RLBiKVLuYopBLfv2MDMkwBTWxVI4ul mwKB+Au82lyr6LYINJLgnUaTPh62HttIsz+OAC+dQZxWIe+01/iJMTsYj0g776CTdCkk8oDMmtS ycHMT/fkPELfNQWINa3HqEX6ivG9FI6iZPI0iAu3qxdnZ131ngQmucRKHZN95szGq2Q== X-Received: by 2002:ac8:5748:0:b0:4e8:a001:226d with SMTP id d75a77b69052e-4f4abda5f11mr405405801cf.7.1767124255240; Tue, 30 Dec 2025 11:50:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/+2BBLmMvogsvLxaz1uAXnG0dq24qwFatPrFFRiXFKRpxVhe4TqHPNsbWOT1hDWHyr76UpA== X-Received: by 2002:ac8:5748:0:b0:4e8:a001:226d with SMTP id d75a77b69052e-4f4abda5f11mr405405541cf.7.1767124254803; Tue, 30 Dec 2025 11:50:54 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f3ffbasm3791372266b.61.2025.12.30.11.50.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 11:50:54 -0800 (PST) Message-ID: <2b057aa5-4416-4fd4-aeab-6bc23acbb53d@oss.qualcomm.com> Date: Tue, 30 Dec 2025 20:50:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] remoteproc: qcom_q6v5_mss: Add MSM8917 To: barnabas.czeman@mainlining.org Cc: Stephan Gerhold , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251228-mss-v1-0-aeb36b1f7a3f@mainlining.org> <20251228-mss-v1-4-aeb36b1f7a3f@mainlining.org> <2898fde7-2b3b-471b-8f8f-a02cb6953aaf@oss.qualcomm.com> <10bc67e8-e9e9-491d-9e38-4b55735d42fe@oss.qualcomm.com> <563ce29d-0a96-42a6-9c05-51cf16244cc9@oss.qualcomm.com> <397fc3d6419d1047b5f99dc4b2d02593@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <397fc3d6419d1047b5f99dc4b2d02593@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDE3OCBTYWx0ZWRfX8NsOErU+HiqW rUXKWzarGjRqz++YnapEiUKgVHnqaHAFIvXO2JkMm9ngw4D3Giq99wNxlG0aKqd7C0zsOXggOwV dxfex9vsPhN8JxoxZWYD94PjZp8lWIsGqxSuMnrDMvUSA/1PfiZBze/eQEvbx/gtluAWdJlPiSC uyD82DbzTIHX1lEiz/A3ODBCpCV2NVlLiQxVLJQp9rmFkXJWw/q3x2ZC+0GzEiV2rqPNxcDU+27 rAaQXMzVOUh6lRr8YEdNBf9WXrmf19pt/D5Wk42C2CiCXMAlHGwCPtfamHvCyabpPcoFS0YpjL6 Z3aGeTN5g5erhosS6TZE++EViVqWPHvErYZotPK3/z375EAacQh+p8P8hmjcsAgvl33axr7H+IB DFIw9Q0G0qwoYCfN+Iy9/jkIqEWJM+SR8W+6VDYy90voe0KlXu3NJbaFf0n23Ul/a94FUSrskaa jWN4tfG6rAJm3orp+0A== X-Proofpoint-ORIG-GUID: Ut6AazVzZ3VMkAE9aS3U7WWDtm_Hw1kX X-Proofpoint-GUID: Ut6AazVzZ3VMkAE9aS3U7WWDtm_Hw1kX X-Authority-Analysis: v=2.4 cv=FJ0WBuos c=1 sm=1 tr=0 ts=69542d20 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Oh2cFVv5AAAA:8 a=qC_FGOx9AAAA:8 a=OuZLqq7tAAAA:8 a=lyBoCYSaoUlMb5i9Kl4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=7KeoIwV6GZqOttXkcoxL:22 a=fsdK_YakeE02zTmptMdW:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_03,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300178 On 12/30/25 4:28 PM, barnabas.czeman@mainlining.org wrote: > On 2025-12-30 14:11, Konrad Dybcio wrote: >> On 12/30/25 4:25 AM, barnabas.czeman@mainlining.org wrote: >>> On 2025-12-29 14:07, Konrad Dybcio wrote: >>>> On 12/29/25 1:59 PM, barnabas.czeman@mainlining.org wrote: >>>>> On 2025-12-29 13:51, barnabas.czeman@mainlining.org wrote: >>>>>> On 2025-12-29 13:40, Konrad Dybcio wrote: >>>>>>> On 12/29/25 1:33 PM, barnabas.czeman@mainlining.org wrote: >>>>>>>> On 2025-12-29 12:08, Stephan Gerhold wrote: >>>>>>>>> On Sun, Dec 28, 2025 at 03:21:54PM +0100, Barnabás Czémán wrote: >>>>>>>>>> Add support for MSM8917 MSS it is similar for MDM9607 MSS >>>>>>>>>> only difference is the mss power domain. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Barnabás Czémán >>>>>>>>>> --- >>>>>>>>>>  drivers/remoteproc/qcom_q6v5_mss.c | 46 ++++++++++++++++++++++++++++++++++++-- >>>>>>>>>>  1 file changed, 44 insertions(+), 2 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c >>>>>>>>>> index ffafbe501a05..2579558fb567 100644 >>>>>>>>>> --- a/drivers/remoteproc/qcom_q6v5_mss.c >>>>>>>>>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c >>>>>>>>>> @@ -259,6 +259,7 @@ enum { >>>>>>>>>>      MSS_MSM8226, >>>>>>>>>>      MSS_MSM8909, >>>>>>>>>>      MSS_MSM8916, >>>>>>>>>> +    MSS_MSM8917, >>>>>>>>>>      MSS_MSM8926, >>>>>>>>>>      MSS_MSM8953, >>>>>>>>>>      MSS_MSM8974, >>>>>>>>>> @@ -749,13 +750,15 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>>>>>>>>>          goto pbl_wait; >>>>>>>>>>      } else if (qproc->version == MSS_MDM9607 || >>>>>>>>>>             qproc->version == MSS_MSM8909 || >>>>>>>>>> +           qproc->version == MSS_MSM8917 || >>>>>>>>>>             qproc->version == MSS_MSM8953 || >>>>>>>>>>             qproc->version == MSS_MSM8996 || >>>>>>>>>>             qproc->version == MSS_MSM8998 || >>>>>>>>>>             qproc->version == MSS_SDM660) { >>>>>>>>>> >>>>>>>>>>          /* Override the ACC value if required */ >>>>>>>>>> -        if (qproc->version == MSS_MDM9607) >>>>>>>>>> +        if (qproc->version == MSS_MDM9607 || >>>>>>>>>> +            qproc->version == MSS_MSM8917) >>>>>>>>>>              writel(QDSP6SS_ACC_OVERRIDE_VAL_9607, >>>>>>>>>>                     qproc->reg_base + QDSP6SS_STRAP_ACC); >>>>>>>>>>          else if (qproc->version != MSS_MSM8909 && >>>>>>>>>> @@ -817,6 +820,7 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>>>>>>>>> >>>>>>>>>>              /* Turn on L1, L2, ETB and JU memories 1 at a time */ >>>>>>>>>>              if (qproc->version == MSS_MDM9607 || >>>>>>>>>> +                qproc->version == MSS_MSM8917 || >>>>>>>>>>                  qproc->version == MSS_MSM8953 || >>>>>>>>>>                  qproc->version == MSS_MSM8996) { >>>>>>>>>>                  mem_pwr_ctl = QDSP6SS_MEM_PWR_CTL; >>>>>>>>>> @@ -826,7 +830,8 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>>>>>>>>>                   * Set first 5 bits in reverse to avoid >>>>>>>>>>                   * "inrush current" issues. >>>>>>>>>>                   */ >>>>>>>>>> -                if (qproc->version == MSS_MDM9607) >>>>>>>>>> +                if (qproc->version == MSS_MDM9607 || >>>>>>>>>> +                    qproc->version == MSS_MSM8917) >>>>>>>>>>                      reverse = 6; >>>>>>>>>>              } else { >>>>>>>>>>                  /* MSS_MSM8998, MSS_SDM660 */ >>>>>>>>>> @@ -2538,6 +2543,42 @@ static const struct rproc_hexagon_res msm8916_mss = { >>>>>>>>>>      .version = MSS_MSM8916, >>>>>>>>>>  }; >>>>>>>>>> >>>>>>>>>> +static const struct rproc_hexagon_res msm8917_mss = { >>>>>>>>>> +    .hexagon_mba_image = "mba.mbn", >>>>>>>>>> +    .proxy_supply = (struct qcom_mss_reg_res[]) { >>>>>>>>>> +        { >>>>>>>>>> +            .supply = "pll", >>>>>>>>>> +            .uA = 100000, >>>>>>>>>> +        }, >>>>>>>>>> +        {} >>>>>>>>>> +    }, >>>>>>>>>> +    .proxy_clk_names = (char*[]){ >>>>>>>>>> +        "xo", >>>>>>>>>> +        NULL >>>>>>>>>> +    }, >>>>>>>>>> +    .active_clk_names = (char*[]){ >>>>>>>>>> +        "iface", >>>>>>>>>> +        "bus", >>>>>>>>>> +        "mem", >>>>>>>>>> +        NULL >>>>>>>>>> +    }, >>>>>>>>>> +    .proxy_pd_names = (char*[]) { >>>>>>>>>> +        "cx", >>>>>>>>>> +        "mx", >>>>>>>>>> +        "mss", >>>>>>>>> >>>>>>>>> Are you sure mss/pm8937_s1 also works as a power domain? It seems to be >>>>>>>>> a plain regulator downstream (similar to msm8226/msm8974). >>>>>>>>> >>>>>>>>> Same thing applies to MSM8953 as well though and there we seem to have >>>>>>>>> decided to model it as a power domain ... >>>>>>>> They have this at downstream, i guess this is why handled as a power domain. >>>>>>>> vdd_mss-uV = ; >>>>>>> >>>>>>> It seems to be just a normal regulator on both 8917 and 8953 >>>>>>> >>>>>>> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8953-regulator.dtsi >>>>>>> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8953.dtsi >>>>>>> >>>>>>> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8917-regulator.dtsi >>>>>>> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8917.dtsi >>>>>>> >>>>>>> Konrad >>>>>> It is different between 3.18 and 4.9, 3.18 seems simpler and easier to use it as regulator i will change it >>>>>> https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8917.dtsi#L1375 >>>>>> https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/blob/LA.UM.6.6.c32-05500-89xx.0/arch/arm/boot/dts/qcom/msm8917.dtsi#L1655 >>>>> Only question is left what about SDM439 and SDM632? They were introduced at 4.9 maybe that is why it was modified both are inheriting >>>>> MSS bindings from 8953 and 8937. >>>> >>>> Seems both are the same too >>> https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/sdm439-regulator.dtsi#L18 >>> https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8953-regulator.dtsi#L17 >>> SDM439 and SDM632 do not use simple regulator, s1 seems power domain to me. I have checked it in use at Fairphone 3, Redmi 7 and 7A >>> all have S1 as a power domain. >> >> Hm, it seems you're right. It does indeed use level-based voting which >> would qualify it as a power domain in our upstream understanding > What would be the better solution? > 1. Keep mss as power domain? > 2. Set mss to a regulator for MSM8917 and keep as power domain for MSM8937 and SDM439. > 3. Split SDM632 and SDM439 MSS from MSM8937 and MSM8953 MSS and use mss-supply > as regulator for MSM8917, MSM8937, MSM8940 and MSM8953 and use mss as power domain for SDM439 and SDM632. 8917 and 8937 -> regulator 439 and 632 -> power domain To match reality as we've established above Konrad