From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D6DB303A0F; Tue, 24 Feb 2026 06:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771916123; cv=none; b=YUISxHQUCjazt2Y5ai6a2yzEavh1NFNWuQdhL1hDe+QdgQzVGsE1PIfEGxpcPsrgyH82wtu3dWhkTuhydCZ+5JeYFAGG8mm4jj7s57VDz5X85aZVph+M3uCPxEHa/df5mxKz1/N2/z+sC7q1gK1jFaV4iYg4pwXtoD3ZYL+fOpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771916123; c=relaxed/simple; bh=0wvIUpF2ZOc0ZO/5YVKEHhDWD99A7MxNIFah3PCmuo0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sgE7X73fragHIUjxEIJabnw2XKl/UD8gFntDmS0A8z6L0FsZ6Dk6kb0PNRiyGB6a2jGiCrlDP3ACemYdrnzMBLv5hAQipLu94aNx5nbVcIRZBMVjk6sEfLO3C0iqhfK+sPMZlzwCVbsph9Lp2HGYsyxKZyLE8NDzW9ghD3FrjHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cV/jDDFv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cV/jDDFv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFF57C116D0; Tue, 24 Feb 2026 06:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771916122; bh=0wvIUpF2ZOc0ZO/5YVKEHhDWD99A7MxNIFah3PCmuo0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cV/jDDFvRK+sudfsVyIYODw61E06osjabRkXNsf4MiS/LbGPKJOOSR175TjOvRL9M 03WzoWLpT3mlcxACMChdhgSQmdkpDniIX8bT5gIGt9QYGDds0mUsn5S+5eZu3goFlK NGLdLJDBGW6tBlwZ9YQrabncLE+bYk4GjKi1TNHf57KHns/SzwqszL7Gf8VuuO5wQM kAPgkzzHx4PuacbRgyD8CeR0FRpYSNOR4X7Ft8Pw6TK0Xi/fQp24Q97QRnPY8aXEJa sEQukc/VVF81aIgWH/ZkhheM8FXC/BweaM/u7uO679T5RwpAAfmq3+WiW05Idth6NI OvF9GVGEVM/6w== Message-ID: <2b3dddba-f5d4-4eb5-b2b1-52df919e02f9@kernel.org> Date: Tue, 24 Feb 2026 07:55:17 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: monaco-evk: Add Interface Plus Mezzanine To: Bjorn Andersson Cc: Umang Chheda , konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, richardcochran@gmail.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mohd.anwar@oss.qualcomm.com, krishna.chundru@oss.qualcomm.com, monish.chunara@oss.qualcomm.com, Dmitry Baryshkov References: <20260222173545.3627478-1-umang.chheda@oss.qualcomm.com> <20260222173545.3627478-2-umang.chheda@oss.qualcomm.com> <87e3de23-cee9-4789-87ca-e85826af7760@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/02/2026 05:29, Bjorn Andersson wrote: >> >>> >>> The recommendation that has been communicated is to based label, name >>> and regulator-name of the schematics, but prefix the node name with >>> regulator- to achieve sensible sort order. >>> >>> >>> In fact naming these regulator-0v9, regulator-1v8, and regulator-3v3 >>> make the name useless. We further have plenty of designs where there are >>> multiple regulator-1v8 and regulator-3v3. >> >> The regulator-name is to match schematics. Node name should follow DT >> spec expectations to show the purpose of the node. >> > > And "purpose" here means "it's a regulator providing 0.9V"? The purpose is regulator, so I was in general in favor of regulator-[0-9] with the number being index. The convention/schema asks now for a more specific suffix, which still is just a suffix to differentiate multiple nodes. > >>> >>> I guess the preferred name, per the binding, is to not have multiple >>> 3.3V regulators in your design? >> >> I don't see what you are proving here. The "vreg" middle name addon is >> not differentiating multiple 3.3V regulators. >> It changes nothing in the problem of this duplication. >> > > I agree on the "vreg" part being redundant, but you're telling us that > all fixed regulators should be named "regulator-[0-9]v[0-9]". Yes, I am fine with some meaningful suffixes. > > Are you saying that "regulator-edp-3p3", "regulator-misc-3p3", and > "regulator-nvme" (examples from x1-crd.dtsi), should all be named First, I would not change existing names just to match the convention. Really not. Second, this is not the case here. I talk about patch here. The patch did not need additional suffixes but added the "vreg" useless suffix/middlefix. Third, if these are controllable regulators for a new source code, then they should follow the convention with optional suffix. Whether the suffix is numerical or name, I don't care. > "regulator-3v3"? Or is your feedback limited to those regulators that > are trivially named in the schematics? Best regards, Krzysztof