From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A3EC48BD3 for ; Wed, 26 Jun 2019 14:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF2FC2080C for ; Wed, 26 Jun 2019 14:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727945AbfFZOqT (ORCPT ); Wed, 26 Jun 2019 10:46:19 -0400 Received: from ns.iliad.fr ([212.27.33.1]:54152 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727139AbfFZOqT (ORCPT ); Wed, 26 Jun 2019 10:46:19 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id E9ADF2097A; Wed, 26 Jun 2019 16:46:16 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id D4858205C8; Wed, 26 Jun 2019 16:46:16 +0200 (CEST) Subject: Re: [PATCH v1] pinctrl: msm8998: Squash TSIF pins together To: Jeffrey Hugo Cc: Bjorn Andersson , Linus Walleij , MSM , gpio References: <18ab4b1c-e74e-410a-a504-f524e46c42ac@free.fr> <20190611180516.GO4814@minitux> <20190620184124.GB24205@tuxbook-pro> <57d0644d-164f-58e7-6c07-9608da4233a3@free.fr> From: Marc Gonzalez Message-ID: <2b531817-b1eb-da8c-9edf-25a0b9b2acda@free.fr> Date: Wed, 26 Jun 2019 16:46:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Wed Jun 26 16:46:16 2019 +0200 (CEST) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26/06/2019 16:42, Jeffrey Hugo wrote: > On Wed, Jun 26, 2019 at 8:40 AM Marc Gonzalez wrote: > >> Preamble: Rename tsif1 to tsif0, tsif2 to tsif1. >> Squash tsif0 pins into a single function. Same for tsif1. >> >> Signed-off-by: Marc Gonzalez >> --- >> .../bindings/pinctrl/qcom,msm8998-pinctrl.txt | 19 ++--- >> drivers/pinctrl/qcom/pinctrl-msm8998.c | 76 +++++-------------- >> 2 files changed, 24 insertions(+), 71 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8998-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8998-pinctrl.txt >> index 00174f08ba1d..47b0f30a39e9 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8998-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8998-pinctrl.txt >> @@ -124,9 +124,8 @@ to specify in a pin configuration subnode: >> qlink_request, qua_mi2s, sd_card, sd_write, sdc40, sdc41, >> sdc42, sdc43, sdc4_clk, sdc4_cmd, sec_mi2s, sp_cmu, >> spkr_i2s, ssbi1, ssc_irq, ter_mi2s, tgu_ch0, tgu_ch1, >> - tsense_pwm1, tsense_pwm2, tsif1_clk, tsif1_data, tsif1_en, >> - tsif1_error, tsif1_sync, tsif2_clk, tsif2_data, tsif2_en, >> - tsif2_error, tsif2_sync, uim1_clk, uim1_data, uim1_present, >> + tsense_pwm1, tsense_pwm2, tsif0, tsif1, >> + uim1_clk, uim1_data, uim1_present, >> uim1_reset, uim2_clk, uim2_data, uim2_present, uim2_reset, >> uim_batt, usb_phy, vfr_1, vsense_clkout, vsense_data0, >> vsense_data1, vsense_mode, wlan1_adc0, wlan1_adc1, >> @@ -179,15 +178,9 @@ Example: >> #interrupt-cells = <2>; >> >> uart_console_active: uart_console_active { >> - mux { >> - pins = "gpio4", "gpio5"; >> - function = "blsp_uart8_a"; >> - }; >> - >> - config { >> - pins = "gpio4", "gpio5"; >> - drive-strength = <2>; >> - bias-disable; >> - }; >> + pins = "gpio4", "gpio5"; >> + function = "blsp_uart8_a"; >> + drive-strength = <2>; >> + bias-disable; >> }; > > Whats with these "uart" changes? Modernizing the example? Doesn't > seem related to the commit text... Good point. I squashed one commit too many. I'll drop that hunk in v2. (Yes, I meant to document the syntax recommended by Bjorn.) Regards.