From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anjelique Melendez <quic_amelende@quicinc.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: konrad.dybcio@somainline.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Anirudh Ghayal <quic_aghayal@quicinc.com>
Subject: Re: [PATCH 2/4] pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping
Date: Thu, 8 Sep 2022 13:14:25 +0200 [thread overview]
Message-ID: <2b809e98-85ea-6ad9-e810-106563937ddc@linaro.org> (raw)
In-Reply-To: <20220907201528.9351-3-quic_amelende@quicinc.com>
On 07/09/2022 22:15, Anjelique Melendez wrote:
> From: Anirudh Ghayal <quic_aghayal@quicinc.com>
>
> The SPMI based PMICs have the HIGH and LOW GPIO output
> strength mappings interchanged, fix them.
>
> Keep the mapping same for older SSBI based PMICs.
>
> CRs-Fixed: 2246473
What is this tag about?
> Signed-off-by: Anirudh Ghayal <quic_aghayal@quicinc.com>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
> drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 4 ++--
> include/dt-bindings/pinctrl/qcom,pmic-gpio.h | 9 +++++++--
> 3 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index cf6b6047de8d..fceccf1ec099 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -525,7 +525,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> pad->pullup = arg;
> break;
> case PMIC_GPIO_CONF_STRENGTH:
> - if (arg > PMIC_GPIO_STRENGTH_LOW)
> + if (arg > PMIC_GPIO_STRENGTH_HIGH)
> return -EINVAL;
> pad->strength = arg;
> break;
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> index 1b41adda8129..0f96d130813b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * Copyright (c) 2015, Sony Mobile Communications AB.
> - * Copyright (c) 2013, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2013, 2018 The Linux Foundation. All rights reserved.
> */
>
> #include <linux/module.h>
> @@ -371,7 +371,7 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev,
> banks |= BIT(0);
> break;
> case PM8XXX_QCOM_DRIVE_STRENGH:
> - if (arg > PMIC_GPIO_STRENGTH_LOW) {
> + if (arg > PM8921_GPIO_STRENGTH_LOW) {
> dev_err(pctrl->dev, "invalid drive strength\n");
> return -EINVAL;
> }
> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-gpio.h b/include/dt-bindings/pinctrl/qcom,pmic-gpio.h
> index e5df5ce45a0f..950be952ad3e 100644
> --- a/include/dt-bindings/pinctrl/qcom,pmic-gpio.h
> +++ b/include/dt-bindings/pinctrl/qcom,pmic-gpio.h
You cannot mix bindings with driver. This is an ABI break.
> @@ -12,9 +12,14 @@
> #define PMIC_GPIO_PULL_UP_1P5_30 3
>
> #define PMIC_GPIO_STRENGTH_NO 0
> -#define PMIC_GPIO_STRENGTH_HIGH 1
> +#define PMIC_GPIO_STRENGTH_LOW 1
> #define PMIC_GPIO_STRENGTH_MED 2
> -#define PMIC_GPIO_STRENGTH_LOW 3
> +#define PMIC_GPIO_STRENGTH_HIGH 3
Didn't you just break all DTSes in the world?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-08 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 20:15 [PATCH 0/4] Add Support for Qualcomm SPMI GPIOs Anjelique Melendez
2022-09-07 20:15 ` [PATCH 1/4] pinctrl: qcom: spmi-gpio: add support for LV_VIN2 and MV_VIN3 subtypes Anjelique Melendez
2022-09-07 20:15 ` [PATCH 2/4] pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping Anjelique Melendez
2022-09-08 11:14 ` Krzysztof Kozlowski [this message]
2022-09-08 23:52 ` Anjelique Melendez
2022-09-09 7:35 ` Krzysztof Kozlowski
2022-09-09 0:25 ` David Collins
2022-09-09 7:34 ` Krzysztof Kozlowski
2022-09-07 20:15 ` [PATCH 3/4] pinctrl: qcom: spmi-gpio: Add compatible for PM7250B Anjelique Melendez
2022-09-08 11:14 ` Krzysztof Kozlowski
2022-09-07 20:15 ` [PATCH 4/4] dt-bindings: qcom-pmic-gpio: Add PM7250B and PM8450 bindings Anjelique Melendez
2022-09-08 11:13 ` Krzysztof Kozlowski
2022-09-08 16:55 ` Anjelique Melendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b809e98-85ea-6ad9-e810-106563937ddc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aghayal@quicinc.com \
--cc=quic_amelende@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox