Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 26/29] soc: qcom: ubwc: drop macrotile_mode from the database
Date: Fri, 8 May 2026 12:01:12 +0200	[thread overview]
Message-ID: <2c43e6e3-979a-4413-9026-e6ef28acd3a7@oss.qualcomm.com> (raw)
In-Reply-To: <20260507-ubwc-rework-v4-26-c19593d20c1d@oss.qualcomm.com>

On 5/7/26 3:03 PM, Dmitry Baryshkov wrote:
> All the users have been migrated to using qcom_ubwc_macrotile_mode()
> instead of reading the raw value from the config structure. Drop the
> field from struct qcom_ubwc_cfg_data and replace it with the calculated
> value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and
> UBWC_3_1 (with macrotile mode).
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

[...]

>  static const struct qcom_ubwc_cfg_data sc8180x_data = {
> @@ -89,7 +84,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data = {
>  	.ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 |
>  			UBWC_SWIZZLE_ENABLE_LVL3,
>  	.highest_bank_bit = 16,
> -	.macrotile_mode = true,

8180 should also be 3.1

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-05-08 10:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 13:02 [PATCH v4 00/29] soc/qcom/ubwc: rework UBWC configuration database Dmitry Baryshkov
2026-05-07 13:02 ` [PATCH v4 01/29] drm/msm/mdss: correct UBWC programming sequences Dmitry Baryshkov
2026-05-07 13:02 ` [PATCH v4 02/29] soc: qcom: ubwc: define UBWC 3.1 Dmitry Baryshkov
2026-05-07 13:02 ` [PATCH v4 03/29] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 04/29] soc: qcom: ubwc: add helper controlling AMSBC enablement Dmitry Baryshkov
2026-05-08 10:06   ` Konrad Dybcio
2026-05-07 13:03 ` [PATCH v4 05/29] drm/msm/adreno: Trust the SSoT UBWC config Dmitry Baryshkov
2026-05-07 14:04   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 06/29] drm/msm/adreno: use qcom_ubwc_version_tag() helper Dmitry Baryshkov
2026-05-07 14:05   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 07/29] drm/msm/mdss: " Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 08/29] drm/msm/adreno: use new helper to set min_acc length Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 09/29] drm/msm/mdss: " Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 10/29] drm/msm/adreno: use new helper to set macrotile_mode Dmitry Baryshkov
2026-05-07 13:59   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 11/29] drm/msm/mdss: " Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 12/29] drm/msm/mdss: use new helper to set UBWC bank spreading Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 13/29] drm/msm/adreno: use new helper to set ubwc_swizzle Dmitry Baryshkov
2026-05-07 14:09   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 14/29] drm/msm/dpu: " Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 15/29] drm/msm/mdss: " Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 16/29] drm/msm/adreno: write reserved UBWC-related bits Dmitry Baryshkov
2026-05-07 14:25   ` Akhil P Oommen
2026-05-07 14:44   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 17/29] drm/msm/adreno: set fp16compoptdis for UBWC 3.0 formats Dmitry Baryshkov
2026-05-07 14:47   ` Akhil P Oommen
2026-05-07 13:03 ` [PATCH v4 18/29] drm/msm/adreno: use new helper to set amsbc Dmitry Baryshkov
2026-05-07 14:48   ` Akhil P Oommen
2026-05-08 10:02   ` Konrad Dybcio
2026-05-07 13:03 ` [PATCH v4 19/29] drm/msm/adreno: use version ranges in A8xx UBWC code Dmitry Baryshkov
2026-05-07 14:57   ` Akhil P Oommen
2026-05-08 10:06   ` Konrad Dybcio
2026-05-07 13:03 ` [PATCH v4 20/29] drm/msm/mdss: use new helper to set amsbc Dmitry Baryshkov
2026-05-08  9:59   ` Konrad Dybcio
2026-05-07 13:03 ` [PATCH v4 21/29] drm/msm/dpu: drop ubwc_dec_version Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 22/29] drm/msm/dpu: invert the order of UBWC checks Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 23/29] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 24/29] soc: qcom: ubwc: drop ubwc_dec_version Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 25/29] soc: qcom: ubwc: drop ubwc_bank_spread Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 26/29] soc: qcom: ubwc: drop macrotile_mode from the database Dmitry Baryshkov
2026-05-08 10:01   ` Konrad Dybcio [this message]
2026-05-08 11:25     ` Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 27/29] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 28/29] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Dmitry Baryshkov
2026-05-07 13:03 ` [PATCH v4 29/29] soc: qcom: ubwc: deduplicate UBWC configuration data Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c43e6e3-979a-4413-9026-e6ef28acd3a7@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox