From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [Intel-wired-lan] [PATCH v3 09/18] fm10k: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:33:14 -0400 Message-ID: <2d346b70-70d4-5996-24ce-94031ee68c90@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> <1521216991-28706-10-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexander Duyck Cc: Netdev , Timur Tabi , sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, LKML , intel-wired-lan , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On 3/16/2018 12:30 PM, Alexander Duyck wrote: > On Fri, Mar 16, 2018 at 9:16 AM, Sinan Kaya wrote: >> Code includes wmb() followed by writel(). writel() already has a >> barrier on some architectures like arm64. >> >> This ends up CPU observing two barriers back to back before executing >> the register write. >> >> Since code already has an explicit barrier call, changing writel() to >> writel_relaxed(). >> >> Signed-off-by: Sinan Kaya > > You can update the writel call in fm10k_tx_map as well. > > Of the drivers updated in drivers/net/ethernet/intel/* it looks like > this is the only one that still requires any additional changes. will do. thanks for the feedback. > > Thanks. > > - Alex > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.