From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1358714AD19 for ; Wed, 17 Jul 2024 10:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721212987; cv=none; b=Q0gI5B/qaZQcZ9R4rM67um0r/O/JiVro4NHRc/9wYjxzOfRu55HA4hwfBuL/rwwdbptKUnBR9RIm81VNqxNIdzPTSEQIOP34ObPTlJu7XZ54nNZthmF3ebfihGP47woMxhjrbCOyQceJIOypWQ/dmA2PUzInET76rX2/ugyNSHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721212987; c=relaxed/simple; bh=jDYIVpkI2wrskYjogiULwXKO7ktZv1aJ7DZ3Nb1BvBc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s6JHWrdkH5iBEQne2Oe5WllXIkHafwOyJ3OqeYq2tmFVWcEjCAepKxmJLEPvaLB8V/0Ju57iLEtY4v4LHDm/mxBSVViwIIOiskv+GNZKoDRFYIOoL88Q2cZB2LNJ0FL4vz7GCvBAyjEU0iSsUAQBi9PyjT1p3glUI1IIRuxFPGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=T16oisUv; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T16oisUv" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-58ba3e38028so8208327a12.0 for ; Wed, 17 Jul 2024 03:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721212984; x=1721817784; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jDYIVpkI2wrskYjogiULwXKO7ktZv1aJ7DZ3Nb1BvBc=; b=T16oisUvxmtCSzkNI7xBOX0/YgRwBRxzjro5YbOIduudpSw7joiQQK5ve4r9rm+H+k rNCFDnhBwBnS9YRhh4Hlnc0uvvzlHh+mJwSNohs1hnooYWoTk7+5oGgDqLCYI1zZVAVU FzNR7UT6FCU1b9ArL2gIaj1vuYhL5P+cniBnpJ7FlXzu36h/O7A98a2spIpUR7D6CrGW hb4AC7l7WaiEa5ZKesmmoagqBVXNMe6TznlOhPIqowiH93uKfzK4IVH4uNYaYQMNrVbi JXJk3sfvZRrBPJeJvEtHDZ75MtB0+mf4InRhtXZKY+JR855ZByzbgknqhS2CjqW//gJv meqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721212984; x=1721817784; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jDYIVpkI2wrskYjogiULwXKO7ktZv1aJ7DZ3Nb1BvBc=; b=vYL14If9wXxa19cpH1Ygdc68fUu9JnMoHpyoLAS43jlq5Z5rNcVn/fTyoFVdbiEUpj cEq1GfIbIOlsumPINYEF52wVYg/VZ3PK5IJOCDlBHOLtAvDLrcLjtpaiaAUlPgAHmCqX oC8nYJcgC/p5LJWhu+C4l3pzDyLUSE9AtHbOqzMh/x4eFFqlUIO0Zeva2B9pyGczCCLZ nYX7d9uDEdroqOuJ0TkGz+zYIRuIyKy5VqilQgMBtVHXivxwr48D+qFckzM6Dl//1cLO VIjarzV0VruEjKwd3iaTa1JpOz2vvMgnG5rL/bPfMn3rpfWjSF/pRJs8OWC3o0duhH21 MWLA== X-Forwarded-Encrypted: i=1; AJvYcCXifA+czlowHrg7GYlWWZ37Sjtnjtlu9IN/v0jN0A3moFQTqVu4iZDOU63JiS/FmND2M4ltjTu6shPqYaUUgUvLnybZ/TINaxRGWO9ogA== X-Gm-Message-State: AOJu0Yye8EU1XYFy/nt1cSogcDljSFQJHNckaz33GgJQPmp/wDNi5//Z Ps1iLJSKcIaNI7QOV1Wt3ZRsrwSI9R0rnQQeQy0a/5XqcrUTJ6JtVdUh9vy+wko= X-Google-Smtp-Source: AGHT+IFACSw0wcYk59/gj6GZBVlzplPmhNUj87R9Hfdq8QZPBr1o+WVmHKWfiYT/gpdP86UdBlCbXQ== X-Received: by 2002:a17:906:2b4a:b0:a75:25ff:550d with SMTP id a640c23a62f3a-a7a011557b2mr86405166b.26.1721212984397; Wed, 17 Jul 2024 03:43:04 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc7f27cesm429797366b.124.2024.07.17.03.43.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 03:43:03 -0700 (PDT) Message-ID: <2d8ac288-da60-490a-a6ac-ebe524e3fc21@linaro.org> Date: Wed, 17 Jul 2024 11:43:02 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] media: qcom: camss: Remove use_count guard in stop_streaming To: Johan Hovold Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Hans Verkuil , Hans Verkuil , Milen Mitkov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Johan Hovold , stable@vger.kernel.org References: <20240716-linux-next-24-07-13-camss-fixes-v2-0-e60c9f6742f2@linaro.org> <20240716-linux-next-24-07-13-camss-fixes-v2-1-e60c9f6742f2@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/07/2024 10:06, Johan Hovold wrote: >> The use of use_count like this is a bit hacky and right now breaks regular >> usage of CAMSS for a single stream case. As an example the "qcam" >> application in libcamera will fail with an -EBUSY result on stream stop and >> cannot then subsequently be restarted. > No, stopping qcam results in the splat below, and then it cannot be > started again and any attempts to do so fails with -EBUSY. I thought that's what I said. Let me reword the commit log with your sentence included directly :) --- bod