From: Taniya Das <quic_tdas@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Will Deacon <will@kernel.org>,
"Ajit Pandey" <quic_ajipan@quicinc.com>,
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Imran Shaik <quic_imrashai@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v4 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller
Date: Mon, 20 Jan 2025 16:35:00 +0530 [thread overview]
Message-ID: <2e4a4305-526b-4faa-9e56-3f2f11bc7365@quicinc.com> (raw)
In-Reply-To: <czxiikfvffnfljngec6gdwoapx2khtvltauzhezexkxxitclfn@7pfnj7jtyfil>
On 1/20/2025 2:22 PM, Dmitry Baryshkov wrote:
> On Mon, Jan 20, 2025 at 10:10:11AM +0530, Taniya Das wrote:
>>
>>
>> On 1/19/2025 5:23 PM, Rob Herring (Arm) wrote:
>>> y bot found errors running 'make dt_binding_check' on your patch:
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Documentation/devicetree/bindings/clock/qcom,qcs615-dispcc.example.dts:19:18: fatal error: dt-bindings/clock/qcom,qcs615-gcc.h: No such file or directory
>>> 19 | #include <dt-bindings/clock/qcom,qcs615-gcc.h>
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/qcom,qcs615-dispcc.example.dtb] Error 1
>>> make[2]: *** Waiting for unfinished jobs....
>>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
>>> make: *** [Makefile:251: __sub-make] Error 2
>>
>> The code https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/dt-bindings/clock/qcom,qcs615-gcc.h
>>
>> The cover letter also has the series mentioned.
>
> Please. Stop using bindings for clock controllers in DT bindings for
> other devices. It provides no benefits and complicates merging.
>
Sure, I agree we should not refer the bindings, but I hope this is
agreed upon and I could remove such references in upcoming bindings.
--
Thanks & Regards,
Taniya Das.
next prev parent reply other threads:[~2025-01-20 11:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 10:22 [PATCH v4 00/10] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform Taniya Das
2025-01-19 10:22 ` [PATCH v4 01/10] clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs Taniya Das
2025-01-19 10:22 ` [PATCH v4 02/10] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller Taniya Das
2025-01-19 10:22 ` [PATCH v4 03/10] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver Taniya Das
2025-01-19 10:22 ` [PATCH v4 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller Taniya Das
2025-01-19 11:53 ` Rob Herring (Arm)
2025-01-20 4:40 ` Taniya Das
2025-01-20 7:17 ` Krzysztof Kozlowski
2025-01-20 8:52 ` Dmitry Baryshkov
2025-01-20 11:05 ` Taniya Das [this message]
2025-01-19 10:22 ` [PATCH v4 05/10] clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver Taniya Das
2025-01-19 10:23 ` [PATCH v4 06/10] dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller Taniya Das
2025-01-19 11:53 ` Rob Herring (Arm)
2025-01-19 10:23 ` [PATCH v4 07/10] clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver Taniya Das
2025-01-20 11:57 ` kernel test robot
2025-01-24 3:48 ` kernel test robot
2025-01-19 10:23 ` [PATCH v4 08/10] dt-bindings: clock: Add Qualcomm QCS615 Video clock controller Taniya Das
2025-01-19 11:53 ` Rob Herring (Arm)
2025-01-19 10:23 ` [PATCH v4 09/10] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver Taniya Das
2025-01-20 14:05 ` kernel test robot
2025-01-19 10:23 ` [PATCH v4 10/10] arm64: defconfig: Enable QCS615 clock controllers Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e4a4305-526b-4faa-9e56-3f2f11bc7365@quicinc.com \
--to=quic_tdas@quicinc.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox