From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139BD27A907 for ; Mon, 6 Oct 2025 12:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759754486; cv=none; b=joJ7oeE3WofMYtxIYzji1vb0vVT1rLdCFDbuKRnBdXpphh2b4FVwfdwVjBs4JkazwmtP+RWShB+DwB+dsoD37vj9Ik48jOECCYiz66bSrCnZBEcLryZmZGrc1Qi+BhwDBZM3P6LxcOClZ8V2sNTZ+YTXDIOLlcr4et1Lsa6tnGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759754486; c=relaxed/simple; bh=0mkWvVdXxn2wUvjtU5oKLtZo4yzstBLNeZ/HFxFhqgM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gZUeUYl79FjZYVIYXwUSe7F+1eCxKmelcBakHDYtZE98BNdVifypj6/6+7jMFEDC18ZG+roix5caIG3bTUKDq+TJ4kxTIAzM+clphKSj/pc62BO+F/lgKopruouI/JqjF7rzpSXKC59QfI5hRImDiDGijieGffYCPZ89P3IPtSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T7ioULsY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T7ioULsY" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5961TvFd017137 for ; Mon, 6 Oct 2025 12:41:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ylaB+oXrxe0+pgv6AwGh4kUHExSYxwOnq/WJa7AKAso=; b=T7ioULsYmZpcoJwl bC8S+pVrCYbMmhaPV6dFUQHJtctpi/LoYkP91rjmwV3BvKpciKUHkQubKkgV2ZmI 8xQ3eWdI/uWlFja2MoprBXPKeC/TEywClVGLCw1eLKKa/JvkaENcBWTaTeDG4Lkq 6uUIC/6LM2CWPdD7FbKkpYfUF5nbTmfq1W1e8NCXP4iybW5MuBHG7HAZN2whhD/D HbS1zNUTxUDReRQQ57CEkvlpNEJ7YlDp0V2N2FxCwt/8La4/VNMyB0mWT/IiU+VE RfBnfuMAWLb5z3cK4+WRNA6XPUqRKoWzTFgK5ri6TtV+X+LDcm3szTJlTteA17mn gvUP3w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49jtk6uwpb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 06 Oct 2025 12:41:23 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4dd3c89ad67so3804061cf.1 for ; Mon, 06 Oct 2025 05:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759754483; x=1760359283; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ylaB+oXrxe0+pgv6AwGh4kUHExSYxwOnq/WJa7AKAso=; b=m2Eh12gTRZpQw3ojlVinR/Cj+8xkDPcR3XfzFH/3EoR/YXTu6wcDlNTbUdeIwMpRsr gVfZ4td0/6RjuPhyqoaiAX4Nm1crdZ31UKnCgrM4Mk6nq+ElHCpOnv2ycig1Zz03zaWw wFJKaiBYa6eWMV6pf2ly5J3GU26jawRWxdG6HjZny/PNSae0vRvSSXds/fzXD2wGZOsj TztnkRkpRuoE2gA1ejFN2UO4MGxE3PmI+wk4BhL43iJ+JVNox3d1v4zywJEYIBqyALT3 4vAvO0Cq2UXvc7+CLIUQK12LkKfpvcoQaSChzww94NPoz8/FlVyfQKDLvnlLynlw50p6 l/Pw== X-Gm-Message-State: AOJu0Yza7GS4WVHxRZhex5G5Pm+OzRHv5d3JtntVUZOziC9fXMIlED/6 cMbEK7amOgsQd7NW0W4u1Kpmmevva0J34scF65UNZFrZ01XRq93UyhJXGzxQvVH4e0TIA6zdZrh MdxYlnjzRnownlnEKzTtdhuz8/fZiOyZxr6E7eBmubpfUy6+tTww+55fX5dhFdUWGjG08 X-Gm-Gg: ASbGnctzzhk7D5nXs9ecQaClHcWGHbBfhrM/PPmtDMtATx+9PU4CLJRhs41PJg8EsTZ nP7VTMS5mXGxpIoSUmpFQ0ZokYPx3PMpjQeN7ezmmqm7I6KK86C12fN16mTs+Lm35suwBuDrayq nvVcNvknrqkJKDS6NNa4Uvq07VSNtpYVkhTm8w/YBDJJs6+vlOGUR9UJOYCdKuCjSLrPHzDyDTf cPJNGeI4hHDfGBYv1uSz9DJdaGloZK6VdOthR29Op/U3e1NQRtFMKZpXW9aLV8tsofunYEcba/Q WRB9N/Kq2SqCXrPlN/q375p3CpSFT4S4cMglNDoQpTQY3vqp2FsdlzUs8n9iaOgy2RD+D99QoWb Ovx7pijI7RHMv4GJz9cZ3ar1ijgk= X-Received: by 2002:ac8:5f91:0:b0:4b7:aa56:c0f8 with SMTP id d75a77b69052e-4e576a4b14emr99167211cf.4.1759754482405; Mon, 06 Oct 2025 05:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWf8WDHwf7+GFY86q3ArprOZHi6q5sn356YIXo0h3Tx0U51KUsNyxrt2pDL2G4L8m5exlggA== X-Received: by 2002:ac8:5f91:0:b0:4b7:aa56:c0f8 with SMTP id d75a77b69052e-4e576a4b14emr99166921cf.4.1759754481760; Mon, 06 Oct 2025 05:41:21 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63788111f1fsm10279311a12.36.2025.10.06.05.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 05:41:21 -0700 (PDT) Message-ID: <2e4b995e-57ae-412f-ae88-c3708a5f67ee@oss.qualcomm.com> Date: Mon, 6 Oct 2025 14:41:18 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL To: david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Pundir , Casey Connolly , Joel Selvaraj , Sumit Semwal , Vinod Koul References: <20251005-pixel-3-v1-0-ab8b85f6133f@ixit.cz> <20251005-pixel-3-v1-2-ab8b85f6133f@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251005-pixel-3-v1-2-ab8b85f6133f@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAxNyBTYWx0ZWRfX3ipBIgacmiFa P7eBP/etg6KiBl4HCEhq8arby1NX06gCQ1v9QPxnZqtmFOl+nXsIi1INE/xKQIJYsanganLNmGW u+0smjwZGjKj4c9c7MeFzJYQYtXlU0E2Ea7NG4YaHijorC2RJedy80zoRlE5XWeoqs1mCc3/M87 pALRyFJxjY20vxlJlbKf3R68LJzZspoX8vX95EnUtMSQ2rz2Ljfsddfg8zZTSN4wDY3uP0ZqBdz 9o5CWLnjvtx4jBhN8yur1v5jlTlhoObMyMnAlALqL+U023XHWNzBYmShJLDJHtvbuUWjbnZzXy9 fYuLgE1z9J1nFZ/QWxQz4m0k3FwFz6nNy/UQdjy+6kbuOlf0/nkRMjZ6+JlEPKzleQRlPbSa+RO cdppLkhvXQOBEfgjxE+/pplMnQ1pkQ== X-Authority-Analysis: v=2.4 cv=do3Wylg4 c=1 sm=1 tr=0 ts=68e3b8f3 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=ev71qlw1QQQPEuQK8qEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: LIs4Xo9a_x0Uqz4mrYrKswsPGfb8-OU- X-Proofpoint-ORIG-GUID: LIs4Xo9a_x0Uqz4mrYrKswsPGfb8-OU- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-06_04,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040017 On 10/5/25 3:16 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > This adds initial device tree support for the following phones: > > - Google Pixel 3 (blueline) > - Google Pixel 3 XL (crosshatch) > > Both phone boards use the same identifiers and differ only slightly > in their connected peripherals. > > Supported functionality includes: > - Debug UART > - UFS > - Charger > - USB-C (peripheral mode) > - Display (Pixel 3 only) > > GPIOs 0–3 and 81–84 are not accessible from the application CPUs, > so they are marked as reserved to allow the Pixel 3 to boot. > > The rmtfs region is allocated using UIO, making it technically "dynamic." > > Its address and size can be read from sysfs: > > $ cat /sys/class/uio/uio0/name > /sys/class/uio/uio0/maps/map0/addr > 0x00000000f2701000 > > $ cat /sys/class/uio/uio0/maps/map0/size > 0x0000000000200000 > > Like the OnePlus 6, the Pixel 3 requires 1 kB of reserved memory on either > side of the rmtfs region to work around an XPU bug that would otherwise > cause erroneous violations when accessing the rmtfs_mem region. [...] > +&gmu { > + status = "okay"; > +}; It's already enabled> + > +&mdss { > + status = "okay"; > +}; > + > +&mdss_dsi0 { > + status = "okay"; > + vdda-supply = <&vdda_mipi_dsi0_1p2>; 'status' should be last, with a \n before it > + > + ports { > + port@1 { > + endpoint { &mdss_dsi0_out {} instead > + remote-endpoint = <&panel_in>; > + data-lanes = <0 1 2 3>; > + qcom,te-source = "mdp_vsync_e"; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "lg,sw43408"; > + reg = <0>; > + > + vddi-supply = <&vreg_l14a_1p88>; > + vpnl-supply = <&vreg_l28a_3p0>; > + > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&panel_reset_pins &panel_te_pin &panel_pmgpio_pins>; property-n property-names in this order, please > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; > + > +&mdss_dsi0_out { > + remote-endpoint = <&panel_in>; > + data-lanes = <0 1 2 3>; > +}; (as mentioned above..) [...] > + /* rmtfs lower guard */ > + memory@f2700000 { > + reg = <0 0xf2700000 0 0x1000>; > + no-map; > + }; > + > + rmtfs_mem: memory@f2701000 { > + compatible = "qcom,rmtfs-mem"; > + reg = <0 0xf2701000 0 0x200000>; > + no-map; > + > + qcom,client-id = <1>; > + qcom,vmid = <15>; > + }; > + > + /* rmtfs upper guard */ > + memory@f2901000 { > + reg = <0 0xf2901000 0 0x1000>; > + no-map; > + }; qcom,use-guard-pages instead [...] > + vreg_l14a_1p88: ldo14 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + regulator-boot-on; > + /* > + * We can't properly bring the panel back if it gets turned off > + * so keep it's regulators always on for now. > + */ > + regulator-always-on; Sounds like your panel driver is not sequencing things properly [...] > +&uart9 { > + label = "LS-UART1"; This is a 96boards-ism> + > + status = "okay"; > +}; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; Are you sure? [...] > +&usb_2 { > + status = "okay"; > +}; > + > +&usb_2_dwc3 { > + dr_mode = "host"; Does the phone actually have something connected to both USB hosts? Would that be the weasel(?) security chip? [...] > diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-crosshatch.dts b/arch/arm64/boot/dts/qcom/sdm845-google-crosshatch.dts > new file mode 100644 > index 0000000000000..dc9938ffc0ab8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm845-google-crosshatch.dts > @@ -0,0 +1,137 @@ > +// SPDX-License-Identifier: GPL-2.0-only > + > +/dts-v1/; > + > +#include "sdm845-google-common.dtsi" > + > +/ { > + model = "Google Pixel 3 XL"; > + compatible = "google,crosshatch", "qcom,sdm845"; > + > + battery: battery { > + compatible = "simple-battery"; > + > + charge-full-design-microamp-hours = <3480000>; > + voltage-min-design-microvolt = <3600000>; > + voltage-max-design-microvolt = <4400000>; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + /* for u-boot */ > + framebuffer: framebuffer@9d400000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x9d400000 0 (2960 * 1440 * 4)>; > + width = <1440>; > + height = <2960>; > + stride = <(1440 * 4)>; > + format = "a8r8g8b8"; > + }; > + }; > + > + reserved-memory { > + framebuffer_region@9d400000 { > + no-map; > + reg = <0 0x9d400000 0 0x02400000>; > + }; > + }; > +}; > + > +&gmu { > + status = "okay"; > +}; > + > +&mdss { > + status = "okay"; > +}; I'm sure you can push some of this into -common > + > +&mdss_dsi0 { > + vdda-supply = <&vdda_mipi_dsi0_1p2>; > + > + status = "okay"; > + > + ports { > + port@1 { > + endpoint { > + remote-endpoint = <&panel_in>; > + data-lanes = <0 1 2 3>; > + qcom,te-source = "mdp_vsync_e"; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "samsung,s6e3ha8"; > + reg = <0>; > + > + vci-supply = <&vreg_l28a_3p0>; // downstream which supply should /* upstream */ use then? :( Konrad