Re: [PATCH v6 4/8] drm/panel: sw43408: Add enable/disable and reset functions

[David Heidelberg <david@ixit.cz>]

On 12/12/2025 16:39, David Heidelberg wrote:
> On 09/12/2025 23:51, David Heidelberg wrote:
>> On 09/12/2025 23:37, Dmitry Baryshkov wrote:
>>> On Mon, Dec 08, 2025 at 10:41:57AM +0100, David Heidelberg via B4 
>>> Relay wrote:
>>>> From: David Heidelberg <david@ixit.cz>
>>>>
>>>> Introduce enable(), disable() and reset() functions.
>>>>
>>>> The enable() and disable() callbacks keep the symmetry in the commands
>>>> sent to the panel and also make a clearer distinction between panel
>>>> initialization and configuration.
>>>
>>> It's not just it. There is a difference between commands being sent in
>>> en/disable and prepare/unprepare.
>>
>> Thanks, I didn't know. Is there good rule how to distinguish, which 
>> command should go where?
> 
> How about I would "reduce" this patch to putting reset sequence into own 
> function, so Pixel 3 support could get merged?
> 
> The display will need more work anyway, would you be fine with this 
> approach?

As I did additional few changes, I'll sent v7 now, where I'll just 
abstract _reset() into own function.

I would address any other (non reviewed) changes when we manage to get 
panel with the driver behave stable on mainline/-next.

If you decide this change is worthy of inclusion in this series, I'm 
open to bring this commit back in future revisions.

Thank you
David