From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5251525A659 for ; Tue, 21 Oct 2025 09:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761038146; cv=none; b=FpH4woWBlOaISDDSLXkOQ8emZKItck8u8U5aBapHUBa3FWgbU2TZsYf9NKz4hMI0jtiYmBWgR0ygy2kBYPHFDaVgLmqRz5YTsyNWzd1VVmVp3lZvu0gowv5rzH0a8vFMvWjFj8GqMoS8KLdfv4avMR+QMYVvc+JUX6Re3azsFrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761038146; c=relaxed/simple; bh=GNrGy3kVOCb069qWWAb9qAl3F4zfrvvJBIsSErL0m9g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=efsIImaDacoOYo2vAj9B5cf9QMWEtHVwh0pRgfVhj09H2TBbj8XSVUb3UjqSoAzcKiDIcHnodEE3ZND2k7n25AJ2HBSHftlcnk8OHgXPomw5Sk4okEjRmEAlDN3KJcZpPTGfPq/Kibt6sxdQt9VAey2/fgWVv3GUu3oJMhJ9ymg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ra0gkOzw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ra0gkOzw" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59L80ZP1024879 for ; Tue, 21 Oct 2025 09:15:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= avNchYSSQ5C76WL9TdivX7otlmLMTH9erYuzeGDpuJU=; b=Ra0gkOzwzkGEMmWV HAWz1/Ail+Ta+Lr+rcEAfTpNe+UnkKBkMZXcEylYUnF8I1p1KdTs6WF4Ha6y/SG3 PwO+idtwtAdS9qOmJ0ntW3glzURxBEXMWLkrHru+AehWVmBm1RisrExV4WqzpRq+ 9y43pkSbbDY54w3B+pJexaUnJ9Q3ECl/IXhvbf7uZbJuU7lynFJSk97ImiwAiDeQ jVJ/lPcgxVZsbUsg6rRqJ5QhTogcoZsigRda/Qrj8/mH/m4mwPZJ+9DU/Xfl0t8n 4kIBSjBbaT1R675+wgJzYYP9Eph9Dgpxe1iTGi9AcqUGRlniEIGzOV4/REiYFXA7 K+w5RQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49wsws2gdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Oct 2025 09:15:44 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b609c0f6522so18511a12.3 for ; Tue, 21 Oct 2025 02:15:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761038143; x=1761642943; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=avNchYSSQ5C76WL9TdivX7otlmLMTH9erYuzeGDpuJU=; b=HY40bBu08zGnMVDMvkz8YsqiJ0CkZGOTACLQwxxojpkgG2ohSKDxvLJcE6KuXkxWvO ptNA7WwoKLNBESKCfzDcX2WwLzA1PpEoo9op/gNa82biGM97Z5QL8eDuKxH2o2pwonzK 6A19iJ3u7WLohEcAsMUO/VTrnrhTzE9btJ9zcsmCjerb7AgcV+9m9hRsyoEouRAbDWbw ZKpEKbeUCevv29uvxMsTtuoDhbJUz3hQ+9IY0Dc9Fm6aCUjq5houJxiOpWjYdN4Vd55C L+pJOuldlL1mb7Qwcfy7EaIMRH2cNPKrMLNB7oHx/u6xolN3EwHVkdewE/HV0IwtgmZc PxQg== X-Forwarded-Encrypted: i=1; AJvYcCXZzeY2a9CBFKp4COacXwztpRKQe5kgJ1v7ainNeUyq4NbKEjoudqnVgyPJE9Zlt6x/NUdcRgS6kF2tNGBs@vger.kernel.org X-Gm-Message-State: AOJu0YxIDDLUBEzk/nkGTBUPvh5Zt4htdTL8oWf5rkvyBkjIJQiQ37ak 0ciNgFZ7t5Xz5pg498D0DytkaQ1jhnH7SJxBdokzv7wUtW/U7FXZutBXiBVwLwwU3HJiYZ5gMsM bY7r02sMRpUrxnHCTWZiDR+LuN61A3TvMtBozCEJakx1RlcSaQ94B+ytP9PyBthK+BmDK X-Gm-Gg: ASbGncshPbm0z90nico4NJbC8KEBvsJKPNWl5CSx5zxpckjYaaoC5JCu4RnOpsTEqtX LPuW7VmNTzVqsbdCYnqeeRP5H7ptI+WJU6lfpn6iL4JgtrYvF+9YHKKfOh5V+UPCHxgVSwhiQGM Fv9A7NHq5S1YXMg6Fzdjy/wlnjyt8uypN8J2+FD1p/GQBP0HCuW4ywVLvHspSqKEuTGsEQ/dA/5 JdqhjD25k6CRXnSDv1RCzsw3D9Y2EkPV7SKAcYsj2Lub4MeGLtdJJxYLjjrhN4vDbdIzMg1rw0X JvNIk8MZdxCtZArfHsrPot4mEnMLjUd8JYRZK2vqd6syP9V5qL177vrHsFqx//WNvI8w+Mi4cY/ qv7Kz8qPbB4ZltmPOq9WuvC8Q+rM= X-Received: by 2002:a17:902:f54b:b0:290:55d5:41dd with SMTP id d9443c01a7336-290c9c89dafmr224968385ad.5.1761038142868; Tue, 21 Oct 2025 02:15:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHl0wvQqiifAOiiVECG0+AnufRO4O9f7wGK/yit+8fGE8HpLP64lRTzQy6MtrZfs5AVKXRoVQ== X-Received: by 2002:a17:902:f54b:b0:290:55d5:41dd with SMTP id d9443c01a7336-290c9c89dafmr224968105ad.5.1761038142409; Tue, 21 Oct 2025 02:15:42 -0700 (PDT) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246fd8edfsm103090695ad.44.2025.10.21.02.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 02:15:42 -0700 (PDT) Message-ID: <2eb77c1a-85ce-42e8-b77a-82b8e175d943@oss.qualcomm.com> Date: Tue, 21 Oct 2025 14:45:38 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC_8750 from m to y To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-kernel@vger.kernel.org References: <20251017-update_defconfig_tcsrcc_sm8750-v1-1-34b1b47a0bda@oss.qualcomm.com> <30390038-0f90-48a4-befe-475cf88ba1fb@kernel.org> <37f54b76-a274-4ce2-aaa9-88ba0eb84199@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIwMDE0OCBTYWx0ZWRfX9+b5riPeBtcG iTiexaEN74fnDMHrkkZ79PC8ZDOWrRdODvynqsZp9hcawlvssvvktNtNFlkIKGDp7gnv/p8TNgV F48ZRxJrRnYYySuNE0R/lj2l6G10hRlO/zYXtCrQSOtFUG3kBtyN492surojKp5sJlAfbWB5QRf zXaBu71YYLyvWhtcRhLeETg1reJpyTWeytfkmGPxw5peKzf7jHuHyCq2vp2brkVeRVhay6/73UV kZU7EqsgRnFrXe3zWUZ5it7ulBvRZeSOXdFjfapyAyR1w6v9cUoqjPilWAeuPxNy4O59hw1DY4Y RTHfBf3RPcBpCG8K4ItmZrYqAi6/qzJh6qVf4vhB5UirNGk8yHde4Rva4PgR4ht70etVnGU4JcM pkWTQO17hyW22zm6PibF5Mc0zbgpJg== X-Proofpoint-GUID: wvmI1tJXtucKgFY-HjtLsZF2UNANnR26 X-Proofpoint-ORIG-GUID: wvmI1tJXtucKgFY-HjtLsZF2UNANnR26 X-Authority-Analysis: v=2.4 cv=a+E9NESF c=1 sm=1 tr=0 ts=68f74f40 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=HPpIKNdv2fbYmD8Kn4IA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_07,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510200148 On 10/19/2025 5:27 PM, Dmitry Baryshkov wrote: > On Fri, Oct 17, 2025 at 10:46:43AM +0530, Taniya Das wrote: >> >> >> On 10/17/2025 10:00 AM, Krzysztof Kozlowski wrote: >>> On 16/10/2025 20:53, Taniya Das wrote: >>>> The TCSR clock controller is required during boot to provide the ref >>>> clocks to the UFS controller. Setting CONFIG_SM_TCSRCC_8750 to y ensures >>>> the UFS driver successfully probe and initialize the device. >>>> >>>> Without this change, the UFS subsystem fails to mount as a usable file >>>> system during boot. >>> >>> >>> That's not what I observed. UFS works fine, especially that it is a >>> module, so no, this is not a desired change and explanation is not only >>> insufficient but actually incorrect. >>> >> >> Krzysztof, on Pakala MTP we are observing the below issue and it >> requires the module of tscrcc to be loaded explicitly. This patch also >> aligns to how it is on all other targets. >> >> /soc@0/phy@1d80000: Failed to get clk index: 2 ret: -517 >> [ 10.496570] ufshcd-qcom 1d84000.ufs: freq-table-hz property not specified >> [ 10.503660] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to >> find vdd-hba-supply regulator, assuming enabled >> [ 10.514548] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to >> find vccq2-supply regulator, assuming enabled >> [ 10.565955] platform 1d80000.phy: deferred probe pending: (reason >> unknown) >> [ 10.573078] platform 1d84000.ufs: deferred probe pending: >> ufshcd-qcom: ufshcd_pltfrm_init() failed > > This will also require you to set CONFIG_SCSI_UFS_QCOM=y (=m in > defconfig), CONFIG_PHY_QCOM_QMP_UFS=y (also =m in defconfig), etc. So, I > doubt that you are using defconfig as is. Please extend your > configuration in order to pick this module. > > Note, defconfig is supposed to be used by multiple platforms and > multiple defice. As sych we can't enable all bootable devices. It is > expected that the users either change their configuration or use > initramfs. Only "working console" is expected to be working with the > defconfig and that's only because systemd doesn't reopen /dev/console > after probing modules. If it were, we could have moved all pinctrl, > interconnect and other similar drivers to =m in order to make the > footprint smaller for other platforms. > I agree not all configs should be made y, but expected the required configurations should be made available. I will share this feedback to the team and also ensure this expectation is taken care. -- Thanks, Taniya Das