From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
shawn.guo@linaro.org, sboyd@codeaurora.org,
linux-arm-msm@vger.kernel.org, spk.linux@gmail.com,
thomas.ab@samsung.com, t.figa@samsung.com,
santosh.shilimkar@ti.com, thomas.petazzoni@free-electrons.com,
pramod.gurav@smartplayin.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V3 08/10] cpufreq: cpu0: Make allocate_resources() work for any CPU
Date: Thu, 28 Aug 2014 11:22:30 +0530 [thread overview]
Message-ID: <2f01b7a9b7abbdd4539fa27dff84656523bddf19.1409201048.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1409201048.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1409201048.git.viresh.kumar@linaro.org>
Currently allocate_resources() supports only CPU0 and it would need to allocate
resources for any CPU going forward.
Add another argument to it, i.e. cpu, and update code accordingly.
Tested-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq-cpu0.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
index de38952..a5f8c5f 100644
--- a/drivers/cpufreq/cpufreq-cpu0.c
+++ b/drivers/cpufreq/cpufreq-cpu0.c
@@ -106,7 +106,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy, unsigned int index)
return ret;
}
-static int allocate_resources(struct device **cdev,
+static int allocate_resources(int cpu, struct device **cdev,
struct regulator **creg, struct clk **cclk)
{
struct device *cpu_dev;
@@ -115,24 +115,28 @@ static int allocate_resources(struct device **cdev,
int ret = 0;
char *reg_cpu0 = "cpu0", *reg_cpu = "cpu", *reg;
- cpu_dev = get_cpu_device(0);
+ cpu_dev = get_cpu_device(cpu);
if (!cpu_dev) {
- pr_err("failed to get cpu0 device\n");
+ pr_err("failed to get cpu%d device\n", cpu);
return -ENODEV;
}
/* Try "cpu0" for older DTs */
- reg = reg_cpu0;
+ if (!cpu)
+ reg = reg_cpu0;
+ else
+ reg = reg_cpu;
try_again:
cpu_reg = regulator_get_optional(cpu_dev, reg);
if (IS_ERR(cpu_reg)) {
/*
- * If cpu0 regulator supply node is present, but regulator is
+ * If cpu's regulator supply node is present, but regulator is
* not yet registered, we should try defering probe.
*/
if (PTR_ERR(cpu_reg) == -EPROBE_DEFER) {
- dev_dbg(cpu_dev, "cpu0 regulator not ready, retry\n");
+ dev_dbg(cpu_dev, "cpu%d regulator not ready, retry\n",
+ cpu);
return -EPROBE_DEFER;
}
@@ -142,8 +146,8 @@ static int allocate_resources(struct device **cdev,
goto try_again;
}
- dev_warn(cpu_dev, "failed to get cpu0 regulator: %ld\n",
- PTR_ERR(cpu_reg));
+ dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n",
+ cpu, PTR_ERR(cpu_reg));
}
cpu_clk = clk_get(cpu_dev, NULL);
@@ -159,9 +163,10 @@ static int allocate_resources(struct device **cdev,
* registered, we should try defering probe.
*/
if (ret == -EPROBE_DEFER)
- dev_dbg(cpu_dev, "cpu0 clock not ready, retry\n");
+ dev_dbg(cpu_dev, "cpu%d clock not ready, retry\n", cpu);
else
- dev_err(cpu_dev, "failed to get cpu0 clock: %d\n", ret);
+ dev_err(cpu_dev, "failed to get cpu%d clock: %d\n", ret,
+ cpu);
} else {
*cdev = cpu_dev;
*creg = cpu_reg;
@@ -183,8 +188,7 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy)
unsigned int transition_latency;
int ret;
- /* We only support cpu0 currently */
- ret = allocate_resources(&cpu_dev, &cpu_reg, &cpu_clk);
+ ret = allocate_resources(policy->cpu, &cpu_dev, &cpu_reg, &cpu_clk);
if (ret) {
pr_err("%s: Failed to allocate resources\n: %d", __func__, ret);
return ret;
@@ -322,7 +326,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
*
* FIXME: Is checking this only for CPU0 sufficient ?
*/
- ret = allocate_resources(&cpu_dev, &cpu_reg, &cpu_clk);
+ ret = allocate_resources(0, &cpu_dev, &cpu_reg, &cpu_clk);
if (ret)
return ret;
--
2.0.3.693.g996b0fd
next prev parent reply other threads:[~2014-08-28 5:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 5:52 [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 01/10] cpufreq: Add support for per-policy driver data Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 02/10] cpufreq: cpu0: Update Module Author Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 03/10] cpufreq: cpu0: don't validate clock on clk_put() Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 04/10] cpufreq: cpu0: print relevant error when we defer probe Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 05/10] cpufreq: cpu0: use dev_{err|warn|dbg} instead of pr_{err|warn|debug} Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 06/10] cpufreq: cpu0: Move per-cluster initialization code to ->init() Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 07/10] cpufreq: cpu0: try regulators with name "cpu-supply" Viresh Kumar
2014-08-28 5:52 ` Viresh Kumar [this message]
2014-08-28 5:52 ` [PATCH V3 09/10] cpufreq: cpu0: rename driver and internals to 'cpufreq_generic' Viresh Kumar
2014-09-08 23:34 ` Rafael J. Wysocki
2014-09-08 23:18 ` Stephen Boyd
2014-09-08 23:39 ` Rafael J. Wysocki
2014-09-08 23:52 ` Rafael J. Wysocki
2014-09-09 0:01 ` Stephen Boyd
2014-09-09 4:47 ` Viresh Kumar
2014-09-09 13:29 ` Rafael J. Wysocki
2014-09-09 13:52 ` Viresh Kumar
2014-09-09 0:02 ` Rafael J. Wysocki
2014-08-28 5:52 ` [PATCH V3 10/10] cpufreq: generic: set platform_{driver|device} '.name' to 'cpufreq-generic' Viresh Kumar
2014-08-28 14:16 ` [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Santosh Shilimkar
2014-09-01 6:40 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f01b7a9b7abbdd4539fa27dff84656523bddf19.1409201048.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=spk.linux@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).