From: Bryan O'Donoghue <bod@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Gjorgji Rosikopulos <quic_grosikop@quicinc.com>,
Milen Mitkov <quic_mmitkov@quicinc.com>,
Depeng Shao <quic_depengs@quicinc.com>,
Yongsheng Li <quic_yon@quicinc.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/5] media: qcom: camss: Fix RDI streaming for CSID 680
Date: Tue, 7 Apr 2026 08:43:07 +0100 [thread overview]
Message-ID: <300fdb0c-3b1c-443c-83b6-9d1d352127bf@kernel.org> (raw)
In-Reply-To: <7b349fdc-7a78-4c17-a8ae-2729bc704186@linaro.org>
On 06/04/2026 23:41, Vladimir Zapolskiy wrote:
>> /* Loop through all enabled VCs and configure stream for each */
> The comment should get an update as well, this is applicable and should be done
> for the changes in camss-csid-680.c, camss-csid-gen2.c and camss-csid-gen3.c.
I struggled with the comment myself, it didn't feel strictly necessary
for a backport but, I take your point, when you read the code the fix
and the comment should match.
---
bod
next prev parent reply other threads:[~2026-04-07 7:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 21:55 [PATCH 0/5] media: qcom: camss: Fix RDI streaming for various CSIDs bod
2026-04-06 21:55 ` [PATCH 1/5] media: qcom: camss: Fix RDI streaming for CSID 680 bod
2026-04-06 22:41 ` Vladimir Zapolskiy
2026-04-07 7:43 ` Bryan O'Donoghue [this message]
2026-04-06 21:55 ` [PATCH 2/5] media: qcom: camss: Fix RDI streaming for CSID 340 bod
2026-04-06 21:55 ` [PATCH 3/5] media: qcom: camss: Fix RDI streaming for CSID GEN2 bod
2026-04-06 21:55 ` [PATCH 4/5] media: qcom: camss: Fix RDI streaming for CSID GEN3 bod
2026-04-06 21:55 ` [PATCH 5/5] media: qcom: camss: csid: Rename en_vc to en_port bod
2026-04-07 2:24 ` Hangxiang Ma
2026-04-07 7:41 ` Bryan O'Donoghue
2026-04-07 8:16 ` [PATCH 0/5] media: qcom: camss: Fix RDI streaming for various CSIDs Loic Poulain
2026-04-07 8:36 ` Bryan O'Donoghue
2026-04-07 8:49 ` Loic Poulain
2026-04-07 9:34 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300fdb0c-3b1c-443c-83b6-9d1d352127bf@kernel.org \
--to=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_grosikop@quicinc.com \
--cc=quic_mmitkov@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=stable@vger.kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox