Re: [PATCH 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

mkrishn
2020-08-26T07:53:11Z

On 2020-08-25 04:27, Rob Herring wrote:
> On Mon, Aug 10, 2020 at 07:08:02PM +0530, Krishna Manikandan wrote:
>> MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks
>> like DPU display controller, DSI etc. Add YAML schema
>> for the device tree bindings for the same.
>>
>> Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
>>
>> Changes in v2:
>> - Changed dpu to DPU (Sam Ravnborg)
>> - Fixed indentation issues (Sam Ravnborg)
>> - Added empty line between different properties (Sam Ravnborg)
>> - Replaced reference txt files with their corresponding
>> yaml files (Sam Ravnborg)
>> - Modified the file to use "|" only when it is
>> necessary (Sam Ravnborg)
>>
>> Changes in v3:
>> - Corrected the license used (Rob Herring)
>> - Added maxItems for properties (Rob Herring)
>> - Dropped generic descriptions (Rob Herring)
>> - Added ranges property (Rob Herring)
>> - Corrected the indendation (Rob Herring)
>> - Added additionalProperties (Rob Herring)
>> - Split dsi file into two, one for dsi controller
>> and another one for dsi phy per target (Rob Herring)
>> - Corrected description for pinctrl-names (Rob Herring)
>> - Corrected the examples used in yaml file (Rob Herring)
>> - Delete dsi.txt and dpu.txt (Rob Herring)
>>
>> Changes in v4:
>> - Move schema up by one level (Rob Herring)
>> - Add patternProperties for mdp node (Rob Herring)
>> - Corrected description of some properties (Rob Herring)
>>
>> Changes in v5:
>> - Correct the indentation (Rob Herring)
>> - Remove unnecessary description from properties (Rob Herring)
>> - Correct the number of interconnect entries (Rob Herring)
>> - Add interconnect names for sc7180 (Rob Herring)
>> - Add description for ports (Rob Herring)
>> - Remove common properties (Rob Herring)
>> - Add unevalutatedProperties (Rob Herring)
>> - Reference existing dsi controller yaml in the common
>> dsi controller file (Rob Herring)
>> - Correct the description of clock names to include only the
>> clocks that are required (Rob Herring)
>> - Remove properties which are already covered under the common
>> binding (Rob Herring)
>> - Add dsi phy supply nodes which are required for sc7180 and
>> sdm845 targets (Rob Herring)
>> - Add type ref for syscon-sfpb (Rob Herring)
>>
>> Changes in v6:
>> - Fixed errors during dt_binding_check (Rob Herring)
>> - Add maxItems for phys and phys-names (Rob Herring)
>> - Use unevaluatedProperties wherever required (Rob Herring)
>> - Removed interrupt controller from required properties for
>> dsi controller (Rob Herring)
>> - Add constraints for dsi-phy reg-names based on the compatible
>> phy version (Rob Herring)
>> - Add constraints for dsi-phy supply nodes based on the
>> compatible phy version (Rob Herring)
>>
>> Changes in v7:
>> - Add default value for qcom,mdss-mdp-transfer-time-us (Rob
>> Herring)
>> - Modify the schema for data-lanes (Rob Herring)
>> - Split the phy schema into separate schemas based on
>> the phy version (Rob Herring)
>>
>> Changes in v8:
>> - Resolve merge conflicts with latest dsi.txt file
>> - Include dp yaml change also in the same series
>
> I'm done reviewing this because I'm tired of repeating myself and
> you're
> just throwing crap at the wall and seeing what sticks. Get someone else
> working on QCom stuff to review because I'm done until someone I know
> and trust reviews it.
>
>> ---
>> .../bindings/display/msm/dpu-sc7180.yaml | 236
>> +++++++++++++++++++
>> .../bindings/display/msm/dpu-sdm845.yaml | 216
>> ++++++++++++++++++
>> .../devicetree/bindings/display/msm/dpu.txt | 141 ------------
>> .../display/msm/dsi-common-controller.yaml | 249
>> +++++++++++++++++++++
>> .../display/msm/dsi-controller-sc7180.yaml | 120 ++++++++++
>> .../display/msm/dsi-controller-sdm845.yaml | 120 ++++++++++
>
> Once again, what's the difference between dsi-controller-sc7180.yaml
> and
> dsi-controller-sdm845.yaml? I don't see one. If there's not a
> difference, why do we have msm/dsi-common-controller.yaml? If there is
> a
> difference dsi-controller-sc7180.yaml and dsi-controller-sdm845.yaml
> should *only* have what's different because
> msm/dsi-common-controller.yaml should have everything that is the same.

Rob, The dsi yaml files were split into dsi controller and dsi phy based
on your comments on patch v2.
As per the comments, I added one common yaml file for controller with
all the mandatory and optional properties along with their constraints
and only the required properties for each target is mentioned in the
target specific dsi-controller yaml file.

Thanks,
Krishna

>> .../bindings/display/msm/dsi-phy-10nm.yaml | 62 +++++
>> .../bindings/display/msm/dsi-phy-14nm.yaml | 62 +++++
>> .../bindings/display/msm/dsi-phy-20nm.yaml | 66 ++++++
>> .../bindings/display/msm/dsi-phy-28nm.yaml | 62 +++++
>> .../bindings/display/msm/dsi-phy-sc7180.yaml | 80 +++++++
>> .../bindings/display/msm/dsi-phy-sdm845.yaml | 82 +++++++
>> .../devicetree/bindings/display/msm/dsi.txt | 247
>> --------------------
>> 13 files changed, 1355 insertions(+), 388 deletions(-)
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
>> delete mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu.txt
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-common-controller.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml
>> create mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml
>> delete mode 100644
>> Documentation/devicetree/bindings/display/msm/dsi.txt