From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Hans Verkuil <hverkuil@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency
Date: Fri, 6 Feb 2026 11:26:55 +0000 [thread overview]
Message-ID: <302a655c-ba75-4fe5-80ce-2a38941e25bc@linaro.org> (raw)
In-Reply-To: <20260205145623.1360105-1-arnd@kernel.org>
On 05/02/2026 14:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
> the kernel fails to link:
>
> x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
> iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
> iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'
>
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/platform/qcom/iris/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig
> index 3c803a05305a..5498f48362d1 100644
> --- a/drivers/media/platform/qcom/iris/Kconfig
> +++ b/drivers/media/platform/qcom/iris/Kconfig
> @@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
> depends on VIDEO_DEV
> depends on ARCH_QCOM || COMPILE_TEST
> select V4L2_MEM2MEM_DEV
> - select QCOM_MDT_LOADER if ARCH_QCOM
> + select QCOM_MDT_LOADER
> select QCOM_SCM
> select VIDEOBUF2_DMA_CONTIG
> help
> --
> 2.39.5
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2026-02-06 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <oRAGaDzYfKTWx8kKFDLQCghV3xwo2mXzA_JDjN9wyNZDdL1X33zlO7mPy2Nwx1aDr1-jdIe8WGE4iJDVwtw2tA==@protonmail.internalid>
2026-02-05 14:56 ` [PATCH] media: iris: fix QCOM_MDT_LOADER dependency Arnd Bergmann
2026-02-05 14:58 ` Konrad Dybcio
2026-02-06 11:26 ` Bryan O'Donoghue [this message]
2026-03-02 10:51 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=302a655c-ba75-4fe5-80ce-2a38941e25bc@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox