From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E0645BE3 for ; Thu, 31 Oct 2024 21:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730408432; cv=none; b=Qntt3gU7rMKX+tFlBL7z2p7giMsMNezbeyncnT2aEpcHBbyWVr9cNcKUvGnLOm1RgShoZI2oWarDhee08I0ndYrGib9YPOVfSddX+lYzkZt83eFETpO+3OnaloiM6ifKu+g6Gg93LErrrbydjyD1FuBQ8d2ezna4DB42ya9Z358= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730408432; c=relaxed/simple; bh=9p2L/gsUOtDAw0oVvraU/aabiEdBTQXQnBMzEvVuzpA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rbQ/c/xsLdHhnXxO+kwPzYbR2S95+Ow9y4TeUovgU5ZCj5tNPDq21nZH9V+S8D+/RA2mmvUgyIC6uB2PaYOOIvVjN/USZ0XmiTBZfO1d0i/76ZGAeychS4/yLwdY6YrTLHfEAa2xYB1uSvLLZQuqo8lQ7FhCq3+NumSz5eWul40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OqRzQIFa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OqRzQIFa" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49VJw1NU006420 for ; Thu, 31 Oct 2024 21:00:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cQXYDYwMp5w/UPDufraPkZVemoBNsCrL5WS+2fWGtzI=; b=OqRzQIFasekmk0bc Qr98VHXL1g4GLDFS12CKQ6aGI+NuaA6ZWBLeCvJw2yTr2S/gC/1a7twRR8NcCDDq 68J9z3yNluVj1eEORquAkEqY3nEhCoYHiqLGNK156VGalNvF3qAtDwqrqKUBsGdM IH0SoGwZ0lAnz3PAyUbxZVlAYzV728VulNOXHbGN0ocp+NlelBsTkTc+ptXnrsL6 E0EzDOevLfEGYJ/nPzwxvNjmgtsYP3S11673quQLB1MaMhg9bXkgewHJ/hg/bdug rf+vVhS39+qfJjoT3wF63z0MgY0k0+LuT5WjOaX0dGaSPgRzvqc2mQKVheF+VNsI vnvLsA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42ku65brfc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 31 Oct 2024 21:00:24 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b14327832bso19945185a.1 for ; Thu, 31 Oct 2024 14:00:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730408423; x=1731013223; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cQXYDYwMp5w/UPDufraPkZVemoBNsCrL5WS+2fWGtzI=; b=jelrFolVPObnvNiC+mmgaR91pERomJ9jjmke2lB3DXPwumoW6czoo3w9ZfW8wrC9iV eMlhOoH3NpO6JCRbpYvXRpzx0LWXio3pPbYenTwldRxTsozZ0ObdKyy7+SlFhmCLPx0H FbBLMGpfjdhbytzPA/vQxe9dD1QzuU/h397KezgIhV5wS4ME7J2kig6R8ykH8qukb7Mi 8Ry+VpZYGPMP/FY1luYUflm/wYGTXM1hjz2+YlQH6z8ZnB3eruQQdiqoGf+wBp+ksuwL 6Jdz36Qe7lrz6q/A9KVmeBLBIQrBiJzxfs6udSkc5v9ciDppOoJq0CMWLvwjZfZhgLlG W3IA== X-Forwarded-Encrypted: i=1; AJvYcCW6cYoVDOCZW+mmrr410v3MUxi2utIenkMBNJpQ4FITjCTieZHSqEWKrI7fEcZ9xdfKuToU0zKcdnCOMc8S@vger.kernel.org X-Gm-Message-State: AOJu0YzFy3FSaI+0dr1/kD6TcLNu59P/VXjZkR9Sipv3FNXzvWhB2Hj2 Vh5op0yN8N6PYfNYLiJS+fo3OJSc+YB6131wOG8/FJG5K4L0DzNanSy/byAfiNfwpynfHC5nMH4 XZmNoUlSQXyVmaBwilHrwWpBxdyEjOwZAOmmxKpWahtd38ry0J2GBB7ZJYgCWqCmA X-Received: by 2002:a05:620a:4244:b0:7ac:bb36:599a with SMTP id af79cd13be357-7b193f68d9dmr1396483485a.13.1730408423702; Thu, 31 Oct 2024 14:00:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7X3DXyUEHB5jUA7SsCpLG6ODedxFLxLwr5aSO7qvzGjyUq4xOk1NXhSiKUvlHHhYkltCg/g== X-Received: by 2002:a05:620a:4244:b0:7ac:bb36:599a with SMTP id af79cd13be357-7b193f68d9dmr1396480785a.13.1730408423177; Thu, 31 Oct 2024 14:00:23 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e564c4f2dsm103158466b.52.2024.10.31.14.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 14:00:22 -0700 (PDT) Message-ID: <304b909d-bf2d-446c-acc9-e65b94627468@oss.qualcomm.com> Date: Thu, 31 Oct 2024 22:00:20 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: x1e80100-crd: describe HID supplies To: Johan Hovold , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Stephan Gerhold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241029075258.19642-1-johan+linaro@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241029075258.19642-1-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5qW3PljQ55dT7r3nRPe41RKUSA3ezgSB X-Proofpoint-ORIG-GUID: 5qW3PljQ55dT7r3nRPe41RKUSA3ezgSB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=818 suspectscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410310158 On 29.10.2024 8:52 AM, Johan Hovold wrote: > Add the missing HID supplies to avoid relying on other consumers to keep > them on. > > This also avoids the following warnings on boot: > > i2c_hid_of 0-0010: supply vdd not found, using dummy regulator > i2c_hid_of 0-0010: supply vddl not found, using dummy regulator > i2c_hid_of 1-0015: supply vdd not found, using dummy regulator > i2c_hid_of 1-0015: supply vddl not found, using dummy regulator > i2c_hid_of 1-003a: supply vdd not found, using dummy regulator > i2c_hid_of 1-003a: supply vddl not found, using dummy regulator > > Note that VREG_MISC_3P3 is also used for things like the fingerprint > reader which are not yet fully described so mark the regulator as always > on for now. > > Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") > Reviewed-by: Abel Vesa > Signed-off-by: Johan Hovold > --- [...] > > + vreg_misc_3p3: regulator-misc-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_MISC_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&misc_3p3_reg_en>; property-n property-names for consistency, please Reviewed-by: Konrad Dybcio Konrad