From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168DCC07E9D for ; Mon, 26 Sep 2022 10:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234755AbiIZKET (ORCPT ); Mon, 26 Sep 2022 06:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233807AbiIZKER (ORCPT ); Mon, 26 Sep 2022 06:04:17 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E5EF33E3A for ; Mon, 26 Sep 2022 03:04:16 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id z6so9421931wrq.1 for ; Mon, 26 Sep 2022 03:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=sTAPIVJNbp4iICt5sfzGH6YEb6tzSO6KPzd55XSaBdY=; b=c4mAGGxhECtHjTjrRnn3HOx1EiKljfJ1NXJYEaKtgI2W3TMnIj5nbJDrkv0lDfDQTe 9FPk9F+P8sNDeHu7vqmwLL3jQwsv5ZDk5FjYHS0YQj6EJuBex7Zafz18ORwWbqt8dZtx g/mScToh/dwCUDkcSGfsetgo1+AEjH2d/OjqBI6jUbGNBPCkeFa7eUDDGFmTf9Aiy0fb XGFVmJh9BxNerYm+4FeOdDGQEDGh9llgwwRoAjWOhjd9A2DUifpkVz3LkKBj7sgNBv9q pySYMYrvA7yM7PVrMv5sLTYK41F8G1u5tjR1jNWBm4a5fLWapJL9DXs2AJi5m2nwMUkv yG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=sTAPIVJNbp4iICt5sfzGH6YEb6tzSO6KPzd55XSaBdY=; b=T6lzI1sPfPmy9cLNnHeYa35jdNqphjW0y9XLJ/nwoDX/iMQX5kvE48i+zZw4HrPsQK K0sPUrUAckCgumPlGlMNIDDhkkwJdrRRjpXHJ572z0UiaSarJb4jkZ/8fGRyh66xPOxG bptwgZzweiBLCxlv9Bei1M7N4jKgyjc30BxVXgQlNraMIagNInT/nD6Fe5NVleeoy81t ZihNPa/fUbLy3+HkvK3qDBPvKrafRzmza0dUNVQW+zZHtIoXhsMnvPY47+WReFymibqc 9DkxdhxrDKhoQ18ceO+BqLl+g/f8Uf/nTXnju06xOMHpT9OYQfjX2cCr0oyBFEGchyq6 Lywg== X-Gm-Message-State: ACrzQf0sw4BP8wzZdwA78GPq0prGMCHxLG5UB+iQTiPGWh1J44uokdhn hveD/zIz2ugCsMRMa3MJbuJSVg== X-Google-Smtp-Source: AMsMyM4ES3y+zy1qMG1o3vbqYnbjhuFHSDXFP/iGUf6v7wgMwvvhoB8/maq1VdkF1IcTpccGNUCYyg== X-Received: by 2002:a5d:6d07:0:b0:22a:3f21:3b56 with SMTP id e7-20020a5d6d07000000b0022a3f213b56mr12562644wrq.679.1664186654836; Mon, 26 Sep 2022 03:04:14 -0700 (PDT) Received: from [192.168.27.65] (home.beaume.starnux.net. [82.66.176.246]) by smtp.gmail.com with ESMTPSA id h9-20020a05600c350900b003b492338f45sm12043677wmq.39.2022.09.26.03.04.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 03:04:14 -0700 (PDT) Message-ID: <3070538e-fa8d-4506-bbf8-c2770d092eb5@linaro.org> Date: Mon, 26 Sep 2022 12:04:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Content-Language: en-US To: Krzysztof Kozlowski , Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220925210229.128462-1-luca@z3ntu.xyz> <20220925210229.128462-2-luca@z3ntu.xyz> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26/09/2022 11:22, Krzysztof Kozlowski wrote: > On 25/09/2022 23:02, Luca Weiss wrote: >> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'. >> >> Signed-off-by: Luca Weiss >> --- >> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi >> index 33517cccee01..01f14d5f314d 100644 >> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi >> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi >> @@ -27,7 +27,7 @@ pwrkey@800 { >> bias-pull-up; >> }; >> >> - usb_id: misc@900 { >> + usb_id: extcon@900 { > > Why? extcon is Linux specific name and should not be added to DTS. > Anything requires it? It matches the current dt bindings: Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml: "extcon@[0-9a-f]+$": type: object $ref: /schemas/extcon/qcom,pm8941-misc.yaml# Neil > > > Best regards, > Krzysztof >