Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jie Gan <jie.gan@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH RFC 3/6] dt-bindings: arm: qcom: add QDCP STM source
Date: Thu, 19 Nov 2026 15:02:35 +0100	[thread overview]
Message-ID: <30c74f5e-cd18-445a-964b-b839fc077b25@kernel.org> (raw)
In-Reply-To: <20261119-introduce-qcom-qecp-feature-v1-3-b1a730d2c57a@oss.qualcomm.com>

On 19/11/2026 10:01, Jie Gan wrote:
> Document the Qualcomm QDCP-backed CoreSight STM (System Trace Macrocell)
> source, for platforms where the STM control registers are owned by
> Qualcomm Embedded Co-Processor (QECP) firmware instead of the
> application processor (AP).
> 
> The node describes only the STM stimulus aperture, the MMIO region the
> AP writes trace data to. Firmware controls the STM through the Qualcomm
> Debug Control Protocol (QDCP) provider referenced by the qcom,qdcp
> phandle. Firmware also controls the block's clocks and power, so the
> binding has no clocks or power-domains properties.
> 
> The output port must have an endpoint so the source can be connected to
> a trace sink.
> 
> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
> ---
>  .../bindings/arm/qcom,coresight-stm-qdcp.yaml      | 111 +++++++++++++++++++++
>  1 file changed, 111 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-stm-qdcp.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-stm-qdcp.yaml
> new file mode 100644
> index 000000000000..f365ce2450ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-stm-qdcp.yaml
> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/qcom,coresight-stm-qdcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QDCP-backed CoreSight STM source
> +
> +maintainers:
> +  - Jie Gan <jie.gan@oss.qualcomm.com>
> +
> +description: |
> +  The System Trace Macrocell (STM) is a CoreSight trace source designed for
> +  high-bandwidth trace of software instrumentation, made up of memory-mapped
> +  writes to the STM stimulus aperture.
> +
> +  On Qualcomm platforms where the STM control registers are owned by QECP
> +  firmware, this binding describes an STM whose stimulus aperture is mapped by
> +  the application processor for data writes, while enabling and disabling the
> +  trace path is delegated to firmware over the Qualcomm Debug Control Protocol
> +  (QDCP). It references a QDCP provider through the "qcom,qdcp" phandle rather
> +  than exposing the STM programming registers directly.
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: qcom,coresight-stm-qdcp
> +  required:
> +    - compatible
> +
> +properties:
> +  $nodename:
> +    pattern: "^stm(@[0-9a-f]+)$"

That's RFC, so maybe you do not expect review. Explain in cover letter
as the most important part what do you expect from us.

Anyway, drop, I do not see how is this conforming to DT spec.


> +
> +  compatible:
> +    const: qcom,coresight-stm-qdcp
> +
> +  reg:
> +    maxItems: 1
> +
> +  reg-names:
> +    items:
> +      - const: stm-stimulus-base
> +
> +  qcom,qdcp:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the specific "connection-N" child node of the QDCP
> +      provider (see qcom,qdcp.yaml) that owns this STM's control registers
> +      and services the firmware enable/disable transactions. This must
> +      reference the connection child node directly, not the top-level
> +      QDCP provider node itself.

No, the QDCP is just part of this device.


> +
> +  qcom,qdcp-source-id:
> +    $ref: /schemas/types.yaml#/definitions/uint64
> +    description:
> +      QECP firmware source identifier for this STM, used to address it in QDCP
> +      transactions.

Drop, we don't allow instance IDs.

Best regards,
Krzysztof

  reply	other threads:[~2026-11-19 14:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:01 [PATCH RFC 0/6] Coresight: Introduce Qualcomm QDCP support for QECP-owned trace blocks Jie Gan
2026-11-19  9:01 ` [PATCH RFC 1/6] dt-bindings: soc: qcom: add QDCP provider Jie Gan
2026-11-19 14:00   ` Krzysztof Kozlowski
2026-11-19  9:01 ` [PATCH RFC 2/6] soc: qcom: add QDCP firmware provider Jie Gan
2026-11-19  9:01 ` [PATCH RFC 3/6] dt-bindings: arm: qcom: add QDCP STM source Jie Gan
2026-11-19 14:02   ` Krzysztof Kozlowski [this message]
2026-11-19  9:01 ` [PATCH RFC 4/6] coresight: " Jie Gan
2026-11-19  9:01 ` [PATCH RFC 5/6] dt-bindings: arm: qcom: add QDCP TMC ETR sink Jie Gan
2026-11-19  9:01 ` [PATCH RFC 6/6] coresight: tmc: add QDCP ETR sysfs support Jie Gan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c74f5e-cd18-445a-964b-b839fc077b25@kernel.org \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox