From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [RFC/PATCH 1/1] mmc: block: Add MMC write packing statistics Date: Wed, 6 Jun 2012 13:56:13 -0700 (PDT) Message-ID: <310175ff06fd45dca660047535666a61.squirrel@www.codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:47577 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815Ab2FFU4N (ORCPT ); Wed, 6 Jun 2012 16:56:13 -0400 Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rahul Bedarkar Cc: Maya Erez , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, open list >> + >> + =A0 =A0 =A0 for (i =3D 1 ; i <=3D max_num_of_packed_reqs ; ++i) { > This is something magical number for iterations. why can not we start from > zero. The statistics are kept in the array in the index that equals the numbe= r of packed requests. Therefore, they are kept in the array in indexes 1 = to max num of packed reqs. I will add a comment to explain that. Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum