Re: [PATCH v2 1/4] dt-bindings: media: qcom,sm8550-iris: document QCS8300 IRIS accelerator

[Vikash Garodia <quic_vgarodia@quicinc.com>]

On 4/18/2025 3:52 PM, Bryan O'Donoghue wrote:
> On 18/04/2025 07:28, Vikash Garodia wrote:
>> Document the IRIS video decoder and encoder accelerator found in the
> 
> Document the IRIS video "encoder/decoder" or "transcoder"
> 
> 
>> QCS8300 platform. QCS8300 is a downscaled version of SM8550, thereby
> 
> is a down-scaled version of the SM8550.
> 
> QCS8300 has a fewer capabilities compared to SM8550.
Ack.
> 
> Note: It might be nice to give a brief overview of what the differences are
> since you mention them or instead of making it a diff of 8550 just to state what
> the QCS8300 can do.
The reason to compare it with 8550 is that the patch adds the delta ontop of
8550. All other structures, it still uses from 8550.

Regards,
Vikash
> 
>> have different(lower) capabilities when compared to SM8550.
>>
>> This patch depends on patch 20250225-topic-sm8x50-iris-v10-a219b8a8b477
>>
>> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> index
>> f567f84bd60d439b151bb1407855ba73582c3b83..3dee25e99204169c6c80f7db4bad62775aaa59b5 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> @@ -24,6 +24,7 @@ properties:
>>         - enum:
>>             - qcom,sm8550-iris
>>             - qcom,sm8650-iris
>> +          - qcom,qcs8300-iris
>>       power-domains:
>>       maxItems: 4
>>
> Otherwise looks good an applies, please update your commit long and add:
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>