From: "Eric Gonçalves" <ghatto404@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE
Date: Fri, 15 Aug 2025 20:28:32 -0300 [thread overview]
Message-ID: <31CA09B3-E451-4EC1-8273-A1F09735D1FB@gmail.com> (raw)
In-Reply-To: <xmxo5uogkexiwq5zh2eza53pnl5jrqidd7an7bftjtq4wpaup5@mlekuufdbg5v>
On August 15, 2025 19:03:20 GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Fri, Aug 15, 2025 at 03:14:26PM +0000, Eric Gonçalves wrote:
>> Add new device support for the Samsung Galaxy S20 FE 4G/5G
>> (SM-G980/SM-G981B) phone
>>
>> What works:
>> - SimpleFB
>> - Pstore/ramoops
>
>While the patch is correct, are there any obstacles in enabling more
>devices on the phone? I'd say, buttons, remoteprocs, PCI and USB
>peripherals should be low hanging fruits. If you can read pmic_array
>from debugfs/qcom_socinfo, then you should be able to identify PMICs and
>add corresponding regulators too.
>
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> .../boot/dts/qcom/sm8250-samsung-r8q.dts | 47 +++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
>
Hello Dmitry,
Recently my device's battery stopped responding and I was not able to work on the DT any further, so I decided to upstream what I already have so far. Thanks for the feedback, I'll include more features on future patches.
Best regards,
Eric
next prev parent reply other threads:[~2025-08-15 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 15:14 [PATCH v1 0/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE Eric Gonçalves
2025-08-15 15:14 ` [PATCH v1 1/2] dt-bindings: arm: qcom: document r8q board binding Eric Gonçalves
2025-08-20 21:14 ` Rob Herring (Arm)
2025-08-15 15:14 ` [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE Eric Gonçalves
2025-08-15 22:03 ` Dmitry Baryshkov
2025-08-15 23:28 ` Eric Gonçalves [this message]
2025-08-16 13:41 ` Dmitry Baryshkov
2025-09-01 19:45 ` [PATCH v1 0/2] " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31CA09B3-E451-4EC1-8273-A1F09735D1FB@gmail.com \
--to=ghatto404@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox