From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144D9C433F5 for ; Tue, 3 May 2022 22:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242569AbiECWiD (ORCPT ); Tue, 3 May 2022 18:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbiECWiC (ORCPT ); Tue, 3 May 2022 18:38:02 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E15427E3 for ; Tue, 3 May 2022 15:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651617268; x=1683153268; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=AfvE0mqD8LgC7mSKZ42+S6hxxRlmYK3Qfez+UJVVjYw=; b=T8aGiyfdAX4RVAFHuWtOdvD3w9wXcwaWk0UKhsFhdPada8FNLAp0epwZ 7XaT5KxPk3a/WSMu0SdroYwkz6ZeWCdpQl4hd7Ga9ASQrK4W9iFS7LLI0 U0MKLSCvU9qw27EA3jKsvqXS+pANp9tvoT/L6Aa2+uTBHs5L77ZMLlgo/ k=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 03 May 2022 15:34:28 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 15:34:28 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 3 May 2022 15:34:27 -0700 Received: from [10.38.244.235] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 3 May 2022 15:34:25 -0700 Message-ID: <32ad5e91-cccb-c73f-548a-960a84a40173@quicinc.com> Date: Tue, 3 May 2022 15:34:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Rob Clark , Sean Paul CC: Stephen Boyd , David Airlie , Daniel Vetter , , , References: <20220209172520.3719906-1-dmitry.baryshkov@linaro.org> <20220209172520.3719906-5-dmitry.baryshkov@linaro.org> <5935ae15-2497-1c74-5b51-5baef7f78851@linaro.org> From: Abhinav Kumar In-Reply-To: <5935ae15-2497-1c74-5b51-5baef7f78851@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/3/2022 3:11 PM, Dmitry Baryshkov wrote: > On 04/05/2022 00:34, Abhinav Kumar wrote: >> >> >> On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: >>> As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move >>> SSPP debugfs creation from dpu_plane to dpu_kms. >>> >> >> Change is fine by itself, but is it really needed? >> Wouldnt it be better to keep dpu_debugfs_sspp_init in dpu_plane.c? > > No. We are going to break the dependency between planes and SSPPs at > some point. Let's move the debugfs functions to the generic location. > Alright, keeping that dependency-break in mind, Reviewed-by: Abhinav Kumar >> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h |  1 - >>>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c     | 19 +++++++++++++++++++ >>>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c   | 16 ---------------- >>>   3 files changed, 19 insertions(+), 17 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h >>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h >>> index f805c30643b1..674f311f99b4 100644 >>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h >>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h >>> @@ -415,7 +415,6 @@ struct dpu_hw_pipe *dpu_hw_sspp_init(enum >>> dpu_sspp idx, >>>    */ >>>   void dpu_hw_sspp_destroy(struct dpu_hw_pipe *ctx); >>> -void dpu_debugfs_sspp_init(struct dpu_kms *dpu_kms, struct dentry >>> *debugfs_root); >>>   int _dpu_hw_sspp_init_debugfs(struct dpu_hw_pipe *hw_pipe, struct >>> dpu_kms *kms, struct dentry *entry); >>>   #endif /*_DPU_HW_SSPP_H */ >>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >>> index 4d2b75f3bc89..8196b11fe2f3 100644 >>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c >>> @@ -259,6 +259,25 @@ void dpu_debugfs_create_regset32(const char >>> *name, umode_t mode, >>>       debugfs_create_file(name, mode, parent, regset, >>> &dpu_fops_regset32); >>>   } >>> +static void dpu_debugfs_sspp_init(struct dpu_kms *dpu_kms, struct >>> dentry *debugfs_root) >>> +{ >>> +    struct dentry *entry = debugfs_create_dir("sspp", debugfs_root); >>> +    int i; >>> + >>> +    if (IS_ERR(entry)) >>> +        return; >>> + >>> +    for (i = SSPP_NONE; i < SSPP_MAX; i++) { >>> +        struct dpu_hw_pipe *pipe_hw; >>> + >>> +        if (!dpu_kms->rm.sspp_blks[i - SSPP_NONE]) >>> +            continue; >>> + >>> +        pipe_hw = to_dpu_hw_pipe(dpu_kms->rm.sspp_blks[i - SSPP_NONE]); >>> +        _dpu_hw_sspp_init_debugfs(pipe_hw, dpu_kms, entry); >>> +    } >>> +} >>> + >>>   static int dpu_kms_debugfs_init(struct msm_kms *kms, struct >>> drm_minor *minor) >>>   { >>>       struct dpu_kms *dpu_kms = to_dpu_kms(kms); >>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >>> index 146dbccd79cd..37742f74a7bf 100644 >>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c >>> @@ -1359,22 +1359,6 @@ void dpu_plane_danger_signal_ctrl(struct >>> drm_plane *plane, bool enable) >>>       _dpu_plane_set_qos_ctrl(plane, enable, DPU_PLANE_QOS_PANIC_CTRL); >>>       pm_runtime_put_sync(&dpu_kms->pdev->dev); >>>   } >>> - >>> -/* SSPP live inside dpu_plane private data only. Enumerate them >>> here. */ >>> -void dpu_debugfs_sspp_init(struct dpu_kms *dpu_kms, struct dentry >>> *debugfs_root) >>> -{ >>> -    struct drm_plane *plane; >>> -    struct dentry *entry = debugfs_create_dir("sspp", debugfs_root); >>> - >>> -    if (IS_ERR(entry)) >>> -        return; >>> - >>> -    drm_for_each_plane(plane, dpu_kms->dev) { >>> -        struct dpu_plane *pdpu = to_dpu_plane(plane); >>> - >>> -        _dpu_hw_sspp_init_debugfs(pdpu->pipe_hw, dpu_kms, entry); >>> -    } >>> -} >>>   #endif >>>   static bool dpu_plane_format_mod_supported(struct drm_plane *plane, > >