Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

Krzysztof Kozlowski
2024-06-20T15:49:33Z

On 18/06/2024 15:59, Dzmitry Sankouski wrote:
> add samsung,s2dos05 core MFD module binding
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 90 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml
> new file mode 100644
> index 000000000000..f2ef5171cc40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/samsung,s2dos05.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S2DOS05 Power Management IC
> +
> +maintainers:
> + - Dzmitry Sankouski <dsankouski@gmail.com>
> +
> +description:
> + This is a part of device tree bindings for S2M and S5M family of Power
> + Management IC (PMIC).

No, it is not.

> +
> + The S2DOS05 is a companion power management IC for the panel and touchscreen
> + in smart phones. Provides voltage and current regulators and adc for power/current
> + measurements.
> +
> +properties:
> + compatible:
> + const: samsung,s2dos05-pmic

s2dos05 cannot be anything else than pmic. Drop the suffix.

> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + $ref: /schemas/regulator/samsung,s2dos05.yaml
> + description: List of regulators and its properties
> +
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@60 {
> + compatible = "samsung,s2dos05";
> + reg = <0x60>;
> +
> + regulators {

Messed indentation. Everywhere, each of your patch.

> + s2dos05_ldo1: s2dos05-ldo1 {

Just "ldo1" and drop unused labels.

Best regards,
Krzysztof