From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD43E2D73A7 for ; Fri, 30 Jan 2026 18:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797075; cv=none; b=RtrgHc6ifiv5ZkkkTB38Z6SlkKgPc/zPyTvsJJKWgZjg3URISwtlliiuISRviWGrRG5RfsRWuwIB1yeS4J0yp2ClBQ9er0SVX+oWyGG3ZxiXDdAGdZavX0NHegH/n23mLO+3sU54ejy5qZa4fckYPHmk+Mii6GLJij5xFOLl5t8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797075; c=relaxed/simple; bh=AlsGI4n7E1eGCZF97Ycj9wTUYV/116rK/XKXyFkE0OU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FqyfJqRLYnfSlGCTASvtZacE2sC7sgZS8/drb4JooX0ijAXboJq6gfA6x9EbcOIwwqU1KcwkJ3jH1pKA5L49eH46XJ14WRa068/7b3yTxP/Vp36P0an24HiSrbEE5KU4uW/6/Hv0Sz7pItw3+CPtfaRGvQiGcZk6obYnoKMeFvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aZNVwP0/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OGsE/NGK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aZNVwP0/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OGsE/NGK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UB72Pi485945 for ; Fri, 30 Jan 2026 18:17:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=aZNVwP0/R5bSxwbD 25iUPXCEZVrdpd5BvqweujlgyyfQ3RHUhrRJlfK64QP4skHB9IoFN6mPM/m0NM3J WM31S+TTEqlzw09M3wcqbEOh62hyqTqIaZkg+NbfpVf6+nlVLQEXX+8Hv4VgF5oq d93zGu0EfQvPBZwlqfif2pV8gY9Bk2gEpMJtf5841J+yLLz2cuStgEuc8219xSwX wr75SGS6vBQWPv38qoBxuLYTDF1i1s7pIiTSslkQkV8xf/aIIzmP8Rp6zpg/WgTg DYpuXn42CYekJZ/DH4BHhZHpsjFn5pHo6+t0cqm2owUS8mHLKK9+fB3499c7cHKS 9+BXJA== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0gtnk7ys-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 18:17:52 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-124aa710af7so13698444c88.1 for ; Fri, 30 Jan 2026 10:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769797071; x=1770401871; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=OGsE/NGK7hlwqIhDfh8fz5aexSz7MET+VbwHAt08ycTrm1KhCIYaX2+x/JJQI/ZoLk neuBWIenl2f8OyQSAwbHSyKcL/Sez5/M6GwIWzc2OvseDvnowMfYIGlfJgk4B/y4VpeP T6NYzwg1yk5jpdvzXzAD9WMhELlVIFf1duSgy11gxMap1zJzzakjEIfkB28Poq8NItyB WtfUSrlQn2xlCr4CHztZpP9KB0e27svFVFakggUrrWQ8sGGfp16bBRG6OZ8FFdX1EmdD nwyKqpZKwc96GOr6WHIBBD/d7eBZyF0QYV/XHpT72JRI3z85aPme152QtF/Seb4ul6Jz ypug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797071; x=1770401871; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=ZhRJUd/UTG1giohlKAZ9QqqD+rTeKlaUp1D8L2MGifgLda4qBIn1crPGnYkNIct013 gtcT4/WR6SgIgNBtG6FjrezEGNbA/w2elafxODzVOiCYZfAMGvpOuVW/CimlYP8C+Un/ U8BLo5BMsQclKwChYJBbO0kBkkrHIf4jxCN9I2DYI+JnocyMIYGnHOgmLrU8aLvH3rnc wNymK/LQ+2VJAuzww09S4Mz4eOgZMBNLJkjdpUsul4NfiVVABrWA0knEBc9FndHpCyZa MFuu7tUNkvnanAm62sNa85wFtjK9J14Jq8+eec54wUz0nAYZ0rnCCQJUSLfoEpG2xlWF VqQQ== X-Forwarded-Encrypted: i=1; AJvYcCWq//iDDHrgQkc3xyWq/FL/tBul5sXzqzJh0nPlUlGiJ2S7XuH2hE5Q0aG8Rh77/YcCuKr5H8o//fdhp7KM@vger.kernel.org X-Gm-Message-State: AOJu0Yx87ijWii6xQeLaanVgOeMo87GqaTb0wWQg1srCn2voyZLSHRNH f9fivW++YorP3/VDpK3jQmGIarn4nkF4dhYL3CGadv8pXuHd8AjoZQdJi6DP+sU48lJQhCzk6O2 TKQR/U4K436NQLOXSRYSYm1BX8d1ZCkFKcZiDgdm4W42fuPy+8g5VJSLMMiGxRaF1PwCN X-Gm-Gg: AZuq6aKrKhDaki2A/vZ/qmMqdVgfWlTC31hknsaxiKxGsfzcLd9BLfG5YVilcth/uY4 fvH7eQjxtRHHDuHD2Zn3OqPzqr9jrFoJrEDzZn3XhgSki09+/+FERY+DiCfO1UiVSCONGeVv7vW YltvWQXvR6+hOpRsaWxMb0W3oAp7ZwuWYObQrYSV7Oninx7YQJOKDsGAapEUEp4VwZ91h0d4KMN yGFpkcgt7rwtV4mwW7mEaFnVJkbGryR2AOkSpqs9q/u+r6CsG8gJuNlppOcRBQGrVD5Y8vsfOFw 1lBP/NCKvdUPb/pl/ftBbNkF2KwqEdybGtc2gL5IoRA0KYo//tbQXdCXGZhCr6ArtAuwgNxxqU2 eR283m7wELX+uz+nA7wNjURhqgOHlr5oDY9ZYzVkQCbZ0vueSY86OQLdG9BUWhhyQ0yZk2pe71o 5/bg== X-Received: by 2002:a05:7022:6893:b0:124:acc6:6dd1 with SMTP id a92af1059eb24-125c100fdebmr2127523c88.46.1769797071323; Fri, 30 Jan 2026 10:17:51 -0800 (PST) X-Received: by 2002:a05:7022:6893:b0:124:acc6:6dd1 with SMTP id a92af1059eb24-125c100fdebmr2127510c88.46.1769797070680; Fri, 30 Jan 2026 10:17:50 -0800 (PST) Received: from ?IPV6:2603:8001:3300:be38:483f:f354:ec7a:3a61? ([2603:8001:3300:be38:483f:f354:ec7a:3a61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d6b906sm12204320c88.4.2026.01.30.10.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 10:17:50 -0800 (PST) Message-ID: <32fcfd27-9aa5-4466-80e2-e39a9670476b@oss.qualcomm.com> Date: Fri, 30 Jan 2026 10:17:51 -0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Abel Vesa Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> <6lieos5uudkgynizozrmzrj5ov57frzzl65b2fpanwbhbmehot@z5uhyv4ipyet> <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> Content-Language: en-US From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: tuqF7ZrwX-FuCdhsIQIyYaBJTIGWe9Eu X-Authority-Analysis: v=2.4 cv=FPcWBuos c=1 sm=1 tr=0 ts=697cf5d0 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ZdPEQgOY4kJE4xoCbToA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-ORIG-GUID: tuqF7ZrwX-FuCdhsIQIyYaBJTIGWe9Eu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDE1MCBTYWx0ZWRfX33Q01XbaDgi4 V7IjW1iWpdx21jX/Vfp0/CD43iu4ABPRkyLCZeTH23FPBV+Mgg+2++YK1dGld6bI7pYC91zREgS cbReKI/DaRCascqJOOj4Ivxonxqs3KbB4qSuJkpxDbG/hVGxZQnClTusdvdW6RnRJQYnX3gJg9L uFGTu1VTD/hr8qJIaKc1K2/SpE7ZFkaG1SwIC9L/qF+qYDLOMrtepVbPmwCcqrdCwVFTQC4fH0o MKqnaPaz/7QtT4fmPz9yhgPr7UV+GRJQLs95VkzLONCCwXOo+nB3KTzqwagB+SvYwaKifpThPYk CnkwFKtGeAXEksSA4SbZudlpdW+rLmlmxHlZL9voQwu9qTL23obFiNRQuXIRORXFxR53k14QJch v4DPCR6fRwvSaQTW2CaQ124aI368eUqG2DstxnWD2Nxez/K+wZoJPdbLm2PJF93iarHnWG6+jP2 RcG5Afa3ghIbpwd+R8Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_02,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300150 On 1/28/2026 1:38 AM, Abel Vesa wrote: > On 26-01-27 14:26:47, Wesley Cheng wrote: >> >> >> On 1/27/2026 3:46 AM, Konrad Dybcio wrote: >>> On 1/27/26 12:41 PM, Abel Vesa wrote: >>>> On 26-01-13 14:13:32, Konrad Dybcio wrote: >>>>> On 1/13/26 1:33 PM, Abel Vesa wrote: >>>>>> From: Wesley Cheng >>>>>> >>>>>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>>>>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>>>>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>>>>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>>>>> >>>>>> Signed-off-by: Wesley Cheng >>>>>> Co-developed-by: Abel Vesa >>>>>> Signed-off-by: Abel Vesa >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>>> + snps,dis_u2_susphy_quirk; >>>>>> + snps,dis_enblslpm_quirk; >>>>>> + snps,dis_u3_susphy_quirk; >>>>>> + snps,usb2-lpm-disable; >>>>> >>>>> Other SoCs have a list that's much longer, please consult Wesley if >>>>> this list is enough >>>> >>>> Checked with Wesley. He confirmed that this trimmed list is fine. >>>> He said he dropped the rest since they are related to the power saving >>>> features like USB2/3 LPM (l1 or u1/u2) and we don't seem need those. >>> >>> Is that to say that those erratas were fixed in this hardware? >>> >>> Low-power states of the link are no less than desired is possible.. >>> >> >> I think it was misunderstood. We should keep the same quirks as our >> previous targets to enable USB LPM support in certain cases. >> >> snps,hird-threshold = /bits/ 8 <0x0>; >> snps,usb2-gadget-lpm-disable; >> snps,dis-u1-entry-quirk; >> snps,dis-u2-entry-quirk; >> snps,is-utmi-l1-suspend; >> snps,usb3_lpm_capable; >> snps,has-lpm-erratum; >> tx-fifo-resize; >> snps,dis_u2_susphy_quirk; >> snps,dis_enblslpm_quirk; >> snps,usb2-lpm-disable; >> >> There are some questionable ones that I'm on the fence though, which we >> should consider removing: >> snps,usb2-lpm-disable >> snps,usb2-gadget-lpm-disable >> >> USB L1 support is routinely being verified on our devices (in host and >> device modes), so if its power over performance, we should consider removing >> the properties to disable USB L1. (esp since we're defining the HIRD >> threshold as well...) > > This should've been sorted out months ago! As part of the initial bring-up or > even the initial submission here: > https://lore.kernel.org/all/20250925-v3_glymur_introduction-v1-23-24b601bbecc0@oss.qualcomm.com/ > > Anyway, is the following list the one we should use then? > > snps,hird-threshold = /bits/ 8 <0x0>; > snps,dis-u1-entry-quirk; > snps,dis-u2-entry-quirk; > snps,is-utmi-l1-suspend; > snps,usb3_lpm_capable; > snps,has-lpm-erratum; > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > This list looks good. Thanks Wesley Cheng