Re: [PATCH 0/5] soundwire: qcom: add mmio support

Jonathan Marek
2020-06-09T11:11:39Z

On 6/9/20 5:26 AM, Srinivas Kandagatla wrote:
> Thanks Jonathan for the patches,
>
> On 08/06/2020 21:43, Jonathan Marek wrote:
>> This adds initial support for soundwire device on sm8250.
>>
>
> One thing off my list!!
>
>> Tested with the "wsa" sdw device, which is simpler than the others.
>
> WSA881x?
>
> did you test both enumeration and streaming?
>
> Are you planing to add any new WSA or WCD codec support for this SoC?
>
> thanks,
> srini
>

Yes, dual WSA881x. I tested streaming, however for the dual WSA881x case
I need specific amixer settings and an extra hack to make it work (seems
to port config stuff is broken, especially around VISENSE, it tries to
use it in the wrong direction I think). For a single WSA881x, it can
work without any extra hack.

The SoC has at least 4 codec drivers to add ("wsa macro", "rx macro",
"tx macro", "wcd938x"), with what I am doing right now I only need the
"wsa macro" codec which I've ported over from downstream. For now I am
only looking at sending patches for the required ADSP changes, but may
consider doing something with the "wsa macro" driver at some point.

>>
>> Jonathan Marek (5):
>>    soundwire: qcom: fix abh/ahb typo
>>    soundwire: qcom: add support for mmio soundwire devices
>>    soundwire: qcom: add v1.5.1 compatible
>>    soundwire: qcom: avoid dependency on CONFIG_SLIMBUS
>>    soundwire: qcom: enable CPU interrupts for mmio devices
>>
>>   drivers/soundwire/Kconfig |  1 -
>>   drivers/soundwire/qcom.c  | 42 +++++++++++++++++++++++++++++++++++----
>>   2 files changed, 38 insertions(+), 5 deletions(-)
>>