From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/7] media: qcom: camss: Add support for named power-domains
Date: Wed, 22 Nov 2023 20:55:17 +0000 [thread overview]
Message-ID: <339c3efd-8d2b-4b71-8dc1-cdc30ab7bb8a@linaro.org> (raw)
In-Reply-To: <6e66875a-5cb1-42bc-86e0-b69cf73981c0@linaro.org>
On 22/11/2023 19:55, Konrad Dybcio wrote:
>
>
> On 11/18/23 13:11, Bryan O'Donoghue wrote:
>> Right now we use fixed indexes to assign power-domains, with a
>> requirement for the TOP GDSC to come last in the list.
>>
>> Adding support for named power-domains means the declaration in the dtsi
>> can come in any order.
>>
>> After this change we continue to support the old indexing - if a SoC
>> resource declaration or the in-use dtb doesn't declare power-domain names
>> we fall back to the default legacy indexing.
>>
>> From this point on though new SoC additions should contain named
>> power-domains, eventually we will drop support for legacy indexing.
>>
>> Tested-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> So, this commit should be a NOP within this series?
>
> res->pd_name isn't defined anywhere afaics
>
> Konrad
This series is mergeable though the linux-media tree standalone, yes.
Once merged, the dtsi change given in the cover letter will be submitted.
The sm8250 change is posted here :
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/b4/b4-camss-named-power-domains-v5+sm8250
---
bod
next prev parent reply other threads:[~2023-11-22 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 12:11 [PATCH v5 0/7] media: qcom: camss: Introduce support for named power-domains Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 1/7] media: qcom: camss: Flag which VFEs require a power-domain Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 2/7] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 3/7] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 4/7] media: qcom: camss: Move VFE power-domain specifics into vfe.c Bryan O'Donoghue
2023-11-23 12:04 ` Konrad Dybcio
2023-11-23 13:53 ` Bryan O'Donoghue
2023-11-23 15:24 ` Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 5/7] media: qcom: camss: Add support for named power-domains Bryan O'Donoghue
2023-11-22 19:55 ` Konrad Dybcio
2023-11-22 20:55 ` Bryan O'Donoghue [this message]
2023-11-23 11:49 ` Konrad Dybcio
2023-11-23 13:42 ` Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 6/7] media: qcom: camss: Flag VFE-lites to support more VFEs Bryan O'Donoghue
2023-11-19 21:12 ` kernel test robot
2023-11-21 1:13 ` [PATCH v5.1] " Bryan O'Donoghue
2023-11-18 12:11 ` [PATCH v5 7/7] media: qcom: camss: Flag CSID-lites to support more CSIDs Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339c3efd-8d2b-4b71-8dc1-cdc30ab7bb8a@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=mchehab@kernel.org \
--cc=quic_grosikop@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox