From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B34AC4741F for ; Tue, 29 Sep 2020 12:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FF392075A for ; Tue, 29 Sep 2020 12:17:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qpKdWznE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730044AbgI2MRN (ORCPT ); Tue, 29 Sep 2020 08:17:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732118AbgI2MRA (ORCPT ); Tue, 29 Sep 2020 08:17:00 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5F6C0613D0 for ; Tue, 29 Sep 2020 05:16:59 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id w1so6107622edr.3 for ; Tue, 29 Sep 2020 05:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WmQ4HXFZOiQNgwplnNphS1aF43ZxufpXoarc3usGdEM=; b=qpKdWznEoF0VXNEXTayLjtsb2T+jAgRhbs/Zn/wYm6lpxIzMUgO8OS1OwVkbrPgcjq C64VyNgFzie4RdTaGZ5U03PUJ2/kRUJTZ/OI2HJi+dC8TWHvKyHQwBxig86wTzJsQntR OGaWIeqcGWN7uiIhW4KY9EIF1VzVVFgTOeQLtVADHY+PkGNt69YEYEI7rif8U42S02Rt i86vmYCPL3srS5mRbmElsm3INvC4TsXuCxmrqsJ6mM7TCAkJmIx52uSTmUZOl9lgAdcK dwKHaRWJMXJ1pnq6hKGzJWm+apPp/zaAmZI31iGgF55sAAHqOWYJWAysdSABbAdLTsaQ ic5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WmQ4HXFZOiQNgwplnNphS1aF43ZxufpXoarc3usGdEM=; b=TLBtp8L2ix679qTM1eltdPXaI0UbXSMnQduQFGjwnp3hriauB726bcTIl3jQd7/WDF eliwmsbXRT4fJY8GKT+A6SsQh598XyA+qvDtDm85pReHKJKB7YDeeqxXjkQvRzmAWN9o Gh1hRGu0ji1CNK1j5B3OCpagOU4b+CTq5akj8R8qWopI3Aav/AIE3PrqRnjrLJDKaFPl f7Ug5/b1p5zvpNm9ct2R/RDm0gHQ6gJmna+l7PVo3Mkotrn2VjtHX3z2hAYZWfQF5srH Src3eiHjPXmzikPU+82h/LFWCoKTNQBq+iQcwd/U0LZy1ZuYF8qbMwuMmsdTDOBUEqwt bkKA== X-Gm-Message-State: AOAM533L9IIHQBr/+kYu2ULnnIc5K0+tiMAoY7yCNY3FIuAxAc0NnNPH 4aNNlhwZzu4c3HvRjsxM8OXfkg== X-Google-Smtp-Source: ABdhPJzQa153E1Rkgt87UDJf1vE8rz6Hpi0RQZdQQDSXy+J5iH/wwvNOr9/UrScWq8FHFcEgYstltA== X-Received: by 2002:a05:6402:6c1:: with SMTP id n1mr2958666edy.215.1601381818107; Tue, 29 Sep 2020 05:16:58 -0700 (PDT) Received: from [192.168.1.7] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id r16sm5120171ejb.110.2020.09.29.05.16.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 05:16:57 -0700 (PDT) Subject: Re: [RESEND v3 2/4] venus: core: vote for video-mem path To: Mansur Alisha Shaik , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, swboyd@chromium.org References: <1601262496-27026-1-git-send-email-mansur@codeaurora.org> <1601262496-27026-3-git-send-email-mansur@codeaurora.org> From: Stanimir Varbanov Message-ID: <339d0c7e-a5ba-400d-e733-3ede8d20dc7f@linaro.org> Date: Tue, 29 Sep 2020 15:16:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1601262496-27026-3-git-send-email-mansur@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Mansur, On 9/28/20 6:08 AM, Mansur Alisha Shaik wrote: > Currently video driver is voting for venus0-ebi path during buffer > processing with an average bandwidth of all the instances and > unvoting during session release. > > While video streaming when we try to do XO-SD using the command > "echo mem > /sys/power/state command" , device is not entering > to suspend state and from interconnect summary seeing votes for venus0-ebi > > Corrected this by voting for venus0-ebi path in venus_runtime_resume() > and unvote during venus_runtime_suspend(). > > Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control") In fact all changes in this series are related to interconnect. The interconnect calls are moved to venus_runtime_suspend/resume by commit [1], that's why I think the Fixes: tag for all patches in this series should be [1]. [1] 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device suspend") > Signed-off-by: Mansur Alisha Shaik > Reviewed-by: Stephen Boyd > --- > drivers/media/platform/qcom/venus/core.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index 52a3886..fa363b8 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -363,7 +363,18 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev) > > ret = icc_set_bw(core->cpucfg_path, 0, 0); > if (ret) > - return ret; > + goto err_cpucfg_path; > + > + ret = icc_set_bw(core->video_path, 0, 0); > + if (ret) > + goto err_video_path; > + > + return ret; > + > +err_video_path: > + icc_set_bw(core->cpucfg_path, kbps_to_icc(1000), 0); > +err_cpucfg_path: > + pm_ops->core_power(dev, POWER_ON); > > return ret; > } > @@ -374,6 +385,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev) > const struct venus_pm_ops *pm_ops = core->pm_ops; > int ret; > > + ret = icc_set_bw(core->video_path, 0, kbps_to_icc(1000)); > + if (ret) > + return ret; > + > ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000)); > if (ret) > return ret; > -- regards, Stan