Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rudraksha Gupta <guptarud@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: qcom: msm8960: expressatt: Add Magnetometer
Date: Fri, 21 Nov 2025 13:54:22 +0100	[thread overview]
Message-ID: <340f121f-e217-40fd-9a84-68896d15fa65@oss.qualcomm.com> (raw)
In-Reply-To: <573b2293-7b39-4c68-a51b-ecd5b62b0ec1@gmail.com>

On 11/21/25 12:35 PM, Rudraksha Gupta wrote:
>>> +        iovdd-supply = <&pm8921_lvs4>;
>>> +
>>> +        // TODO: Figure out Mount Matrix
>> pmOS wiki has this:
>>
>> https://github.com/SiddharthManthan/accelerometer-mount-matrix-generator/blob/master/rotation_matrix.py
>>
>> but for accelerometers.. shouldn't be too different, I would assume
> 
> Unfortunately this seems to generate a broken matrix for me for the accelerometer. Downstream is also useless here as I believe Android does something slightly different.
> 
> I have been trying to upstream the pinephone pro's accelerometer and magnetometer as well ( https://lore.kernel.org/all/20250929-ppp_light_accel_mag_vol-down-v4-0-6598f22d3451@gmail.com/ ), but I'm just not sure if what I'm doing is right. I think the easiest solution for me right now is to get the screen working and use GUI programs to figure out if the mount matrix is right. If you have other suggestions, please let me know. I'm all ears.
> 
> But since I have your attention for now, I had a couple questions on trying to get the screen to work:
> 
> - The pipeline is MDP4 <-> DSI <-> Panel, right? Any information you can give me so that I can try to get this working faster?

Yes that's the pipeline

Unless the MDP4 driver is missing something (which it may as well, all
hw since ~2013 has moved on to MDP5/DPU), you should just be required to
come up with a panel driver (DSI init sequences, poking at regulators,
reset GPIO(s) etc.)

> - Is IOMMU broken? It seems like I can use APQ8064's implementation, but that's broken since at least 5.10. Should this be reported, and if so where?

I don't know, this platform uses its own arcane driver.. +Dmitry?
If you have a bug report, please send it to linux-arm-msm

> - I see Adreno 2xx, but seems like there is not Adreno 225 DTS compatible? Any insight here?

Adreno is a separate HW block, you can/should get software rendering to
work first

Konrad

  reply	other threads:[~2025-11-21 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  7:14 [PATCH 0/4] ARM: dts: qcom: msm8960: expressatt: Add more peripherals Rudraksha Gupta via B4 Relay
2025-11-20  7:14 ` [PATCH 1/4] ARM: dts: qcom: msm8960: expressatt: Add Light/Proximity Sensor Rudraksha Gupta via B4 Relay
2025-11-20  9:10   ` Konrad Dybcio
2025-11-21 11:27     ` Rudraksha Gupta
2025-11-20  7:14 ` [PATCH 2/4] ARM: dts: qcom: msm8960: expressatt: Add NFC Rudraksha Gupta via B4 Relay
2025-11-20  9:14   ` Konrad Dybcio
2025-11-20  7:14 ` [PATCH 3/4] ARM: dts: qcom: msm8960: expressatt: Add Magnetometer Rudraksha Gupta via B4 Relay
2025-11-20  9:14   ` Konrad Dybcio
2025-11-21 11:35     ` Rudraksha Gupta
2025-11-21 12:54       ` Konrad Dybcio [this message]
2025-11-21 13:11         ` Dmitry Baryshkov
2025-11-20  7:14 ` [PATCH 4/4] ARM: dts: qcom: msm8960: expressatt: Add Accelerometer Rudraksha Gupta via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=340f121f-e217-40fd-9a84-68896d15fa65@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=guptarud@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox