From: vivek pernamitta <vivek.pernamitta@oss.qualcomm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Manivannan Sadhasivam <mani@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 1/2] net: mhi: Enable Ethernet interface support
Date: Wed, 10 Dec 2025 12:00:25 +0530 [thread overview]
Message-ID: <3470cae3-d86c-4dd5-a24c-c7f4bf6e017a@oss.qualcomm.com> (raw)
In-Reply-To: <5a137b11-fa08-40b5-b4b4-79d10844a5b7@lunn.ch>
On 12/9/2025 7:06 PM, Andrew Lunn wrote:
>> ndev = alloc_netdev(sizeof(struct mhi_net_dev), info->netname,
>> - NET_NAME_PREDICTABLE, mhi_net_setup);
>> + NET_NAME_PREDICTABLE, info->ethernet_if ?
>> + mhi_ethernet_setup : mhi_net_setup);
>
> Is the name predictable? I thought "eth%d" was considered
> NET_NAME_ENUM?
>
> https://elixir.bootlin.com/linux/v6.18/source/net/ethernet/eth.c#L382
>
> Andrew
For Ethernet-type devices, the interface name will follow the standard
convention: eth%d, For normal IP interfaces, the interface will be
created as mhi_swip%d/mhi_hwip%d.The naming will depend on the details
provided through |struct mhi_device_info.|
next prev parent reply other threads:[~2025-12-10 6:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 11:25 [PATCH v6 0/2] net: mhi: Add support to enable ethernet interface Vivek Pernamitta
2025-12-09 11:25 ` [PATCH v6 1/2] net: mhi: Enable Ethernet interface support Vivek Pernamitta
2025-12-09 13:36 ` Andrew Lunn
2025-12-10 6:30 ` vivek pernamitta [this message]
[not found] ` <eaf79686-9fcb-4330-8017-83a4e4923985@oss.qualcomm.com>
2025-12-10 16:50 ` Andrew Lunn
2025-12-22 10:31 ` vivek pernamitta
2025-12-10 9:38 ` Jakub Kicinski
2025-12-22 10:43 ` vivek pernamitta
2025-12-24 6:08 ` Manivannan Sadhasivam
2025-12-09 11:25 ` [PATCH v6 2/2] bus: mhi: host: pci: Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for QDU100 Vivek Pernamitta
2025-12-10 9:39 ` Jakub Kicinski
2025-12-22 10:34 ` vivek pernamitta
2025-12-24 6:03 ` [PATCH v6 0/2] net: mhi: Add support to enable ethernet interface Manivannan Sadhasivam
2026-02-04 5:03 ` vivek pernamitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3470cae3-d86c-4dd5-a24c-c7f4bf6e017a@oss.qualcomm.com \
--to=vivek.pernamitta@oss.qualcomm.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox