From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Casey Connolly <casey.connolly@linaro.org>,
Alexander Martinz <amartinz@shiftphones.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED
Date: Wed, 1 Oct 2025 10:30:02 +0200 [thread overview]
Message-ID: <3483a7ba-7248-4358-b65f-356743648c92@oss.qualcomm.com> (raw)
In-Reply-To: <20250930-otter-further-bringup-v1-4-7fe66f653900@fairphone.com>
On 9/30/25 4:32 PM, Luca Weiss wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> Describe the flash LED on this phone.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index ce794ca724db6deb39f7fae47912c3fefe974573..36cc67469615974c193ea3a9db1b2362869d56bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -619,6 +619,19 @@ volume_down_default: volume-down-default-state {
> };
> };
>
> +&pm8350c_flash {
> + status = "okay";
> +
> + led-0 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>, <2>;
> + led-max-microamp = <500000>;
> + flash-max-microamp = <1500000>;
> + flash-max-timeout-us = <1280000>;
> + };
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-10-01 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 14:32 [PATCH 0/6] Further bringup of SHIFTphone 8 Luca Weiss
2025-09-30 14:32 ` [PATCH 1/6] arm64: dts: qcom: qcm6490-shift-otter: Fix sorting and indentation Luca Weiss
2025-10-01 8:24 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 2/6] arm64: dts: qcom: qcm6490-shift-otter: Remove thermal zone polling delays Luca Weiss
2025-10-01 8:26 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 3/6] arm64: dts: qcom: qcm6490-shift-otter: Add missing reserved-memory Luca Weiss
2025-10-01 8:27 ` Konrad Dybcio
2025-09-30 14:32 ` [PATCH 4/6] arm64: dts: qcom: qcm6490-shift-otter: Enable flash LED Luca Weiss
2025-10-01 8:30 ` Konrad Dybcio [this message]
2025-10-22 15:23 ` Pavel Machek
2025-09-30 14:32 ` [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED Luca Weiss
2025-10-01 8:29 ` Konrad Dybcio
2025-10-01 8:30 ` Luca Weiss
2025-10-01 8:37 ` Konrad Dybcio
2025-10-22 15:24 ` Pavel Machek
2025-09-30 14:32 ` [PATCH 6/6] arm64: dts: qcom: qcm6490-shift-otter: Enable venus node Luca Weiss
2025-10-01 8:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3483a7ba-7248-4358-b65f-356743648c92@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amartinz@shiftphones.com \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox