From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71C50208997 for ; Fri, 25 Apr 2025 21:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745617761; cv=none; b=Ne58PQj4OomXhmPA/bNiajY9sDfy0aj4Jm2iyw5xY9YlKFrt1PWId9NkDyA65BnPTdTkmwZTmkZXbdANMuLcl/zqfjtVhXvyzCrgd9LxwfXe41ma6XFeHrUGcuH9cG5DBkoEvXowJOkjeRNrDsHv5qkQEnOHjdwGA7nMr8N/PjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745617761; c=relaxed/simple; bh=jozrC8ALKXE/Sx+4V/NhfP3zJRrKkx5q5cBTgMlYmb4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fJboxzZ/7+y0/yWiw7Asv7mQMwAZvyoIpM5a7hFQQDmvPu3gbD/fQrizvunwbGa0jvsm1jjHMkSaP66iWFTx5XuHWyPlrdxO1H++qlFgCa4KMwhbYX/S7jWY23bKuS5CBoFey0zFQ39PcVzSGSjVUrmweWnVN64aWHu6mgEP+Es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R3KCzmNr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R3KCzmNr" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PGKC6u001690 for ; Fri, 25 Apr 2025 21:49:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pqttNioS7MEhlEyeR5tyyWNtOjjWlwl8TrfEkoHr4Ds=; b=R3KCzmNrXjv4yB1Z NAY+Pru2HGVjfLGDRtTjnQZYCg+hBPXnfDnlT7JhozGnoNvo/siglLBK8wnt+aF/ 0KmPZVYhmVga2eHmC7olyotc9QHU3t/ODGRBFguIk+fePalCNdFnuws2otaalWiX qv9R3a5FFaPLGLBLXEGwLNTVjjyjPb76Dv2QhiozWND0xQz9voJaI25vLAwHPKRC Huj2IKWwMl2oGjF88APbuBlHS/QJc2joLAnUDeXbPvmGWvUhtL2jA+cUJIjLFewO lm2/Zt648e2HZbFbs0T6z+jEW+m70vWOt3zP2fCi07a8BTKYBQU2hsEmIlY3tw6p 7dPNng== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh3jb01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Apr 2025 21:49:18 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-478f933cb4bso1605841cf.3 for ; Fri, 25 Apr 2025 14:49:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745617757; x=1746222557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pqttNioS7MEhlEyeR5tyyWNtOjjWlwl8TrfEkoHr4Ds=; b=LlqJWTkWUrZ7szfU5jRqF9J/G4wlQa2R/sDech+CElTensxLb6QGvWrVsfKJFvh8fA PJL1NRj4HZUIoAa5DZfPDfrIbLph9WcPCy69PRtRU6l0ufjhmmSLGmbmiVygdZsFTyBV X4piAkIw9IXmxJNRsu+EvNDi48G0LjNMhq0xTRize0Mz1riq3+WRXMkRcr497+y1RNv/ hfmaPrTe2ikCqRoQrgjFafqbRgRWdpS9ccHH2mT/HdCS25I1txFAbrL7jj6uaism+hMH ab7Fa/p3AKnZTbawoThB0rji99zx4Zra8S5sWEq9hvEWo8MtMVZ/jqSZvoxAdL4f9u3Q qRBA== X-Gm-Message-State: AOJu0Yz3sgoBgilq7mCnpEnLszOFemlv+OePQOI9z6oIWpAFpKtZmELy ORBxLXTpsO7Cox9JYLYac6kjOB0ecmkoUT23Mkrvd096A2VZEjgFORF4Q0I0Bv+BtgEqlTHiC0f kdB6gtPpBVnsOvksS0UUdUSvVYhk0oZlhbroL9NrjnpwlAfR6h57i375c40WE35dB X-Gm-Gg: ASbGncu51yQ71abNs0FKbabKkvSZlgfCpI67yHLagiBzGstiulm+2eP29LJq/h2U1hq wDyi5qVJdIRW+sWzVrEkjti1zczQdgXsXALmMYBzNI4/ZFTFyStF7yOh7es2IX3SnsJv4OZpK5V ImFACH/HkkvR+L2F8xKulP4fo5ycFVYQTU/vWeWYHNH6SI+tlo59X0ANMKRrMIQqaVquWUJ3yV0 DC8hwk3xW6o4zsUxV+3wtdoG0IpV3e3LrrmxT7w+R/PT02KtwxEfpvfVnNMd+1iBbQ6Yut4cTsN KWjbTPZyyjIAohYShnxetyOzGFoAy0De/NLGeAniEN1TB3de1g5prHZaW3uu8XUFmU4= X-Received: by 2002:ac8:5f8c:0:b0:474:f601:c21e with SMTP id d75a77b69052e-4801c9843damr22042671cf.5.1745617757157; Fri, 25 Apr 2025 14:49:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJCIrI78Ob/2klFmqnEr49+IpnLEJ2W1gl5FH3vfPAl6chnS3piYqnr6Wnwi9TWiuuQ4mecg== X-Received: by 2002:ac8:5f8c:0:b0:474:f601:c21e with SMTP id d75a77b69052e-4801c9843damr22042591cf.5.1745617756834; Fri, 25 Apr 2025 14:49:16 -0700 (PDT) Received: from [192.168.65.156] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6e5963fesm194044266b.81.2025.04.25.14.49.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 14:49:16 -0700 (PDT) Message-ID: <3498cfda-a738-449d-9d9f-754bbc8125c2@oss.qualcomm.com> Date: Fri, 25 Apr 2025 23:49:14 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: sm8650: add iris DT node To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20250424-topic-sm8x50-upstream-iris-8650-dt-v2-1-dd9108bf587f@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250424-topic-sm8x50-upstream-iris-8650-dt-v2-1-dd9108bf587f@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9rh0siO1gA1rmHiV17UalbOBnoPZW2q_ X-Proofpoint-GUID: 9rh0siO1gA1rmHiV17UalbOBnoPZW2q_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDE1NyBTYWx0ZWRfXxv/0/8Mtllbn 9DGnxo7PkQEqQwrwW7TmJuoGPzsOv3HPGebMxs7/hjYWWF/jbS4cn9HvwxdyTK1nEKu4gYYiQwV DA8mmSdcXNtt/+4l9upddO9cEh81moyuhG3yNpBNXdBsVKHTkzKsiKt6zBxCkbLwTygr01OFUmf 1QGu91VMh419/i7TjFAPlicg3QGog5p1Mvot84ALmgVD/f5viFEXDDBkZBTMWavxyfUvxOxVic0 xk/F97sv748J1/MfuItAuvpZeAHy9ze+F8xgHZ907gKpW0C3Zyi3/fEjp1UGhEpMYbjyTb0lMpJ 7dMeLNIfLY6Cj0hAr3iWwwt8W9KB/ke1kk49m8sqT949b3GsRk1Q8pGuU1W9hfpIoXmFi2xrKQE y3d0HVESt3zjdqDpYTxNYZouOg3SJ+Cpb5/gERkgRTCyLfqtL14EsL73QYgZ2NibeLiLMtll X-Authority-Analysis: v=2.4 cv=Mepsu4/f c=1 sm=1 tr=0 ts=680c035e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=MuPQQqiwDrxPnYpOdO4A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_07,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504250157 On 4/24/25 6:32 PM, Neil Armstrong wrote: > Add DT entries for the sm8650 iris decoder. > > Since the firmware is required to be signed, only enable > on Qualcomm development boards where the firmware is > available. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong > --- > Changes in v2: > - removed useless firmware-name > - Link to v1: https://lore.kernel.org/r/20250418-topic-sm8x50-upstream-iris-8650-dt-v1-1-80a6ae50bf10@linaro.org > --- [...] > + iris: video-codec@aa00000 { > + compatible = "qcom,sm8650-iris"; > + reg = <0 0x0aa00000 0 0xf0000>; > + > + interrupts = ; > + > + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, > + <&videocc VIDEO_CC_MVS0_GDSC>, > + <&rpmhpd RPMHPD_MXC>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names = "venus", > + "vcodec0", > + "mxc", > + "mmcx"; > + > + operating-points-v2 = <&iris_opp_table>; > + > + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > + <&videocc VIDEO_CC_MVS0C_CLK>, > + <&videocc VIDEO_CC_MVS0_CLK>; > + clock-names = "iface", > + "core", > + "vcodec0_core"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "cpu-cfg", > + "video-mem"; > + > + /* FW load region */ I don't think this comment brings value > + memory-region = <&video_mem>; > + > + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>, > + <&videocc VIDEO_CC_XO_CLK_ARES>, > + <&videocc VIDEO_CC_MVS0C_CLK_ARES>; > + reset-names = "bus", > + "xo", > + "core"; > + > + iommus = <&apps_smmu 0x1940 0>, > + <&apps_smmu 0x1947 0>; I think you may also need 0x1942 0x0 (please also make the second value / SMR mask hex)> + > + dma-coherent; > + > + /* > + * IRIS firmware is signed by vendors, only > + * enable in boards where the proper signed firmware > + * is available. > + */ Here's to another angry media article :( Please keep Iris enabled.. Vikash reassured me this is not an issue until the user attempts to use the decoder [1], and reading the code myself I come to the same conclusion (though I haven't given it a smoke test - please do that yourself, as you seem to have a better set up with these platforms). If the userland is sane, it should throw an error and defer to CPU decoding. This is >>unlike venus<< which if lacking firmware at probe (i.e. boot) would prevent .sync_state [1] https://lore.kernel.org/linux-arm-msm/98a35a51-6351-5ebb-4207-0004e89682eb@quicinc.com/ [...] > + > + opp-480000000 { > + opp-hz = /bits/ 64 <480000000>; > + required-opps = <&rpmhpd_opp_turbo>, > + <&rpmhpd_opp_turbo>; nom (nom nom nom nom nom) > + }; > + > + opp-533333334 { > + opp-hz = /bits/ 64 <533333334>; > + required-opps = <&rpmhpd_opp_turbo_l1>, > + <&rpmhpd_opp_turbo_l1>; turbo Konrad