From: Konrad Dybcio <konradybcio@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null check on pdev
Date: Tue, 12 Nov 2024 16:28:19 +0100 [thread overview]
Message-ID: <34bc44c2-e1d2-4610-8a87-f20078592e7e@gmail.com> (raw)
In-Reply-To: <20241112132005.469357-1-colin.i.king@gmail.com>
On 11/12/24 14:20, Colin Ian King wrote:
> The pointer config is dereferencing pointer pdev before pdev is null
> checked, this could lead to a potential null pointer dereference on pdev.
> Fix this by only assinging config after pdev has been null checked.
>
> Fixes: 736a93273656 ("drm/msm/a5xx: really check for A510 in a5xx_gpu_init")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
I'd rather drop this check, the only call chain is rather
safe here
Konrad
prev parent reply other threads:[~2024-11-12 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 13:20 [PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null check on pdev Colin Ian King
2024-11-12 15:28 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34bc44c2-e1d2-4610-8a87-f20078592e7e@gmail.com \
--to=konradybcio@gmail.com \
--cc=airlied@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox