From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for interrupt-names
Date: Mon, 27 May 2024 18:29:22 +0200 [thread overview]
Message-ID: <35d68e6b-c821-4ebd-96f6-33f09fa04f1b@kernel.org> (raw)
In-Reply-To: <CAMRc=McDRpwvTbVZVmzT45zjrZN+ZxYP8_9QVTScZCew+fboMg@mail.gmail.com>
On 27/05/2024 17:33, Bartosz Golaszewski wrote:
> On Mon, May 27, 2024 at 5:13 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 27/05/2024 16:45, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> There's a set of compatibles for which we set a strict list of 5 interrupt
>>> names even though minItems for the interrupts property is 4. One of the
>>> USB controllers on sa8775p only consumes 4 interrupts which leads to
>>> dtbs_check errors. Make the last entry optional by setting minItems to 4.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Can you also fix other cases? I found there at least two other. I missed
>> that during review... or maybe we discussed it? I remember that commit
>> was a pain :/
>>
>
> I can put that on my TODO list but I really have too much on my plate
> ATM. I propose this be picked up separately.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-27 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 14:45 [PATCH] dt-bindings: usb: qcom,dwc3: set minItems for interrupt-names Bartosz Golaszewski
2024-05-27 15:13 ` Krzysztof Kozlowski
2024-05-27 15:33 ` Bartosz Golaszewski
2024-05-27 16:29 ` Krzysztof Kozlowski [this message]
2024-06-04 10:51 ` Johan Hovold
2024-06-04 6:52 ` Bartosz Golaszewski
2024-06-04 10:52 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d68e6b-c821-4ebd-96f6-33f09fa04f1b@kernel.org \
--to=krzk@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox