Re: [PATCH v2 1/3] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Glymur SoC

[Georgi Djakov <djakov@kernel.org>]

On 8/19/25 7:03 PM, Krzysztof Kozlowski wrote:
> On 19/08/2025 15:46, Georgi Djakov wrote:
>> On 8/19/25 4:31 PM, Rob Herring wrote:
>>> On Thu, Aug 14, 2025 at 9:54 AM Raviteja Laggyshetty
>>> <raviteja.laggyshetty@oss.qualcomm.com> wrote:
>>>>
>>>> Document the RPMh Network-On-Chip Interconnect in Glymur platform.
>>>>
>>>> Co-developed-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
>>>> Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
>>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
>>>> ---
>>>>    .../bindings/interconnect/qcom,glymur-rpmh.yaml    | 172 +++++++++++++++++
>>>>    .../dt-bindings/interconnect/qcom,glymur-rpmh.h    | 205 +++++++++++++++++++++
>>>>    2 files changed, 377 insertions(+)
>>>
>>> This is breaking linux-next "make dt_binding_check". Looks like the
>>> clock header dependency in the example is not applied. Please drop
>>> this until the dependency is there.
>>
>> Thanks! And now i see why my script didn't catch this... now fixed and
>> patch dropped.
> 
> What are you using to apply patches? Because b4 would pull all
> dependencies, which would brake your branch as well, but at least you
> would see something odd happening here.

I am using b4, but in cherry-pick mode, so i just pipe the current email to
it. And i also noticed the prerequisite-change-id lines and the dependency
on gcc, but my local scripts (that do all kinds of checks) passed, because
of a bug that didn't properly log the dt_binding_check error, so i thought
the dependency is there. I recently modified it to run with not just the
DT_SCHEMA_FILES="Documentation/devicetree/bindings/interconnect/" but with
a few more schemas and very likely i introduced the logging bug at that time.

Thanks,
Georgi