From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DFBCE79A8 for ; Tue, 19 Sep 2023 21:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233278AbjISVDG (ORCPT ); Tue, 19 Sep 2023 17:03:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233304AbjISVDG (ORCPT ); Tue, 19 Sep 2023 17:03:06 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71B97B3 for ; Tue, 19 Sep 2023 14:03:00 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-501bd6f7d11so10309409e87.1 for ; Tue, 19 Sep 2023 14:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695157378; x=1695762178; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CkfWxT6lfF9Ia8taCV57X5Sx4DgFIC2eOwDKvIcY1ZQ=; b=PX3EXe9v/Y+TABtDVf31UsjX7uSLGYyl+PrMBN2RBhetQ4ZaLMjITGso4eoL6mtOQ3 +3hEqoICdlX9+LImtnSlMw+aOGLwk3+5IJMGhH9k40GJleOhLJS203I8m1Had4M/fzjP rJlrktQkiTT06S5F0a2P+lwvyB1qjDvsKn5ri5HiDk7TUJ/P3jCdwbvNDbmW/J3aRj/f 6gTIVlI/OJZcdzLRCrAcXsOAvNdGgOwBhHV629Y+ojH4TbKFdVk3tlCoO9f4JtntHXMe DO1PDFOBx3xN83EWqU6Bs9igsJ6W81++Gb7cpSaslAxu0Mtzr6M+TVNYi08d7/9g6e+V S3Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695157378; x=1695762178; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CkfWxT6lfF9Ia8taCV57X5Sx4DgFIC2eOwDKvIcY1ZQ=; b=ddon682RQtrAxMQYCidpZu/jJqkQdDlqtFPBlOBMmKmXG+d2XvvU7DE0Go49ZPwZJs /t5VIwz/8wrVyHFJ8snIzY2TzjHCykVl2iSOtENwXTCYGr9fU5WoP8Ug5Pqfzgoy/zjy C8ZneT5GunCubMDfo7sum7ag6CHZonO5Ys95jl6uixovag+9tBhrM/yS/OkrwZMaFWoN Osa0xHffPuKNee42QU9Mwo8altQCoUivUPBuO+9ZXHcws42mulcd5rJXwdw11rzrBQNc TRCOz9hz4EE9+hGkpCNi4p13PrmxbaKOgJ7A5ZpbtwOMUaGyJMq2Gl+5EzhY8xW0NFEf IRBA== X-Gm-Message-State: AOJu0YyMr11H5cpZkG3/hBrGcLsodUfzjnLF28rrYHl82iQwtkDdU57Q /3Q0QQAo+v2GzMaWhSOQYFducQ== X-Google-Smtp-Source: AGHT+IHe+WAuxmq7/z2dNqLJ2lJwsnpQ9WIa0o31Rv1Kgj2hU/G9drguSW4AcBUqIPtCxizw88o1rg== X-Received: by 2002:a05:6512:470:b0:4fd:d08c:fa3e with SMTP id x16-20020a056512047000b004fdd08cfa3emr606762lfd.42.1695157378512; Tue, 19 Sep 2023 14:02:58 -0700 (PDT) Received: from [172.25.80.155] ([217.67.225.27]) by smtp.gmail.com with ESMTPSA id c11-20020a056402120b00b005232c051605sm7848240edw.19.2023.09.19.14.02.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 14:02:58 -0700 (PDT) Message-ID: <36a51519-2755-20ff-c2af-770d87d7cdf1@linaro.org> Date: Tue, 19 Sep 2023 23:02:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 36/59] dma: qcom: qcom_adm: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Vinod Koul Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, kernel@pengutronix.de References: <20230919133207.1400430-1-u.kleine-koenig@pengutronix.de> <20230919133207.1400430-37-u.kleine-koenig@pengutronix.de> From: Konrad Dybcio In-Reply-To: <20230919133207.1400430-37-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9/19/23 15:31, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Konrad Dybcio Konrad