From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Slark Xiao <slark_xiao@163.com>,
<manivannan.sadhasivam@linaro.org>, <loic.poulain@linaro.org>,
<ryazanov.s.a@gmail.com>, <johannes@sipsolutions.net>
Cc: <netdev@vger.kernel.org>, <mhi@lists.linux.dev>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] bus: mhi: host: Add name for mhi_controller
Date: Mon, 1 Jul 2024 09:13:50 -0600 [thread overview]
Message-ID: <36b8cdab-28d5-451f-8ca3-7c9c8b02b5b2@quicinc.com> (raw)
In-Reply-To: <20240701021216.17734-2-slark_xiao@163.com>
On 6/30/2024 8:12 PM, Slark Xiao wrote:
> For SDX72 MBIM mode, it starts data mux id from 112 instead of 0.
> This would lead to device can't ping outside successfully.
> Also MBIM side would report "bad packet session (112)".In order to
> fix this issue, we decide to use the device name of MHI controller
> to do a match in client driver side. Then client driver could set
> a corresponding mux_id value for this MHI product.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> +++ b/include/linux/mhi.h
> @@ -289,6 +289,7 @@ struct mhi_controller_config {
> };
>
> /**
> + * @name: device name of the MHI controller
This needs to be below the next line
> * struct mhi_controller - Master MHI controller structure
> * @cntrl_dev: Pointer to the struct device of physical bus acting as the MHI
> * controller (required)
> @@ -367,6 +368,7 @@ struct mhi_controller_config {
> * they can be populated depending on the usecase.
> */
> struct mhi_controller {
> + const char *name;
> struct device *cntrl_dev;
> struct mhi_device *mhi_dev;
> struct dentry *debugfs_dentry;
next prev parent reply other threads:[~2024-07-01 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 2:12 [PATCH v4 1/3] bus: mhi: host: Add Foxconn SDX72 related support Slark Xiao
2024-07-01 2:12 ` [PATCH v4 2/3] bus: mhi: host: Add name for mhi_controller Slark Xiao
2024-07-01 15:13 ` Jeffrey Hugo [this message]
2024-07-01 16:27 ` Manivannan Sadhasivam
2024-07-02 6:36 ` Slark Xiao
2024-07-03 13:46 ` Manivannan Sadhasivam
2024-07-01 2:12 ` [PATCH v4 3/3] net: wwan: mhi: make default data link id configurable Slark Xiao
2024-07-01 21:28 ` Jakub Kicinski
2024-07-03 13:46 ` Manivannan Sadhasivam
2024-07-01 16:25 ` [PATCH v4 1/3] bus: mhi: host: Add Foxconn SDX72 related support Manivannan Sadhasivam
2024-07-02 6:34 ` Slark Xiao
2024-07-03 13:28 ` Manivannan Sadhasivam
2024-07-03 13:44 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b8cdab-28d5-451f-8ca3-7c9c8b02b5b2@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox