From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8351D1D545 for ; Mon, 22 Apr 2024 22:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713825842; cv=none; b=clOHH2TVTkEPj0CoILqQ88GgvDx2dB7TyxaABbgK9Zt7J4RgHu8Yjl+f2zCEE7Ii2gwlSXNRZvlP2IJ95CRe0HDxFBKdvyE03zbHimISAj+j6eFQ21A9GFCUi7bnmdKdq5RgoCnvB91ttIrk51m00mV3vnsGMwyyqLle7qqaB2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713825842; c=relaxed/simple; bh=ElqV9w5egMCE1fLprf67vgUULGRpUkv5I3l3AQ4IKSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sNIofSu2LNjyRZVadk5iH1FVieNwtbPJyaVPqLnUQoyQ05QNBupd0iMED3f+nVbvuYycBPKGzuRx0msFA6+c9rt/WDntIu8q1yrY0rkTRrOEusktOPCJM2T1nCz/8F6cUNMZnLzw9dZdmMK3dRMWqhr2eNGBr/97yC0oFAtGuu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q3vVhk/X; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q3vVhk/X" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5171a529224so6318371e87.0 for ; Mon, 22 Apr 2024 15:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713825839; x=1714430639; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oofEEwMcsUFGHCf9AB7GLQjS3HSrYP8XWX7NSP6yUuo=; b=Q3vVhk/XIpb/nc7rFNSB35G2q1LVjx8Br2L+5m0HkikLZqUD5Nkr80oxo5n9DNTlgN Om10dKKjSL7adi4WvD5q3elvUkPz8cxk6nZHTfcopnNNi7wmzesNCcMhT+DvNw3wyl29 ruejLgcbIszDW3Zq0KlrWTaGK1P3tNVARyRiD/L96sS/lI3IOYdgWTZZKKDSqsaSQCOJ fdpQxebLNE1nJEzxYIJXLApLnGKviURwCFd4jG60XWGob0dSuHk3SedURqI8BuOnlPYY oj8DEhHEBPZkS0vdCc6ZTvCX+GzZ+vdIzbdR8xy21TRXmQejhXeG2DcLMs37O8+aIbFX wyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713825839; x=1714430639; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oofEEwMcsUFGHCf9AB7GLQjS3HSrYP8XWX7NSP6yUuo=; b=Mz5GwAEaN8kJysIFdJqj+at21PhGYzqMOSoyynkAjfHxkgiqluXyFjFBK4VNi4M8sW iDpX8ekxZ/i5QNQlWSMv4dpS6KMy1N85u4mO3OCLlkiibjxsXIdwRvvHKltpgAAgv5+n rUcIStPcI/7Gk68P9pxQJGF3xZdzwuEnQqulrcN82ZNJzkdmmYtHNkzsaJ5oJT51PUWd yMUBuV20eSy1AxZTwz4s7VX4eIFRSAspxfbUuSOvkyn5EbFh6vjHZGCCeIBXKka8xuI/ u9/zTs+rFaF8IGGlSxZIV0udP3ujEXPTyYrSnSdX+q68tA0b6qu9vLVLVueHbQVkM61i ixeA== X-Forwarded-Encrypted: i=1; AJvYcCUmWNVKzhenpSoFICbjQ0xo1x2h+xfLhweTptLMGfyKyCq2+6zzWk74bRK8Y+3DnK84ZsOzBkQl7UQ3DprXpm5IUsTOlHmcmvKGahp4VA== X-Gm-Message-State: AOJu0YxBW2uPZhfK24rY+qflxn3vSSYHBwjSmWljkjrR2lK81bn873LV 5qqSjmJLQY0hhiVTRFKddeWdpd9D/sWc7+CaLX3AURbs+VY1JVeRXwZCno//fzE= X-Google-Smtp-Source: AGHT+IFzzCNXoiQoP0c4aV9kGALB2szkveofYw8qjvKgw34NGG2nJIGXaItXvP9QnYff9kIfwriZpQ== X-Received: by 2002:a05:6512:b8b:b0:515:bbe9:f208 with SMTP id b11-20020a0565120b8b00b00515bbe9f208mr8463038lfv.19.1713825838785; Mon, 22 Apr 2024 15:43:58 -0700 (PDT) Received: from [172.30.204.103] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id m7-20020a056512358700b005175dab1cfdsm1833414lfr.257.2024.04.22.15.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 15:43:58 -0700 (PDT) Message-ID: <36f33797-22d9-433c-9b5f-df8488191f3a@linaro.org> Date: Tue, 23 Apr 2024 00:43:55 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator To: Luca Weiss , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Fenglin Wu Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240418-fp3-vibra-v1-0-b636b8b3ff32@fairphone.com> <20240418-fp3-vibra-v1-1-b636b8b3ff32@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/18/24 12:03, Luca Weiss wrote: > On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: >> On 18.04.2024 8:36 AM, Luca Weiss wrote: >>> Add a node for the vibrator module found inside the PMI632. >>> >>> Signed-off-by: Luca Weiss >>> --- >> >> Reviewed-by: Konrad Dybcio >> >> On a side note, this is a totally configuration-free peripheral that doesn't do >> anything crazy until manually configured. >> >> In the slow quest to be (hopefully) more sane about the defaults, should we keep >> them enabled by default? Bjorn? > > But many (most?) devices don't have a vibration motor connected to > PMI632, some (like devboards) don't have anything, and other phones have > a separate chip that controls the vibration motor. > > Enabling this by default would mean all devices with PMI632 would get an > input device for the vibrator that probably doesn't work? Fair Konrad