From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6931940B1; Tue, 26 Nov 2024 07:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732606860; cv=none; b=YS3kRqGEvxHzqIcLsQkcLPFwvbuMu15L9yi1+OMJw52MUBI5FukraCCKTZJ3Lk7lYjxovC/fP415BwBie8YHrSJZ1IndhXbYQDA+kKcE83zCAuZojJ0mIVOGB8gC+mWcVm98kfeJQ93RaQu4qGVEZ4y60Ha8rdw7bycMfn8vK1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732606860; c=relaxed/simple; bh=j6DDMD1mwtZuyEBtg5yeJypXdVy0cFA7GiviiEotRLo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IaDwP3a/j2PPHXKmOf4GpK3CJFAELqBcIoIw8lryi6hToHXgT5uLStqLNVa8C8zfcEMZ1VUA5OS7EeWwKCBJ4956g+0FFAT+KneHxptPPr++IwRcNkvfY6DL9VHzIlKgupc+lMPMAiMv8/kddxwHu73UPPmgXRgUQyO0UIds6Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=IPxQME9m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="IPxQME9m" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4APK3kEq017784; Tue, 26 Nov 2024 07:40:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tV2SeT/Vv75C92ptkNu2BNJmCrW+QJhXeUY3M9F0/RI=; b=IPxQME9miqaGYvZt ysYqi6JIdDedbnp89UUURH2tugKzHb763O54DS3Tqj/Q8F5KBjH9MQNBPt/I2qP0 tR+stTm6JoPhmFlSYXIi9UGCc9CFZLYdih4XvO7/29PE3KQWWiDDiz9i1Yx9Sodh dEHvLalFfh3kcd6giqBiRNTnzHKRW/iAx3tJ+FiTJuNHNoHrsg4diPt8rDOUm0pP LZTgW7RewSfSF4QOXUwMecxhf5nvWOTNbMq6UH5ljAaJkbZAMWLE+iyM5OSiZHiR rhwwnvLgW0aPmBXrsEqPambLJd4LR7EtyO7IWRIytzMXfcal2A0HiNqeL6f8VOdZ xl5SZg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 433dny6qxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 07:40:54 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AQ7errd030530 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 07:40:53 GMT Received: from [10.231.216.103] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 25 Nov 2024 23:40:50 -0800 Message-ID: <36fdb3d7-fd48-43a9-a392-336038db71a2@quicinc.com> Date: Tue, 26 Nov 2024 15:40:47 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] media: venus: core: add qcs615 platform data To: Dmitry Baryshkov CC: Stanimir Varbanov , "Vikash Garodia (QUIC)" , "bryan.odonoghue@linaro.org" , Mauro Carvalho Chehab , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Bjorn Andersson , "Konrad Dybcio" , "linux-media@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , References: <20241125-add-venus-for-qcs615-v3-0-5a376b97a68e@quicinc.com> <20241125-add-venus-for-qcs615-v3-2-5a376b97a68e@quicinc.com> Content-Language: en-US From: Renjiang Han In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: h9wASKNnklYvRaopNhKxfme74s5WelL8 X-Proofpoint-ORIG-GUID: h9wASKNnklYvRaopNhKxfme74s5WelL8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411260060 On 11/26/2024 12:20 AM, Dmitry Baryshkov wrote: > On Mon, Nov 25, 2024 at 03:34:19PM +0000, Renjiang Han (QUIC) wrote: >> On Monday, November 25, 2024 9:36 PM, Dmitry Baryshkov wrote: >>> On Mon, Nov 25, 2024 at 11:04:50AM +0530, Renjiang Han wrote: >>>> Initialize the platform data and enable venus driver probe of QCS615 >>>> SoC. >>>> >>>> Signed-off-by: Renjiang Han > >>>> --- >>>> drivers/media/platform/qcom/venus/core.c | 50 >>>> ++++++++++++++++++++++++++++++++ >>>> 1 file changed, 50 insertions(+) >>>> >>>> diff --git a/drivers/media/platform/qcom/venus/core.c >>>> b/drivers/media/platform/qcom/venus/core.c >>>> index >>>> 423deb5e94dcb193974da23f9bd2d905bfeab2d9..39d8bcf62fe4f72674746b75994c >>>> ce6cbaee94eb 100644 >>>> --- a/drivers/media/platform/qcom/venus/core.c >>>> +++ b/drivers/media/platform/qcom/venus/core.c >>>> @@ -630,6 +630,55 @@ static const struct venus_resources msm8998_res = { >>>> .fwname = "qcom/venus-4.4/venus.mbn", }; >>>> >>>> +static const struct freq_tbl qcs615_freq_table[] = { >>>> + { 0, 460000000 }, >>>> + { 0, 410000000 }, >>>> + { 0, 380000000 }, >>>> + { 0, 300000000 }, >>>> + { 0, 240000000 }, >>>> + { 0, 133333333 }, >>>> +}; >>>> + >>>> +static const struct bw_tbl qcs615_bw_table_enc[] = { >>>> + { 972000, 951000, 0, 1434000, 0 }, /* 3840x2160@30 */ >>>> + { 489600, 723000, 0, 973000, 0 }, /* 1920x1080@60 */ >>>> + { 244800, 370000, 0, 495000, 0 }, /* 1920x1080@30 */ >>>> +}; >>>> + >>>> +static const struct bw_tbl qcs615_bw_table_dec[] = { >>>> + { 1036800, 1987000, 0, 2797000, 0 }, /* 4096x2160@30 */ >>>> + { 489600, 1040000, 0, 1298000, 0 }, /* 1920x1080@60 */ >>>> + { 244800, 530000, 0, 659000, 0 }, /* 1920x1080@30 */ >>>> +}; >>>> + >>>> +static const struct venus_resources qcs615_res = { >>>> + .freq_tbl = qcs615_freq_table, >>>> + .freq_tbl_size = ARRAY_SIZE(qcs615_freq_table), >>>> + .bw_tbl_enc = qcs615_bw_table_enc, >>>> + .bw_tbl_enc_size = ARRAY_SIZE(qcs615_bw_table_enc), >>>> + .bw_tbl_dec = qcs615_bw_table_dec, >>>> + .bw_tbl_dec_size = ARRAY_SIZE(qcs615_bw_table_dec), >>>> + .clks = {"core", "iface", "bus" }, >>>> + .clks_num = 3, >>>> + .vcodec0_clks = { "vcodec0_core", "vcodec0_bus" }, >>>> + .vcodec_clks_num = 2, >>>> + .vcodec_pmdomains = (const char *[]) { "venus", "vcodec0" }, >>>> + .vcodec_pmdomains_num = 2, >>>> + .opp_pmdomain = (const char *[]) { "cx" }, >>>> + .vcodec_num = 1, >>>> + .hfi_version = HFI_VERSION_4XX, >>>> + .vpu_version = VPU_VERSION_AR50, >>>> + .vmem_id = VIDC_RESOURCE_NONE, >>>> + .vmem_size = 0, >>>> + .vmem_addr = 0, >>>> + .dma_mask = 0xe0000000 - 1, >>>> + .cp_start = 0, >>>> + .cp_size = 0x70800000, >>>> + .cp_nonpixel_start = 0x1000000, >>>> + .cp_nonpixel_size = 0x24800000, >>>> + .fwname = "qcom/venus-5.4/venus_s6.mbn", >>> I really want the firmware discussion of linux-firmware to be solved first, >>> before we land this patch. >>> SHort summary: can we use a single image for all 5.4 platforms (by using >>> v5 signatures, by using v6 signatures, v3 or any other kind of quirk). >> Thanks for your comment. We have discussed with the firmware team and >> other teams if we can use the same firmware binary. The result is we'd better >> use different firmware files. They should respond in the firmware binary >> thread. I will push them and hope them respond as quickly as possible and >> give reasons. >>>> +}; >>>> + >>>> static const struct freq_tbl sdm660_freq_table[] = { >>>> { 979200, 518400000 }, >>>> { 489600, 441600000 }, >>>> @@ -937,6 +986,7 @@ static const struct of_device_id venus_dt_match[] = { >>>> { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, }, >>>> { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, }, >>>> { .compatible = "qcom,msm8998-venus", .data = &msm8998_res, }, >>>> + { .compatible = "qcom,qcs615-venus", .data = &qcs615_res, }, >>> The hardware seems to be the same as sc7180, only the frequencies differ. >>> Can we change the driver in a way that we don't have to add another >>> compat entry just for the sake of changing freqs / bandwidths? >> Thank you for your comment. I agree with you. But based on the Venus code >> architecturE ANd the distinction between different platforms, I think the >> current changes are the simplest. > Well, it is simplest, correct. But not the best one. There is no plan no > migrate these platforms to the iris driver. So instead, please improve > the venus driver instead of just pushing the simplest change. I should > have been more explicit about it earlier. Based on the current code architecture, I don't know if there is a better way. If we refactor the code, it will take a lot of effort. Therefore, I submit this change. Do you have a better approach? Also, the driver architecture of iris is implemented as you said. >>>> { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, }, >>>> { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, }, >>>> { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, }, >>>> >>>> -- >>>> 2.34.1 >>>> >>> -- >>> With best wishes >>> Dmitry -- Best Regards, Renjiang