From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from box.trvn.ru (box.trvn.ru [45.141.101.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6789A3ACA6B; Wed, 21 Jan 2026 12:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.141.101.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998167; cv=none; b=hUMwI76Iz7EdDsppeOFBi3LD2BlKY4eqJ2e05AkMmhYktKQJASvPz7PgnEZM6/eCVKIMw+bBKckjqWlfyBOmHr3g2glFnmNJWJpS08zMznDTWVR1Wd4AzwXUfJEku/QDRkIvDlLWJlw7w9hYZdTgU515pG9gfXC6KdF9PB90nag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998167; c=relaxed/simple; bh=B64XqHb0oVPQWEXKYQIWHeIvouUQHv7heMgcEaAUGmQ=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=iar/JRoUSjD4iSwhMtg+z2r3U38Dbvm3NSvFhRFf0lRqVqijvnw9YSns41Zh/vF5tnyaIIIO2i8OsRpqpu0V8uCGLLvomSRNasLDTE/wVtIq8bdMZG7Fn0KWy+vkrHawGSgpDuBhlXwfeY2YpXMFqLjxDhOd2HEX+ugO4IwDYHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=trvn.ru; spf=pass smtp.mailfrom=trvn.ru; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b=FDjSf5/9; arc=none smtp.client-ip=45.141.101.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=trvn.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trvn.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trvn.ru header.i=@trvn.ru header.b="FDjSf5/9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail; t=1768997761; bh=B64XqHb0oVPQWEXKYQIWHeIvouUQHv7heMgcEaAUGmQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FDjSf5/9ZudvSKdXmpn87FAerZd6LulSBkQGqz89ibvdKrAwGE2GykP8lLDxHifRc 1ljVr7btqN2xP5Fo5N+Wezm6Nw1ZvAHxczJcLJ6cNim0dJpehQfXr9P2allEsbPKm8 DcQD5msufBqq5FW7exIUBk1YZwgfndEFvrIoQ3ni58T8LWAxMsq3Q3QY2qWlRy5Mbu xpFgGYdgrbDJfXp1Uw1lY/raQMUve2+RF7+u0TzEk3QWDIqe288B8UGg3+lVMP2BxN J1IR1em8DJecPtvKCxNTMM9Eu1s+G3AUAE8FN19os/E7fxjJe7pCSHRXt20i5ydBpX LiPefQ0mJDGwQ== Received: from authenticated-user (box.trvn.ru [45.141.101.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by box.trvn.ru (Postfix) with ESMTPSA id 7FADB69760; Wed, 21 Jan 2026 17:16:01 +0500 (+05) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 21 Jan 2026 17:16:01 +0500 From: Nikita Travkin To: Konrad Dybcio Cc: Val Packett , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Dmitry Baryshkov , Neil Armstrong , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add support for ECS LIVA QC710 In-Reply-To: References: <20260120234029.419825-2-val@packett.cool> <20260120234029.419825-10-val@packett.cool> Message-ID: <376b932a192d0070b4435542fae62178@trvn.ru> X-Sender: nikita@trvn.ru Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Konrad Dybcio писал(а) 21.01.2026 16:20: > On 1/21/26 12:30 AM, Val Packett wrote: >> Add a device tree for the ECS LIVA QC710 (Snapdragon 7c) mini PC/devkit. >> >> Working: >> - Wi-Fi (wcn3990 hw1.0) >> - Bluetooth >> - USB Type-A (USB3 and USB2) >> - Ethernet (over USB2) >> - HDMI Display >> - eMMC >> - SDHC (microSD slot) >> >> Not included: >> - HDMI Audio >> - EC (IT8987) >> >> Signed-off-by: Val Packett >> --- > > [...] >> +&tlmm { >> + /* >> + * The TZ seem to protect those because some boards can have >> + * fingerprint sensor connected to this range. Not connected >> + * on this board >> + */ >> + gpio-reserved-ranges = <58 5>; > > Would it still work with <59 4>? 58 seems to not be related to a QUP, > rather as an audio MCLK output (would that be why +Nikita couldn't get > some sort of audio working on his aspire1? That DT has it reserved too) > FWIW according to aspire1 schematic GPIO 57 is codec mclk (which is implemented and works perfectly, only DMIC connected to the soc instead of said codec is broken); GPIO 58~62 are NC with a note "Finger Printer" [sic] near them. There is no bracket annotation to associate the note to specific pin range, but it's smack in the middle of 58~62 range and from the fact that 63 (speaker amp bclk) and pretty much every other pin later is also used, I guessed all 5 are actually reserved. It's possible that one of them is not actually reserved by the firmware but probably not the source of aspire1 issues (the dmic is connected to lpass tlmm anyway) or perhaps they reserved 58 to be an interrupt input for the fp, or something like that... Nikita > [...] > >> + data-pins { >> + pins = "sdc1_data"; >> + drive-strength = <2>; >> + bias-pull-up; > > here you do: > > drive-strength > bias- > > [...] > >> + sdc2_default: sdc2-default-state { >> + clk-pins { >> + pins = "sdc2_clk"; >> + bias-disable; >> + drive-strength = <16>; >> + }; > > here you do the inverse > > (the former is preferred/more common) > > otherwise > > Reviewed-by: Konrad Dybcio > > Konrad