Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Paul Sajna <sajattack@postmarketos.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	David Heidelberg <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	Amir Dahan <system64fumo@protonmail.com>,
	Christopher Brown <crispybrown@gmail.com>
Subject: Re: [PATCH v3 10/11] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
Date: Wed, 1 Oct 2025 11:09:37 +0200	[thread overview]
Message-ID: <38c70e06-f7bf-4ca6-8fe9-2a4012017cff@oss.qualcomm.com> (raw)
In-Reply-To: <20250928-judyln-dts-v3-10-b14cf9e9a928@postmarketos.org>

On 9/29/25 7:05 AM, Paul Sajna wrote:
> These regulators seemingly help the lcd to work better

Electronics generally work better when the required power supplies
are enabled..

> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 3106fdc9b679bc6a43a1a490c61b73a63003f7e1..9c3662a3d93e124667474753e0f11d0e98698aa0 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -48,10 +48,27 @@ zap-shader {
>  	};
>  };
>  
> +&ibb {
> +	regulator-min-microvolt = <4600000>;
> +	regulator-max-microvolt = <6000000>;
> +	regulator-over-current-protection;
> +	regulator-pull-down;
> +	regulator-soft-start;
> +	qcom,discharge-resistor-kohms = <300>;
> +};
> +
>  &ipa {
>  	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
>  };
>  
> +&lab {
> +	regulator-min-microvolt = <4600000>;
> +	regulator-max-microvolt = <6000000>;
> +	regulator-over-current-protection;
> +	regulator-pull-down;
> +	regulator-soft-start;
> +};

This patch will allow any values between 4.6 V and 6.0 V to
be set on your phone, with the kernel defaulting to 4.6 V at
boot and staying there until (if?) any driver requests that to
change.

Your panel probably expects a *very* specific pair of voltages
and any deviation may cause unpredictable consequences, including
magic smoke if you happen to go over a certain limit.

You should most likely hardcode that specific expected voltage here

Konrad

  reply	other threads:[~2025-10-01  9:09 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29  5:05 [PATCH v3 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-09-29  5:05 ` [PATCH v3 01/11] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
2025-10-03 21:31   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 02/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-10-03 21:30   ` Dmitry Baryshkov
2025-10-03 21:35   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 03/11] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger Paul Sajna
2025-10-03 21:31   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 04/11] arm64: dts: qcom: sdm845-lg-common: Add leds Paul Sajna
2025-10-01  9:01   ` Konrad Dybcio
2025-10-02  5:13     ` Paul Sajna
2025-10-06  8:34       ` Konrad Dybcio
2025-09-29  5:05 ` [PATCH v3 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
2025-10-03 21:34   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 06/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
2025-10-03 21:49   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 07/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
2025-10-01  9:14   ` Konrad Dybcio
2025-10-02  4:51     ` Paul Sajna
2025-10-02  9:37       ` Konrad Dybcio
2025-10-02 19:26         ` Paul Sajna
2025-10-03 17:13           ` Dmitry Baryshkov
2025-10-03 18:52             ` Paul Sajna
2025-10-03 19:36               ` Dmitry Baryshkov
2025-10-03 19:55                 ` Paul Sajna
2025-10-03 20:14                   ` Dmitry Baryshkov
2025-11-25  6:40         ` Paul Sajna
2025-11-25  6:51           ` Paul Sajna
2025-11-26  0:38             ` Dmitry Baryshkov
2025-11-26 12:14               ` David Heidelberg
2025-09-29  5:05 ` [PATCH v3 08/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
2025-10-03 21:49   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 09/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
2025-10-01  9:04   ` Konrad Dybcio
2025-10-05 19:35     ` Chris Brown
2025-10-05 22:23       ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 10/11] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
2025-10-01  9:09   ` Konrad Dybcio [this message]
2025-10-02  4:55     ` Paul Sajna
2025-10-03 21:55       ` Dmitry Baryshkov
2025-10-06  8:36         ` Konrad Dybcio
2025-11-25  8:09     ` Paul Sajna
2025-10-03 21:50   ` Dmitry Baryshkov
2025-09-29  5:05 ` [PATCH v3 11/11] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
2025-10-01  9:11   ` Konrad Dybcio
2025-11-25  4:29     ` Paul Sajna
2025-12-01 12:54       ` Konrad Dybcio
2025-12-02  2:52         ` Paul Sajna
2025-12-02 14:51           ` Konrad Dybcio
2025-10-03 21:56   ` Dmitry Baryshkov
2025-09-29 15:28 ` [PATCH v3 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Rob Herring (Arm)
2025-10-01  9:02 ` Konrad Dybcio
2025-10-02  5:25 ` Paul Sajna
2025-10-02  6:12   ` Paul Sajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38c70e06-f7bf-4ca6-8fe9-2a4012017cff@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crispybrown@gmail.com \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sajattack@postmarketos.org \
    --cc=system64fumo@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox