From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 19/21] drm/rcar-du: Remove FB_KMS_HELPER config option Date: Sat, 01 Aug 2015 13:02:23 +0300 Message-ID: <3965635.rVDv8MY2qM@avalon> References: <1436769848-4990-1-git-send-email-architt@codeaurora.org> <1436769848-4990-20-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:59765 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbbHAKBm (ORCPT ); Sat, 1 Aug 2015 06:01:42 -0400 In-Reply-To: <1436769848-4990-20-git-send-email-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Archit Taneja Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, airlied@linux.ie Hi Archit, Thank you for the patch. On Monday 13 July 2015 12:14:06 Archit Taneja wrote: > The driver internally uses drm_fb_cma helpers to emulate fbdev and > allocate buffers. It doesn't need to select DRM_FB_KMS_HELPER. This > will be managed by the config option DRM_KMS_CMA_HELPER. > > Cc: Laurent Pinchart > > Signed-off-by: Archit Taneja Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > b/drivers/gpu/drm/rcar-du/Kconfig index 11485a4..9de5872 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -5,7 +5,6 @@ config DRM_RCAR_DU > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER > - select DRM_KMS_FB_HELPER > select VIDEOMODE_HELPERS > help > Choose this option if you have an R-Car chipset. -- Regards, Laurent Pinchart